From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754301AbYCYKEd (ORCPT ); Tue, 25 Mar 2008 06:04:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752849AbYCYKEZ (ORCPT ); Tue, 25 Mar 2008 06:04:25 -0400 Received: from smtp-out03.alice-dsl.net ([88.44.63.5]:34398 "EHLO smtp-out03.alice-dsl.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbYCYKEY (ORCPT ); Tue, 25 Mar 2008 06:04:24 -0400 To: Christoph Hellwig Cc: Jack Steiner , mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions References: <20080324182116.GA28285@sgi.com> <20080325082756.GA6589@infradead.org> From: Andi Kleen Date: 25 Mar 2008 11:04:22 +0100 In-Reply-To: <20080325082756.GA6589@infradead.org> Message-ID: <87myoni0gp.fsf@basil.nowhere.org> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 25 Mar 2008 09:57:45.0410 (UTC) FILETIME=[AC9D0220:01C88E5E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > On Mon, Mar 24, 2008 at 01:21:16PM -0500, Jack Steiner wrote: > > > > Definitions of UV MMRs. > > Note: this file is auto-generated by hardware design tools. > > Which is still not an excuse for the crap in there. Please submit a > proper header with the needed defintions and shift & mask defintions and > helpers instead of the bitfields. bitfields are only problematic on portable code, which this isn't. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions References: <20080324182116.GA28285@sgi.com> <20080325082756.GA6589@infradead.org> From: Andi Kleen Date: 25 Mar 2008 11:04:22 +0100 In-Reply-To: <20080325082756.GA6589@infradead.org> Message-ID: <87myoni0gp.fsf@basil.nowhere.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Hellwig Cc: Jack Steiner , mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Christoph Hellwig writes: > On Mon, Mar 24, 2008 at 01:21:16PM -0500, Jack Steiner wrote: > > > > Definitions of UV MMRs. > > Note: this file is auto-generated by hardware design tools. > > Which is still not an excuse for the crap in there. Please submit a > proper header with the needed defintions and shift & mask defintions and > helpers instead of the bitfields. bitfields are only problematic on portable code, which this isn't. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org