From: Kalle Valo <Kalle.Valo@nokia.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Bruno Randolf <bruno@thinktube.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH] ath5k: consistent info and error logging
Date: Fri, 16 Nov 2007 15:17:43 +0200 [thread overview]
Message-ID: <87mytez5vs.fsf@nokia.com> (raw)
In-Reply-To: <1195214563.8147.118.camel@johannes.berg> (ext Johannes Berg's message of "Fri\, 16 Nov 2007 13\:02\:43 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
>> +#define AR5K_INFO(_sc, _fmt, ...) \
>> + printk(KERN_INFO "ath5k %s: " _fmt, wiphy_name((_sc)->hw->wiphy), ##__VA_ARGS__)
>
> Eww. Can't you make them static inlines?
Wasn't it so that a inline function with va_args is not possible?
I can be wrong, though.
--
Kalle Valo
next prev parent reply other threads:[~2007-11-16 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 8:10 [PATCH] ath5k: consistent info and error logging Bruno Randolf
2007-11-16 8:13 ` bruno randolf
2007-11-16 12:02 ` Johannes Berg
2007-11-16 13:17 ` Kalle Valo [this message]
2007-11-16 15:53 ` Johannes Berg
2007-11-19 4:01 ` bruno randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mytez5vs.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=bruno@thinktube.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.