From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1D6bYo-0006dK-SC for mharc-grub-devel@gnu.org; Wed, 02 Mar 2005 16:39:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D6bYm-0006cR-Nt for grub-devel@gnu.org; Wed, 02 Mar 2005 16:39:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D6bYk-0006bc-Ra for grub-devel@gnu.org; Wed, 02 Mar 2005 16:39:12 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D6bYk-0006aG-IR for grub-devel@gnu.org; Wed, 02 Mar 2005 16:39:10 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D6bHB-0000iL-WF for grub-devel@gnu.org; Wed, 02 Mar 2005 16:21:02 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 615428E75 for ; Wed, 2 Mar 2005 22:20:59 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 16907-06 for ; Wed, 2 Mar 2005 22:20:57 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 4E3038AAE for ; Wed, 2 Mar 2005 22:20:57 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 15F7FC04F for ; Wed, 2 Mar 2005 22:20:57 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <42130AAA.7030500@omniflux.com> <200503022201.24046.okuji@enbug.org> From: Marco Gerards Date: Wed, 02 Mar 2005 22:20:58 +0100 In-Reply-To: <200503022201.24046.okuji@enbug.org> (Yoshinori K. Okuji's message of "Wed, 2 Mar 2005 22:01:23 +0100") Message-ID: <87mztloibp.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: fs/fat.c assumes that 0UL is the same for 32bit and 64bit archs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2005 21:39:13 -0000 "Yoshinori K. Okuji" writes: > On Wednesday 16 February 2005 09:56, Omniflux wrote: >> fs/fat.c assumes that 0UL is the same for 32bit and 64bit archs, but >> it is not. >> >> There are four locations in fs/fat.c where a 32bit unsigned int is >> set equal to 0UL. This causes warnings when compiling on 64bit >> architectures as 0UL is 0xffffffffffffffff (64bits) there. > > Marco, did you look at this patch? Yes. Sorry, I forgot to reply after I got back. :) The patch looked fine to me. I have encountered this problem as well on 64 bits archs but I ddi not test the patch yet myself, I can't at the moment. Because this seems to be the only way to fix this problem, I don't think there are copyright issues and the patch can be applied. Right? Thanks, Marco