All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zlatko Calusic <Zlatko.Calusic@CARNet.hr>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Linux Kernel List <linux-kernel@vger.rutgers.edu>,
	Linux-MM List <linux-mm@kvack.org>
Subject: Re: Linux-2.1.129..
Date: 25 Nov 1998 21:33:50 +0100	[thread overview]
Message-ID: <87n25f5x75.fsf@atlas.CARNet.hr> (raw)
In-Reply-To: "Stephen C. Tweedie"'s message of "Tue, 24 Nov 1998 15:25:03 GMT"

"Stephen C. Tweedie" <sct@redhat.com> writes:

> --- mm/vmscan.c~	Tue Nov 17 15:43:55 1998
> +++ mm/vmscan.c	Mon Nov 23 17:05:33 1998
> @@ -170,7 +170,7 @@
>  			 * copy in memory, so we add it to the swap
>  			 * cache. */
>  			if (PageSwapCache(page_map)) {
> -				free_page_and_swap_cache(page);
> +				free_page(page);
>  				return (atomic_read(&page_map->count) == 0);
>  			}
>  			add_to_swap_cache(page_map, entry);
> @@ -188,7 +188,7 @@
>  		 * asynchronously.  That's no problem, shrink_mmap() can
>  		 * correctly clean up the occassional unshared page
>  		 * which gets left behind in the swap cache. */
> -		free_page_and_swap_cache(page);
> +		free_page(page);
>  		return 1;	/* we slept: the process may not exist any more */
>  	}
>  
> @@ -202,7 +202,7 @@
>  		set_pte(page_table, __pte(entry));
>  		flush_tlb_page(vma, address);
>  		swap_duplicate(entry);
> -		free_page_and_swap_cache(page);
> +		free_page(page);
>  		return (atomic_read(&page_map->count) == 0);
>  	} 
>  	/* 
> @@ -218,7 +218,11 @@
>  	flush_cache_page(vma, address);
>  	pte_clear(page_table);
>  	flush_tlb_page(vma, address);
> +#if 0
>  	entry = page_unuse(page_map);
> +#else
> +	entry = (atomic_read(&page_map->count) == 1);
> +#endif
>  	__free_page(page_map);
>  	return entry;
>  }

I must admit that after some preliminary testing I can't believe how
GOOD these changes work!

Stephen, you've done a *really* good job.

I will still do some more testing, not to find bugs, but to enjoy
great performance. :)

Everybody, get pre-2.1.130-3 (which already includes above changes),
add #include <linux/interrupt.h> in kernel/itimer.c and enjoy the most
fair MM in Linux, EVER!

Stephen, thanks for such a good code!
-- 
Posted by Zlatko Calusic           E-mail: <Zlatko.Calusic@CARNet.hr>
---------------------------------------------------------------------
	   REALITY.SYS Corrupted: Re-boot universe? (Y/N/Q)
--
This is a majordomo managed list.  To unsubscribe, send a message with
the body 'unsubscribe linux-mm me@address' to: majordomo@kvack.org

  parent reply	other threads:[~1998-11-25 20:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.3.95.981119002335.838A-100000@penguin.transmeta.com>
1998-11-19 21:34 ` Linux-2.1.129 Dr. Werner Fink
1998-11-19 21:58   ` Linux-2.1.129 Rik van Riel
1998-11-20 12:09     ` Linux-2.1.129 Dr. Werner Fink
1998-11-19 22:33   ` Linux-2.1.129 Linus Torvalds
1998-11-23 17:13     ` Linux-2.1.129 Stephen C. Tweedie
1998-11-23 19:16       ` Linux-2.1.129 Eric W. Biederman
1998-11-23 20:02         ` Linux-2.1.129 Linus Torvalds
1998-11-23 21:25           ` Linux-2.1.129 Rik van Riel
1998-11-23 22:19           ` Linux-2.1.129 Dr. Werner Fink
1998-11-24  3:37           ` Linux-2.1.129 Eric W. Biederman
1998-11-24 15:25           ` Linux-2.1.129 Stephen C. Tweedie
1998-11-24 17:33             ` Linux-2.1.129 Linus Torvalds
1998-11-24 19:59               ` Linux-2.1.129 Rik van Riel
1998-11-24 20:45                 ` Linux-2.1.129 Linus Torvalds
1998-11-25 14:19               ` Linux-2.1.129 Stephen C. Tweedie
1998-11-25 21:07                 ` Linux-2.1.129 Eric W. Biederman
1998-11-26 12:57                   ` Linux-2.1.129 Stephen C. Tweedie
1998-11-25 20:33             ` Zlatko Calusic [this message]
1998-11-23 19:46       ` Linux-2.1.129 Eric W. Biederman
1998-11-23 21:18         ` Linux-2.1.129 Rik van Riel
1998-11-24  6:28           ` Linux-2.1.129 Eric W. Biederman
1998-11-24  7:56             ` Linux-2.1.129 Rik van Riel
1998-11-24 15:48             ` Linux-2.1.129 Stephen C. Tweedie
1998-11-24 15:38         ` Linux-2.1.129 Stephen C. Tweedie
1998-11-23 20:12       ` Linux-2.1.129 Rik van Riel
1998-11-23 20:53       ` Running 2.1.129 at extrem load [patch] (Was: Linux-2.1.129..) Dr. Werner Fink
1998-11-23 21:59         ` Rik van Riel
1998-11-23 22:35           ` Dr. Werner Fink
1998-11-24 12:38             ` Dr. Werner Fink
1998-11-19 19:22 Linux-2.1.129 David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87n25f5x75.fsf@atlas.CARNet.hr \
    --to=zlatko.calusic@carnet.hr \
    --cc=linux-kernel@vger.rutgers.edu \
    --cc=linux-mm@kvack.org \
    --cc=sct@redhat.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.