From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 190D1C5B572 for ; Sun, 16 Aug 2026 04:20:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B948940793; Sun, 16 Aug 2026 04:20:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WcsscqAAaoWO; Sun, 16 Aug 2026 04:20:58 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E4B39407AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org; s=default; t=1786854058; bh=FBviHUX6VgxYUnLxDYU5mBqN6GGxZfZerxT+9hgjSoU=; h=To:Cc:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=k1w3z5oOsnn7yBOzUPJyww1hsKOnEBcYjDiDq+WKPbAldFjXAqNNW7SWAJwEJya9y iGnYMme7XR5kXkPQPLU33F7gzNr+UVuXq3ucSjG7yqRUeW02ebGctGrcDVeECU0Rh+ LRobjtuz6ShGSV0aGCG9MxVEVhgiyDt4mhxoSvv/A4nA/IZ4azHupyZmoGdsZnG0WQ 45mUJ2Yag0L3wEgKILfHpN6mNMILRLuIG3AvWObZUmwLd1FniE20zLVwKomdADpEh8 XfVgraqoGoQWP9A13kxs7kCJKmhKn0naZYf85mRQTeX3h/S+6YWpx5WqHOyhYyuDMO KFxn7/fC3XOPg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id E4B39407AD; Sun, 16 Aug 2026 04:20:57 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 502ED282 for ; Sun, 16 Aug 2026 04:20:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4190E407AD for ; Sun, 16 Aug 2026 04:20:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JglcR8mEaRlk for ; Sun, 16 Aug 2026 04:20:56 +0000 (UTC) Received-SPF: Permerror (mailfrom) identity=mailfrom; client-ip=84.110.109.230; helo=mail.tkos.co.il; envelope-from=baruch@tkos.co.il; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 218F940793 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 218F940793 Received: from mail.tkos.co.il (guitar.tkos.co.il [84.110.109.230]) by smtp4.osuosl.org (Postfix) with ESMTPS id 218F940793 for ; Sun, 16 Aug 2026 04:20:55 +0000 (UTC) Received: from localhost (unknown [10.0.8.2]) by mail.tkos.co.il (Postfix) with ESMTP id 5FFF844062B; Sun, 16 Aug 2026 07:20:44 +0300 (IDT) To: Charlie Jenkins Cc: buildroot@buildroot.org In-Reply-To: <20260815-ncurses_strip-v1-1-da424b80d70d@gmail.com> (Charlie Jenkins's message of "Sat, 15 Aug 2026 18:27:12 -0700") References: <20260815-ncurses_strip-v1-1-da424b80d70d@gmail.com> User-Agent: mu4e 1.14.2; emacs 30.2 Date: Sun, 16 Aug 2026 07:20:52 +0300 Message-ID: <87o6f2wva3.fsf@tarshish> MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH] package/ncurses: Enable stripping of progs X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Baruch Siach via buildroot Reply-To: Baruch Siach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hi Charlie, On Sat, Aug 15 2026, Charlie Jenkins wrote: > Commit 2ab611c40ff08bd4a7922456fed22af6953af3b1("ncurses: fix build > failure with ncurses 6.1") added --disable-stripping to the ncurses > build because ncurses started stripping by default but using the host > strip instead of the cross strip. > > Enable stripping and change the strip program to $(TARGET_CROSS)strip. > This shrinks the binary sizes of the programs generated by > BR2_PACKAGE_NCURSES_TARGET_PROGS on aarch64 by: > > clear: 18k -> 10k > infocmp: 76k -> 62k > tabs: 27k -> 18k > tic: 103k -> 87k > toe: 27k -> 18k > tput: 33k -> 22k > tset: 33k -> 22k The 'target-finalize' target defined in top level Makefile should strip all target binaries. Lookup STRIPCMD in top Makefile. Doesn't that work for ncurses binaries? baruch > > Signed-off-by: Charlie Jenkins > --- > package/ncurses/ncurses.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk > index 5e2077500a..e017bacf6e 100644 > --- a/package/ncurses/ncurses.mk > +++ b/package/ncurses/ncurses.mk > @@ -31,7 +31,7 @@ NCURSES_CONF_OPTS = \ > --enable-const \ > --enable-overwrite \ > --enable-pc-files \ > - --disable-stripping \ > + --with-strip-program=$(TARGET_CROSS)strip \ > --with-pkg-config-libdir="/usr/lib/pkgconfig" \ > $(if $(BR2_PACKAGE_NCURSES_TARGET_PROGS),,--without-progs) \ > --without-manpages > > --- > base-commit: e389f1b44c54660c7bb5512207a561e684b41595 > change-id: 20260815-ncurses_strip-615a30afa120 > > Best regards, -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot