Re: [PATCH v2 07/17] crypto/cipher: Add GCM to QCryptoCipherMode

[Markus Armbruster <armbru@redhat.com>]

Jamin Lin <jamin_lin@aspeedtech.com> writes:

> Introduce the GCM cipher mode so authenticated encryption can be built
> on top of the existing qcrypto_cipher API. GCM is an IV-based mode, so
> register it in mode_need_iv. No backend advertises it yet, so it stays
> unsupported until a backend and the AAD/tag helpers are added in the
> following patches.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Acked-by: Daniel P. Berrangé <berrange@redhat.com>

Same person giving Reviewed-by and Acked-by is odd.  Daniel, is this
what you want?

> ---
>  qapi/crypto.json | 4 +++-
>  crypto/cipher.c  | 1 +
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index 2b55befef9..6e3a98ff68 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -121,10 +121,12 @@
>  #
>  # @ctr: Counter (Since 2.8)
>  #
> +# @gcm: Galois/Counter Mode (Since 11.2)
> +#
>  # Since: 2.6
>  ##
>  { 'enum': 'QCryptoCipherMode',
> -  'data': ['ecb', 'cbc', 'xts', 'ctr']}
> +  'data': ['ecb', 'cbc', 'xts', 'ctr', 'gcm']}
>  
>  ##
>  # @QCryptoIVGenAlgo:

Acked-by: Markus Armbruster <armbru@redhat.com>


[...]