From: Takashi Iwai <tiwai@suse.de>
To: Robertus Diawan Chris <robertusdchris@gmail.com>
Cc: g@b4.vu, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org, me@brighamcampbell.com
Subject: Re: [PATCH RFT] ALSA: scarlett2: Add missing error check when initialise Autogain Status
Date: Fri, 15 May 2026 08:33:27 +0200 [thread overview]
Message-ID: <87o6ihuqq0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260508033914.111596-1-robertusdchris@gmail.com>
On Fri, 08 May 2026 05:39:14 +0200,
Robertus Diawan Chris wrote:
>
> When initialise new control with scarlett2_add_new_ctl() function for
> Autogain Status, scarlett2_add_new_ctl() might throw an error. So, add
> error check after initialise new control for Autogain Status.
>
> This is reported by Coverity Scan with CID 1598781 as UNUSED_VALUE.
>
> Fixes: 0a995e38dc44 ("ALSA: scarlett2: Add support for software-controllable input gain")
> Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-05-15 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 3:39 [PATCH RFT] ALSA: scarlett2: Add missing error check when initialise Autogain Status Robertus Diawan Chris
2026-05-15 6:33 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6ihuqq0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=g@b4.vu \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=perex@perex.cz \
--cc=robertusdchris@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.