From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A5E7F436B2 for ; Fri, 17 Apr 2026 15:17:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDkwN-0002g3-9T; Fri, 17 Apr 2026 11:17:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDkwF-0002bY-S1 for qemu-devel@nongnu.org; Fri, 17 Apr 2026 11:16:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDkwE-0000lw-67 for qemu-devel@nongnu.org; Fri, 17 Apr 2026 11:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776439017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gCdVN1InJjjAPIc6kI9/rTFKYGxxMMzmniFObAp75RM=; b=XpuQO6D0GJ3casXN4SKHDIfu/ll5MLPC12t77W1rIOpW9YBJLZjyATAevKVRZQtbDhO32C 7V6dG7yVYrN7kO1EzBSfXGROlacaLFxllCgpPH5ixwQA1L6i2Ubdsq0OZzwf14r7W7QvTX vN9UCriNELXMK9MH34cwRQrol8LvEgg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-ky-s_PkpNv6YX8Cg5y7Dfg-1; Fri, 17 Apr 2026 11:16:53 -0400 X-MC-Unique: ky-s_PkpNv6YX8Cg5y7Dfg-1 X-Mimecast-MFC-AGG-ID: ky-s_PkpNv6YX8Cg5y7Dfg_1776439007 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 394441953951; Fri, 17 Apr 2026 15:16:43 +0000 (UTC) Received: from localhost (unknown [10.44.48.66]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 75D523000C28; Fri, 17 Apr 2026 15:16:42 +0000 (UTC) From: Cornelia Huck To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Ilya Leoshkevich , Eric Farman , David Hildenbrand , qemu-s390x@nongnu.org, Richard Henderson , Matthew Rosato , Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= Subject: Re: [PATCH] target/s390x: Prefer MO_128 definition over magic value In-Reply-To: <20260415220358.93063-1-philmd@linaro.org> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Avril Crosse O'Flaherty" References: <20260415220358.93063-1-philmd@linaro.org> User-Agent: Notmuch/0.39 (https://notmuchmail.org) Date: Fri, 17 Apr 2026 17:16:40 +0200 Message-ID: <87o6jhty5j.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Apr 16 2026, Philippe Mathieu-Daud=C3=A9 wrote: > The MO_128 definition was not existing when commit 6d841663be8 > ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the > ES_128 definition. It was added 2 years later in commit 4b473e0c60d > ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available, > replace the magic '4' by the more explicit 'MO_128'. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > target/s390x/tcg/translate_vx.c.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, queued to s390-next.