From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/xe3p_lpg: Add missing indirect ring state feature flag
Date: Mon, 6 Apr 2026 11:45:41 -0300 [thread overview]
Message-ID: <87o6jw406i.fsf@intel.com> (raw)
In-Reply-To: <20260401223401.GH183713@mdroper-desk1.amr.corp.intel.com>
Matt Roper <matthew.d.roper@intel.com> writes:
> On Wed, Apr 01, 2026 at 07:10:51PM -0300, Gustavo Sousa wrote:
>> Even though commit 8fcb7dfb8bbf ("drm/xe/xe3p_lpg: Add support for
>> graphics IP 35.10") mentions that the support for Indirect Ring State
>> exists for Xe3p_LPG, it missed actually setting the feature flag in
>> graphics_xe3p_lpg. Fix that by adding the missing member.
>>
>> Fixes: 8fcb7dfb8bbf ("drm/xe/xe3p_lpg: Add support for graphics IP 35.10")
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Pushed to drm-xe-next. Thanks for the review!
--
Gustavo Sousa
>
>> ---
>> drivers/gpu/drm/xe/xe_pci.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 1df3f08e2e1c..6e560ef84a97 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -118,6 +118,7 @@ static const struct xe_graphics_desc graphics_xe2 = {
>>
>> static const struct xe_graphics_desc graphics_xe3p_lpg = {
>> XE2_GFX_FEATURES,
>> + .has_indirect_ring_state = 1,
>> .multi_queue_engine_class_mask = BIT(XE_ENGINE_CLASS_COPY) | BIT(XE_ENGINE_CLASS_COMPUTE),
>> .num_geometry_xecore_fuse_regs = 3,
>> .num_compute_xecore_fuse_regs = 3,
>>
>> ---
>> base-commit: 40f5b5bc2d3df4c7c2d4e27b35b2d8179ac3f10b
>> change-id: 20260401-xe3p_lpg-indirect-ring-state-6220d15b2322
>>
>> Best regards,
>> --
>> Gustavo Sousa <gustavo.sousa@intel.com>
>>
>
> --
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation
next prev parent reply other threads:[~2026-04-06 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 22:10 [PATCH] drm/xe/xe3p_lpg: Add missing indirect ring state feature flag Gustavo Sousa
2026-04-01 22:18 ` ✓ CI.KUnit: success for " Patchwork
2026-04-01 22:34 ` [PATCH] " Matt Roper
2026-04-06 14:45 ` Gustavo Sousa [this message]
2026-04-01 22:53 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-04-02 6:27 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6jw406i.fsf@intel.com \
--to=gustavo.sousa@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.