From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert" <dave@treblig.org>
Cc: berrange@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/4] hmp*hx: Move info docs
Date: Fri, 16 Jan 2026 09:45:05 +0100 [thread overview]
Message-ID: <87o6murlny.fsf@pond.sub.org> (raw)
In-Reply-To: <aWk1FvYlhq6a1Sbm@gallifrey> (David Alan Gilbert's message of "Thu, 15 Jan 2026 18:42:30 +0000")
"Dr. David Alan Gilbert" <dave@treblig.org> writes:
> * Markus Armbruster (armbru@redhat.com) wrote:
>> dave@treblig.org writes:
>>
>> > From: "Dr. David Alan Gilbert" <dave@treblig.org>
>> >
>> > Move the docs for the info subcommand from the separate hx
>> > into the top level file next to the 'info' command itself.
>> > That makes every command in the top level file have a RST section.
>> >
>> > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
>>
>> Generated HTML changes slightly, diff appended. Shows as vertical space
>> differences in Firefox. Do we care?
>
> It looked OK to me in Firefox, is there a bit that looks wrong/bad to you?
The vertical spacing around "info subcommand" changes.
Old: extra space between "xen-event-list" and "info subcommand" compared
to between other commands.
New: extra space between "info subcommand"'s doc text and "info
version".
Hypothesis: the extra space is at the boundary between hmp-commands.hx
and hmp-commands-info.hx.
I dislike the old extra space a bit less, but no big deal either way.
[...]
next prev parent reply other threads:[~2026-01-16 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 2:04 [PATCH 0/4] HMP: hxtool sanity checks dave
2026-01-15 2:04 ` [PATCH 1/4] hmp-commands-info.hx: Move definition of "info accel" dave
2026-01-15 2:04 ` [PATCH 2/4] hmp*hx: Move info docs dave
2026-01-15 11:57 ` Markus Armbruster
2026-01-15 18:42 ` Dr. David Alan Gilbert
2026-01-16 8:45 ` Markus Armbruster [this message]
2026-01-15 2:04 ` [PATCH 3/4] hxtool: Split srst/erst add checks dave
2026-01-15 12:11 ` Markus Armbruster
2026-01-15 2:04 ` [PATCH 4/4] hxtool: Error on missing docs dave
2026-01-15 12:17 ` Markus Armbruster
2026-01-15 12:43 ` Dr. David Alan Gilbert
2026-01-15 11:15 ` [PATCH 0/4] HMP: hxtool sanity checks Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6murlny.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.