From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 985D0CCFA18 for ; Tue, 11 Nov 2025 05:26:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIgtA-0007cq-Qy; Tue, 11 Nov 2025 00:25:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIgt8-0007Yv-JT for qemu-arm@nongnu.org; Tue, 11 Nov 2025 00:25:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIgt4-00033U-AJ for qemu-arm@nongnu.org; Tue, 11 Nov 2025 00:25:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762838748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CB6DvjrqlBdwjN3WWokNKyJDghADoJ1UZDWjgQz03K8=; b=GJeaZxZHPrF9A+LLeY5hmoQwT23uKZn4Hz7L5f4c8a6PV+6uSUEkCre+li9zcxIel3ZdtP Wtk+wFPpMmDSPgWfCioFLo5eh2dqw8ZOgJqe7LlbNbVHdocJp0DE1i2KFpUAMcCx8PFBm/ qUcTaOdPnznDlel/BuNeykNkObYHuFE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-OzAjLeTTNum5Gq7Dc8gKxg-1; Tue, 11 Nov 2025 00:25:44 -0500 X-MC-Unique: OzAjLeTTNum5Gq7Dc8gKxg-1 X-Mimecast-MFC-AGG-ID: OzAjLeTTNum5Gq7Dc8gKxg_1762838743 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B5AF19560B2; Tue, 11 Nov 2025 05:25:43 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 15E6A19560A2; Tue, 11 Nov 2025 05:25:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 87A1321E6A27; Tue, 11 Nov 2025 06:25:39 +0100 (CET) From: Markus Armbruster To: Gavin Shan Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, jonathan.cameron@huawei.com, mchehab+huawei@kernel.org, gengdongjiu1@gmail.com, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com, shan.gavin@gmail.com Subject: Re: [PATCH v3 6/8] acpi/ghes: Use error_abort in acpi_ghes_memory_errors() In-Reply-To: <20251105114453.2164073-7-gshan@redhat.com> (Gavin Shan's message of "Wed, 5 Nov 2025 21:44:51 +1000") References: <20251105114453.2164073-1-gshan@redhat.com> <20251105114453.2164073-7-gshan@redhat.com> Date: Tue, 11 Nov 2025 06:25:39 +0100 Message-ID: <87o6p9gmy4.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Gavin Shan writes: > Use error_abort in acpi_ghes_memory_errors() so that the caller needn't > explicitly call abort() on errors. With this change, its return value > isn't needed any more. > > Suggested-by: Igor Mammedov > Signed-off-by: Gavin Shan > --- > hw/acpi/ghes-stub.c | 6 +++--- > hw/acpi/ghes.c | 15 ++++----------- > include/hw/acpi/ghes.h | 5 +++-- > target/arm/kvm.c | 10 +++------- > 4 files changed, 13 insertions(+), 23 deletions(-) > > diff --git a/hw/acpi/ghes-stub.c b/hw/acpi/ghes-stub.c > index 4faf573aeb..4ef914ffc5 100644 > --- a/hw/acpi/ghes-stub.c > +++ b/hw/acpi/ghes-stub.c > @@ -11,10 +11,10 @@ > #include "qemu/osdep.h" > #include "hw/acpi/ghes.h" >=20=20 > -int acpi_ghes_memory_errors(AcpiGhesState *ags, uint16_t source_id, > - uint64_t *addresses, uint32_t num_of_address= es) > +void acpi_ghes_memory_errors(AcpiGhesState *ags, uint16_t source_id, > + uint64_t *addresses, uint32_t num_of_addres= ses, > + Error **errp) > { > - return -1; > } Before the patch, this function always fails: it returns -1. Afterwards, it always succeeds: it doesn't set @errp. Which one is correct? >=20=20 > AcpiGhesState *acpi_ghes_get_state(void) > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index 055e5d719a..aa469c03f2 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -543,8 +543,9 @@ void ghes_record_cper_errors(AcpiGhesState *ags, cons= t void *cper, size_t len, > notifier_list_notify(&acpi_generic_error_notifiers, &source_id); > } >=20=20 > -int acpi_ghes_memory_errors(AcpiGhesState *ags, uint16_t source_id, > - uint64_t *addresses, uint32_t num_of_address= es) > +void acpi_ghes_memory_errors(AcpiGhesState *ags, uint16_t source_id, > + uint64_t *addresses, uint32_t num_of_addres= ses, > + Error **errp) qapi/error.h: * - Whenever practical, also return a value that indicates success / * failure. This can make the error checking more concise, and can * avoid useless error object creation and destruction. Note that * we still have many functions returning void. We recommend * =E2=80=A2 bool-valued functions return true on success / false on fail= ure, * =E2=80=A2 pointer-valued functions return non-null / null pointer, and * =E2=80=A2 integer-valued functions return non-negative / negative. > { > /* Memory Error Section Type */ > const uint8_t guid[] =3D > @@ -555,7 +556,6 @@ int acpi_ghes_memory_errors(AcpiGhesState *ags, uint1= 6_t source_id, > * Table 17-13 Generic Error Data Entry > */ > QemuUUID fru_id =3D {}; > - Error *errp =3D NULL; > int data_length; > GArray *block; > uint32_t block_status, i; > @@ -592,16 +592,9 @@ int acpi_ghes_memory_errors(AcpiGhesState *ags, uint= 16_t source_id, > } >=20=20 > /* Report the error */ > - ghes_record_cper_errors(ags, block->data, block->len, source_id, &er= rp); > + ghes_record_cper_errors(ags, block->data, block->len, source_id, err= p); >=20=20 > g_array_free(block, true); > - > - if (errp) { > - error_report_err(errp); > - return -1; > - } > - > - return 0; > } The error reporting moves into the caller. >=20=20 > AcpiGhesState *acpi_ghes_get_state(void) > diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h > index f73908985d..35c7bbbb01 100644 > --- a/include/hw/acpi/ghes.h > +++ b/include/hw/acpi/ghes.h > @@ -98,8 +98,9 @@ void acpi_build_hest(AcpiGhesState *ags, GArray *table_= data, > const char *oem_id, const char *oem_table_id); > void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s, > GArray *hardware_errors); > -int acpi_ghes_memory_errors(AcpiGhesState *ags, uint16_t source_id, > - uint64_t *addresses, uint32_t num_of_address= es); > +void acpi_ghes_memory_errors(AcpiGhesState *ags, uint16_t source_id, > + uint64_t *addresses, uint32_t num_of_addres= ses, > + Error **errp); > void ghes_record_cper_errors(AcpiGhesState *ags, const void *cper, size_= t len, > uint16_t source_id, Error **errp); >=20=20 > diff --git a/target/arm/kvm.c b/target/arm/kvm.c > index 459ca4a9b0..a889315606 100644 > --- a/target/arm/kvm.c > +++ b/target/arm/kvm.c > @@ -2458,13 +2458,9 @@ void kvm_arch_on_sigbus_vcpu(CPUState *c, int code= , void *addr) > addresses[0] =3D paddr; > if (code =3D=3D BUS_MCEERR_AR) { > kvm_cpu_synchronize_state(c); > - if (!acpi_ghes_memory_errors(ags, ACPI_HEST_SRC_ID_SYNC, > - addresses, 1)) { > - kvm_inject_arm_sea(c); > - } else { > - error_report("failed to record the error"); > - abort(); > - } > + acpi_ghes_memory_errors(ags, ACPI_HEST_SRC_ID_SYNC, > + addresses, 1, &error_abort); > + kvm_inject_arm_sea(c); Before the patch, we get two error reports, like this: qemu-system-FOO: OSPM does not acknowledge previous error, so can not r= ecord CPER for current error anymore qemu-system-FOO: failed to record the error Aborted (core dumped) Such error cascades should be avoided. Afterwards, we get one: Unexpected error at SOURCE-FILE:LINE-NUMBER: qemu-system-FOO: OSPM does not acknowledge previous error, so can not r= ecord CPER for current error anymore Aborted (core dumped) Are all errors reported by acpi_ghes_memory_errors() programming errors, i.e. when an error is reported, there's a bug for us to fix? If not, abort() is wrong before the patch, and &error_abort is wrong afterwards. You can use &error_fatal for fatal errors that are not programming errors. > } > return; > }