From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Quentin Schulz <foss+uboot@0leil.net>,
Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Casey Connolly <casey.connolly@linaro.org>,
Martin Schwan <m.schwan@phytec.de>,
Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL
Date: Fri, 31 Oct 2025 16:14:56 +0100 [thread overview]
Message-ID: <87o6pn5ci7.fsf@kernel.org> (raw)
In-Reply-To: <20251029-spl-fit-full-check-desc-v1-1-ebb42c9d97bd@cherry.de>
Hi Quentin,
Thank you for the patch.
On Wed, Oct 29, 2025 at 12:08, Quentin Schulz <foss+uboot@0leil.net> wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> SPL_FIT_FULL_CHECK currently shares its description and help text with
> FIT_FULL_CHECK which is quite confusing, so let's specify this applies
> to SPL.
>
> Fixes: 6f3c2d8aa5e6 ("image: Add an option to do a full check of the FIT")
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> boot/Kconfig | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 9adb051400f..db114baa077 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -193,13 +193,13 @@ config SPL_FIT_PRINT
> Support printing the content of the fitImage in a verbose manner in SPL.
>
> config SPL_FIT_FULL_CHECK
> - bool "Do a full check of the FIT before using it"
> + bool "Do a full check of the FIT within SPL before using it"
> depends on SPL_FIT
> help
> - Enable this do a full check of the FIT to make sure it is valid. This
> - helps to protect against carefully crafted FITs which take advantage
> - of bugs or omissions in the code. This includes a bad structure,
> - multiple root nodes and the like.
> + Enable this do a full check of the FIT within SPL to make sure it is
> + valid. This helps to protect against carefully crafted FITs which take
> + advantage of bugs or omissions in the code. This includes a bad
> + structure, multiple root nodes and the like.
>
> config SPL_FIT_SIGNATURE
> bool "Enable signature verification of FIT firmware within SPL"
>
> ---
> base-commit: 4cad9faf8d2887b8851f0ced5194ffbaa92ca71e
> change-id: 20251029-spl-fit-full-check-desc-15d43348db55
>
> Best regards,
> --
> Quentin Schulz <quentin.schulz@cherry.de>
next prev parent reply other threads:[~2025-10-31 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 11:08 [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL Quentin Schulz
2025-10-31 15:14 ` Mattijs Korpershoek [this message]
2025-11-07 14:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6pn5ci7.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=foss+uboot@0leil.net \
--cc=m.schwan@phytec.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=michal.simek@amd.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.