From: Marc Zyngier <maz@kernel.org>
To: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-acpi@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Mark\ Rutland" <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J.\ Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
"Saravana\ Kannan" <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@linaro.org>
Subject: Re: [PATCH v2 11/25] genirq: Kill handle_percpu_devid_fasteoi_nmi()
Date: Sun, 21 Sep 2025 16:32:14 +0100 [thread overview]
Message-ID: <87o6r3yg75.wl-maz@kernel.org> (raw)
In-Reply-To: <20250916163838.00003791@huawei.com>
On Tue, 16 Sep 2025 16:38:38 +0100,
Jonathan Cameron <jonathan.cameron@huawei.com> wrote:
>
> On Mon, 15 Sep 2025 09:56:48 +0100
> Marc Zyngier <maz@kernel.org> wrote:
>
> > There is no in-tree user of this flow handler anymore, so simply
> > remove it.
> >
> > Suggested-by: Will Deacon <will@kernel.org>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > ---
>
> > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> > index 0d0276378c707..869068ec6ac91 100644
> > --- a/kernel/irq/chip.c
> > +++ b/kernel/irq/chip.c
> > @@ -892,7 +892,8 @@ void handle_percpu_irq(struct irq_desc *desc)
> > *
> > * action->percpu_dev_id is a pointer to percpu variables which
> > * contain the real device id for the cpu on which this handler is
> > - * called
> > + * called. This is also used for per-CPU NMIs, so special care is
> > + * required.
>
> Probably belongs in previous patch as not really related to removing
> the unused code, but meh.
Actually, I think I'll simply drop this comment. It really doesn't
bring much to the table.
Thanks,
M.
--
Jazz isn't dead. It just smells funny.
next prev parent reply other threads:[~2025-09-21 15:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 8:56 [PATCH v2 00/25] genirq: Add support for percpu_devid IRQ affinity Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 01/25] irqdomain: Add firmware info reporting interface Marc Zyngier
2025-09-16 15:14 ` Jonathan Cameron
2025-09-16 16:00 ` Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 02/25] ACPI: irq: Add IRQ affinity " Marc Zyngier
2025-09-15 10:16 ` Rafael J. Wysocki
2025-09-15 8:56 ` [PATCH v2 03/25] of/irq: " Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 04/25] platform: Add firmware-agnostic irq and affinity retrieval interface Marc Zyngier
2025-09-16 15:23 ` Jonathan Cameron
2025-09-15 8:56 ` [PATCH v2 05/25] irqchip/gic-v3: Add FW info retrieval support Marc Zyngier
2025-09-16 15:34 ` Jonathan Cameron
2025-09-16 15:59 ` Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 06/25] irqchip/apple-aic: " Marc Zyngier
2025-09-15 15:07 ` Sven Peter
2025-09-15 8:56 ` [PATCH v2 07/25] coresight: trbe: Convert to new IRQ affinity retrieval API Marc Zyngier
2025-09-15 9:30 ` Suzuki K Poulose
2025-09-15 8:56 ` [PATCH v2 08/25] perf: arm_pmu: " Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 09/25] perf: arm_spe_pmu: " Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 10/25] irqchip/gic-v3: Switch high priority PPIs over to handle_percpu_devid_irq() Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 11/25] genirq: Kill handle_percpu_devid_fasteoi_nmi() Marc Zyngier
2025-09-16 15:38 ` Jonathan Cameron
2025-09-21 15:32 ` Marc Zyngier [this message]
2025-09-15 8:56 ` [PATCH v2 12/25] genirq: Merge irqaction::{dev_id,percpu_dev_id} Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 13/25] genirq: Factor-in percpu irqaction creation Marc Zyngier
2025-09-16 16:12 ` Jonathan Cameron
2025-09-15 8:56 ` [PATCH v2 14/25] genirq: Add affinity to percpu_devid interrupt requests Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 15/25] genirq: Update request_percpu_nmi() to take an affinity Marc Zyngier
2025-09-16 16:19 ` Jonathan Cameron
2025-09-15 8:56 ` [PATCH v2 16/25] genirq: Allow per-cpu interrupt sharing for non-overlapping affinities Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 17/25] genirq: Add request_percpu_irq_affinity() helper Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 18/25] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 19/25] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 20/25] coresight: trbe: " Marc Zyngier
2025-09-15 9:37 ` Suzuki K Poulose
2025-09-15 8:56 ` [PATCH v2 21/25] irqchip/gic-v3: Drop support for custom PPI partitions Marc Zyngier
2025-09-15 8:56 ` [PATCH v2 22/25] irqchip/apple-aic: Drop support for custom PMU irq partitions Marc Zyngier
2025-09-15 8:57 ` [PATCH v2 23/25] irqchip: Kill irq-partition-percpu Marc Zyngier
2025-09-15 8:57 ` [PATCH v2 24/25] genirq: Kill irq_{g,s}et_percpu_devid_partition() Marc Zyngier
2025-09-15 8:57 ` [PATCH v2 25/25] perf: arm_pmu: Kill last use of per-CPU cpu_armpmu pointer Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6r3yg75.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=james.clark@linaro.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=suzuki.poulose@arm.com \
--cc=sven@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.