Re: [PATCH v2 3/4] rust: core abstractions for HID drivers

[Rahul Rameshbabu <sergeantsagara@protonmail.com>]

On Sun, 13 Jul, 2025 23:57:38 +0200 "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> wrote:
>> +    /// Returns the HID report group.
>> +    pub fn group(&self) -> u16 {
>> +        // SAFETY: `self.as_raw` is a valid pointer to a `struct hid_device`
>> +        unsafe { *self.as_raw() }.group
>> +    }
>
> Do you need to expose the group as a raw integer?
>
> Also, are these used currently?

Hi Miguel,

I originally did not expose the report group in the Rust bindings since
I did not make use of them. Benjamin has a preference access to them be
exposed in the initial bindings. I exposed this before implementing the
enum in a later revision. I agree that we should wrap this using the
enum now.

Thanks,
Rahul Rameshbabu