All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Hindborg <a.hindborg@kernel.org>
To: "FUJITA Tomonori" <fujita.tomonori@gmail.com>
Cc: <alex.gaynor@gmail.com>,  <ojeda@kernel.org>,
	 <aliceryhl@google.com>, <anna-maria@linutronix.de>,
	 <bjorn3_gh@protonmail.com>, <boqun.feng@gmail.com>,
	 <dakr@kernel.org>,  <frederic@kernel.org>, <gary@garyguo.net>,
	 <jstultz@google.com>, <linux-kernel@vger.kernel.org>,
	 <lossin@kernel.org>, <lyude@redhat.com>,
	 <rust-for-linux@vger.kernel.org>, <sboyd@kernel.org>,
	 <tglx@linutronix.de>,  <tmgross@umich.edu>
Subject: Re: [PATCH v1 1/2] rust: time: Rename Delta's methods as_micros_ceil and as_millis
Date: Thu, 19 Jun 2025 11:12:00 +0200	[thread overview]
Message-ID: <87o6uk859b.fsf@kernel.org> (raw)
In-Reply-To: <20250617144155.3903431-2-fujita.tomonori@gmail.com> (FUJITA Tomonori's message of "Tue, 17 Jun 2025 23:41:54 +0900")

Hi Fujita,

"FUJITA Tomonori" <fujita.tomonori@gmail.com> writes:

> Rename the Delta struct's methods as_micros_ceil() and as_millis() to
> into_micros_ceil() and into_millis() respectively, for consistency
> with the naming of other methods.
>
> Fix the commit 2ed94606a0fe ("rust: time: Rename Delta's methods from
> as_* to into_*"), wasn't applied as expected, due to the conflict with
> the commit 1b7bbd597527 ("rust: time: Avoid 64-bit integer division on
> 32-bit architectures").
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>

Sorry for messing up your patch. Since we have no rules against rebasing
rust-timekeeping and the PR is a few weeks down the road, I will just go
back and fix the original patch. Keep commit history clean.

Best regards,
Andreas Hindborg




  parent reply	other threads:[~2025-06-19  9:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 14:41 [PATCH v1 0/2] rust: time: Add fsleep() FUJITA Tomonori
2025-06-17 14:41 ` [PATCH v1 1/2] rust: time: Rename Delta's methods as_micros_ceil and as_millis FUJITA Tomonori
2025-06-18  8:05   ` Alice Ryhl
2025-06-18  9:29     ` Miguel Ojeda
2025-06-18  9:52       ` Alice Ryhl
2025-06-18 11:03         ` Miguel Ojeda
2025-06-18 13:17           ` Alice Ryhl
2025-06-18 15:47             ` Miguel Ojeda
2025-06-19  7:08               ` FUJITA Tomonori
2025-06-19  7:23                 ` Miguel Ojeda
2025-06-19  9:28                   ` Andreas Hindborg
2025-06-19 11:44                     ` Miguel Ojeda
2025-06-19 12:51                       ` Andreas Hindborg
2025-06-19 19:03                         ` Miguel Ojeda
2025-06-24 12:15                 ` Alice Ryhl
2025-06-24 13:49                   ` FUJITA Tomonori
2025-06-24 13:54                     ` Alice Ryhl
2025-06-24 14:14                       ` FUJITA Tomonori
2025-06-24 14:45                         ` Alice Ryhl
2025-06-24 16:39                           ` FUJITA Tomonori
2025-06-19  9:12   ` Andreas Hindborg [this message]
2025-06-19 11:25     ` FUJITA Tomonori
2025-06-17 14:41 ` [PATCH v1 2/2] rust: time: Add wrapper for fsleep() function FUJITA Tomonori
2025-06-30 12:07   ` Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6uk859b.fsf@kernel.org \
    --to=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=anna-maria@linutronix.de \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=frederic@kernel.org \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.