From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AF328467 for ; Tue, 22 Apr 2025 21:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745356785; cv=none; b=NheT/DVyAa5Mle+ln16pncqjljejvMj1xoe8XHRDIf6eHba9kDOaHeB6x12d3orLJJhRLHMey1aBUJBD7XMsCZpwoBjkC7i9SgL8ZwiMF0qaEcHMxuzvN2CtO3kwnmNEQaM/im9hD5yAuu2BK8QsopokhQJ1bzdKfXC3Fu8Gyvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745356785; c=relaxed/simple; bh=AeYw6rL1CJRFcnx2f29yVZ0cLCF3+3DhfJ5qUM0giNg=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=mgqTNpVrJDAE2imsWajknZQoYdLo8udVkE+4xbjFRf+KaM2PCZ7SZ4fZzDV8cfxS9h7z8cJJHKzo9rVfOfv8z1zLvG6/d60nJHZi8BCv8tDCkMgHpStP3+USKlyXbPnj1fJpoy5YPxiQ0DngthIdwDcfBvA0sRZ0ENtZrmL9yDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TzxMRdSL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TzxMRdSL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B67ABC4CEE9; Tue, 22 Apr 2025 21:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745356782; bh=AeYw6rL1CJRFcnx2f29yVZ0cLCF3+3DhfJ5qUM0giNg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TzxMRdSLfuMubi7I8I9iHCx8D1lTR9Oxf8mPE/zZSYP8rycKMKVj74905WXVxRq5H +DAEEvqVX1Q2UIeQ9afLo2pZuG60EYPdcjbUeKGrVo+A4aGITPR4tNbMyl/2RV72Cx tgmu97uK34cJKDv33/PsvoO3CH6q2s+ckiqVaSQEC6UOdfQBC937JcEcP9ceWl7/dk /DazA+5OJ0/WGL1YNgWPxeljUS/sj5TpupXqVttSP65TJ3eYYRPfTG82dr6Sf9mAKK y3co5RjbAltTvyiVtB6xyP2NFmaHNwdTiRwvjd1hCcibb/k8OCXtU6SXF+Ba8nVBxY Sy4aVYBM96paA== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1u7L1o-007mKs-Dl; Tue, 22 Apr 2025 22:19:40 +0100 Date: Tue, 22 Apr 2025 22:19:48 +0100 Message-ID: <87o6wnyjuz.wl-maz@kernel.org> From: Marc Zyngier To: D Scott Phillips Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH 2/3] KVM: arm64: Teach address translation about access faults In-Reply-To: <86frhzyl19.fsf@scott-ph-mail.amperecomputing.com> References: <20250422122612.2675672-1-maz@kernel.org> <20250422122612.2675672-3-maz@kernel.org> <86frhzyl19.fsf@scott-ph-mail.amperecomputing.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: scott@os.amperecomputing.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 22 Apr 2025 21:54:26 +0100, D Scott Phillips wrote: > > Marc Zyngier writes: > > > It appears that our S1 PTW is completely oblivious of access faults. > > Teach the S1 translation code about it. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kvm/at.c | 26 +++++++++++++++++++++----- > > 1 file changed, 21 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c > > index 3a4568e2de910..c40583edebc4f 100644 > > --- a/arch/arm64/kvm/at.c > > +++ b/arch/arm64/kvm/at.c > > @@ -456,6 +456,11 @@ static int walk_s1(struct kvm_vcpu *vcpu, struct s1_walk_info *wi, > > if (check_output_size(desc & GENMASK(47, va_bottom), wi)) > > goto addrsz; > > > > + if (!(desc & PTE_AF)) { > > Shouldn't this depend on TCR_ELx.HA == 0? Which is so far the only supported configuration for a guest under NV. M. -- Jazz isn't dead. It just smells funny.