From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CA81C369A5 for ; Tue, 8 Apr 2025 13:51:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8709310E6B1; Tue, 8 Apr 2025 13:51:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="nndeeJUK"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E60510E6B1 for ; Tue, 8 Apr 2025 13:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744120294; x=1775656294; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=FRyVqyIGDDWPX66ccDPKXCI5hV4OAn9aT1p3wZZXQEM=; b=nndeeJUKT2XaEmxQ12CCJC/g4edewUKAUBUi0wCi7vUk07X1fAa0pjmB kCBfCrb8Fn7+vbi4wO3trkr1xqV78ljudL/PQJFi+iMIsPOUsXlAFA5OF xuFuwibxtj9oP/4J+3eji8IiMGEe4O14EpLmx+QJ3HozN5lSdi93iW9rH SVu+Xg/sXZK8dXDE6fAp1nP1omzkBl3s01bygBARKJeeafNgzwQ/dhvPE c0NMICfORogXhkUkL8wBmL1fb1yd2Sv2R4lRX/GPExZB5Xh1MKK22AsSh mjwYbc7cU2drS3+mPStT9feu2IjgEXeOZK2jcG+yXwBBWRtGvuFNOskuY A==; X-CSE-ConnectionGUID: 7yRiH+C2T8CVYzOF7RAeyw== X-CSE-MsgGUID: CcSi4A8tSCmQhxjzj2ZPZQ== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="49398264" X-IronPort-AV: E=Sophos;i="6.15,198,1739865600"; d="scan'208";a="49398264" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2025 06:51:34 -0700 X-CSE-ConnectionGUID: LUP5wNbDRZ6oDLkXV+3D9Q== X-CSE-MsgGUID: LJrp2DPkTDa9WtrX1v+ONQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,198,1739865600"; d="scan'208";a="159268858" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.137]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2025 06:51:28 -0700 From: Jani Nikula To: "Borah, Chaitanya Kumar" , Maxime Ripard Cc: "Dixit, Ashutosh" , Anusha Srivatsa , "Deak, Imre" , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Linus Walleij , Joel Selvaraj , Douglas Anderson , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 04/10] panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc() In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250401-b4-drm-panel-mass-driver-convert-v1-0-cdd7615e1f93@redhat.com> <20250401-b4-drm-panel-mass-driver-convert-v1-4-cdd7615e1f93@redhat.com> <85a58rsgjj.wl-ashutosh.dixit@intel.com> <87bjt7eca8.wl-ashutosh.dixit@intel.com> <87a58re8hj.wl-ashutosh.dixit@intel.com> <854iyzs3na.wl-ashutosh.dixit@intel.com> <20250408-industrious-impetuous-wombat-f6d7dc@houat> Date: Tue, 08 Apr 2025 16:51:25 +0300 Message-ID: <87o6x6yd5u.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 08 Apr 2025, "Borah, Chaitanya Kumar" wrote: >> > We will need more changes than fixing the variable names. >> > >> > I get this error >> > >> > ERROR: modpost: "__devm_drm_panel_alloc" >> [drivers/gpu/drm/panel/panel-auo-a030jtn01.ko] undefined! >> > make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1 >> > make[1]: *** >> > [/home/chaitanya/exodus/repos/drm-tip-sandbox/Makefile:1956: >> modpost] >> > Error 2 >> > make: *** [Makefile:248: __sub-make] Error 2 >> > >> > after making the following change. >> >> I couldn't reproduce this one on current drm-misc-next with arm64 and >> x86 allmodconfig. Could you share your configuration? >> > > Here is the config that our CI uses > > https://gitlab.freedesktop.org/drm/xe/ci/-/raw/main/kernel/kconfig There's CONFIG_DRM_PANEL=y # CONFIG_OF is not set but __devm_drm_panel_alloc is inside #ifdef CONFIG_OF. I don't know that it should be. There are some stubs in drm_panel.h for !CONFIG_OF but not this one. Finally, DRM_PANEL_AUO_A030JTN01 does not depend on OF. That's the issue, but I don't know what the correct fix would be. BR, Jani. -- Jani Nikula, Intel