From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0DCDC35FFA for ; Wed, 19 Mar 2025 19:22:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tuyyw-0007HP-8M; Wed, 19 Mar 2025 15:21:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuyyr-0007Gq-Cj for qemu-devel@nongnu.org; Wed, 19 Mar 2025 15:21:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuyyp-0001wv-Gu for qemu-devel@nongnu.org; Wed, 19 Mar 2025 15:21:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742412089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=249/I9TU+Yl7unttFDPSJVJqH1Jh4paTLBHB4XCNXnA=; b=azo37yJj90nddhYm529fh9UfrUIgi9wnS8hRdWx8uYm3/3vbiP0WPwaKnMY7g5jVvYwHX+ kq5+6Yik6OkAgJcSnLY1u/GD5Ykebe8HpKJPwom7WuOSnYO1fX6ZzHQ7e+AQR37Uk8n0Oc urvLLYHDATzrzwpM8Vc9KEfw56mXlPw= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-fCGnmzMiMVW10hiyM7xsyw-1; Wed, 19 Mar 2025 15:21:27 -0400 X-MC-Unique: fCGnmzMiMVW10hiyM7xsyw-1 X-Mimecast-MFC-AGG-ID: fCGnmzMiMVW10hiyM7xsyw_1742412085 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4217318009B1; Wed, 19 Mar 2025 19:21:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.22.74.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99DD63001D0E; Wed, 19 Mar 2025 19:21:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id AC00021E675E; Wed, 19 Mar 2025 20:21:20 +0100 (CET) From: Markus Armbruster To: Corey Minyard Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 3/3] cleanup: Drop pointless label at end of function In-Reply-To: (Corey Minyard's message of "Wed, 19 Mar 2025 13:59:09 -0500") References: <20250319152126.3472290-1-armbru@redhat.com> <20250319152126.3472290-4-armbru@redhat.com> Date: Wed, 19 Mar 2025 20:21:20 +0100 Message-ID: <87o6xwkerz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.337, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Corey Minyard writes: > Is this official coding style? I'm not a big fan of having return > statements in the middle of functions, I generally only put them at > the beginning or the end. There's nothing in docs/devel/style.rst. I count more than 42,000 return statements with indentation > 4. These are either within some block, or incorrectly indented. I'd bet my own money that it's the former for pretty much all of them. I count less than 130 labels right before a return statement at end of a function. Based on that, I'd say return in the middle of function is overwhelmingly common in our code.