From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 2/3] package/android-tools: fix build issue on mips64 and powerpc64
Date: Fri, 06 Dec 2024 23:44:40 +0100 [thread overview]
Message-ID: <87o71o4ejr.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20241204204806.159596-3-thomas.petazzoni@bootlin.com> (Thomas Petazzoni via buildroot's message of "Wed, 4 Dec 2024 21:48:01 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> The kernel headers on mips64 and powerpc64 were historically "broken",
> defining u64 as an "unsigned long" instead of "unsigned long
> long". This has been fixed in the upstream Linux kernel by introducing
> the __SANE_USERSPACE_TYPES__ definition.
> Our commit a2e178d6b45dfc5b8d1d50fcbbfc0bec5ebf1ae2 ("android-tools:
> disable on some architecture with old kernel headers") already
> disabled building fastboot on powerpc64 and mips64 systems that have
> too old kernel headers. However, it turns out that even with the new
> kernel headers, there are build issues because
> __SANE_USERSPACE_TYPES__ isn't defined everywhere it should be in the
> android-tools code base. The Debian patche
> debian/patches/ppc64el-ftbfs.patch adds some definitions, but it's
> missing one file, and in another the definition comes too late.
> This commit adds an extra patch that fixes this up, and makes fastboot
> build properly on mips64 and powerpc64.
> Fixes:
> http://autobuild.buildroot.net/results/8528ff876e695f79bdfe64f5330d9d51eeef66cb/ (powerpc64)
> http://autobuild.buildroot.net/results/36ac6af73b618c28d1636093da333f7ebd9d6cfe/ (mips64)
> This issue has been occurring as far as Feb 2021, with the first
> occurence apparently being:
> http://autobuild.buildroot.net/results/d9521b4bfeafb1140c21745dbfe28d476a9b71ec/
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2024.02.x and 2024.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-12-06 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 20:47 [Buildroot] [PATCH 0/3] Fix two android-tools build issues Thomas Petazzoni via buildroot
2024-12-04 20:48 ` [Buildroot] [PATCH 1/3] package/android-tools: convert all patches to Git-formatted patches Thomas Petazzoni via buildroot
2024-12-06 22:44 ` Peter Korsgaard
2024-12-04 20:48 ` [Buildroot] [PATCH 2/3] package/android-tools: fix build issue on mips64 and powerpc64 Thomas Petazzoni via buildroot
2024-12-06 22:44 ` Peter Korsgaard [this message]
2024-12-04 20:48 ` [Buildroot] [PATCH 3/3] package/android-tools: fix b64_pton() issue with GCC >= 14.x Thomas Petazzoni
2024-12-06 22:44 ` Peter Korsgaard
2024-12-04 21:48 ` [Buildroot] [PATCH 0/3] Fix two android-tools build issues Arnout Vandecappelle via buildroot
2024-12-04 21:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o71o4ejr.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.