Re: [PATCH v2 2/4] xen: common: add ability to enable stack protector

[Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>]

Hi Andrew,

I addressed almost all your comments, but didn't get this one:

Andrew Cooper <andrew.cooper3@citrix.com> writes:

> On 30/11/2024 1:10 am, Volodymyr Babchuk wrote:

[...]


>> diff --git a/xen/common/stack-protector.c b/xen/common/stack-protector.c
>> new file mode 100644
>> index 0000000000..b258590d3a
>> --- /dev/null
>> +++ b/xen/common/stack-protector.c
>> @@ -0,0 +1,10 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +#include <xen/lib.h>
>> +#include <xen/random.h>
>> +
>> +unsigned long __ro_after_init __stack_chk_guard;
>> +
>> +void __stack_chk_fail(void)
>
> asmlinkage.  This MISRA check is now blocking in Eclair.

I can see what we might want to mark it as "noreturn", but I don't
understand why you want to use asmlinkage. It is not called from
assembly.


-- 
WBR, Volodymyr