All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maciej Andrzejewski <maciej.andrzejewski@m-works.net>
Cc: Michal Simek <michal.simek@amd.com>,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	 Punnaiah Choudary Kalluri <punnaia@xilinx.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: rawnand: arasan: Fix missing de-registration of NAND chip-selects
Date: Mon, 02 Dec 2024 14:46:14 +0100	[thread overview]
Message-ID: <87o71u6vvd.fsf@bootlin.com> (raw)
In-Reply-To: <Z021Z-cFOJ-Vw3ud@UBUNTU-PF54DSY0> (Maciej Andrzejewski's message of "Mon, 2 Dec 2024 14:25:59 +0100")

Hi Maciej,

On 02/12/2024 at 14:25:59 +01, Maciej Andrzejewski <maciej.andrzejewski@m-works.net> wrote:

> The NAND chip-selects are registered for the Arasan driver during
> initialization but are not de-registered when the driver is unloaded. As a
> result, if the driver is loaded again, the chip-selects remain registered
> and busy, making them unavailable for use.

Good point!

> Fixes: 197b88fecc50ee3c7a22415db81eae0b9126f20e ("mtd: rawnand: arasan: Add new Arasan NAND controller")

This should be a 12-digit sha only. FYI in my .gitconfig I have the
following alias:

     fixes = show -s --format='Fixes: %h (\"%s\")'

It was correct in your previous patch :)

> Cc: stable@vger.kernel.org
> Signed-off-by: Maciej Andrzejewski ICEYE <maciej.andrzejewski@m-works.net>

Otherwise looks good to me!

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2024-12-02 13:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 13:25 [PATCH] mtd: rawnand: arasan: Fix missing de-registration of NAND chip-selects Maciej Andrzejewski
2024-12-02 13:46 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o71u6vvd.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maciej.andrzejewski@m-works.net \
    --cc=michal.simek@amd.com \
    --cc=punnaia@xilinx.com \
    --cc=ruanjinjie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.