Re: No sound on speakers X1 Carbon Gen 12

[Takashi Iwai <tiwai@suse.de>]

On Mon, 21 Oct 2024 09:56:32 +0200,
Kailang wrote:
> 
> 
> 
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Monday, October 21, 2024 2:59 PM
> > To: Dean Matthew Menezes <dean.menezes@utexas.edu>
> > Cc: Takashi Iwai <tiwai@suse.de>; Kailang <kailang@realtek.com>;
> > stable@vger.kernel.org; regressions@lists.linux.dev; Jaroslav Kysela
> > <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Linux Sound System
> > <linux-sound@vger.kernel.org>; Greg KH <gregkh@linuxfoundation.org>
> > Subject: Re: No sound on speakers X1 Carbon Gen 12
> > 
> > 
> > External mail.
> > 
> > 
> > 
> > On Mon, 21 Oct 2024 03:30:13 +0200,
> > Dean Matthew Menezes wrote:
> > >
> > > I can confirm that the original fix does not bring back the speaker
> > > output.  I have attached both outputs for alsa-info.sh
> > 
> > Thanks!  This confirms that the only significant difference is the COEF data
> > between working and patched-non-working cases.
> > 
> > Kailang, I guess this model (X1 Carbon Gen 12) isn't with ALC1318, hence your
> > quirk rather influences badly.  Or may the GPIO3 workaround have the similar
> > effect?
> 
> No, I check with our AE. It's ALC1318 include.
> And This fixed was testing with Lenovo.
> 
> > 
> > As of now, the possible fix is to simply remove the quirk entries for ALC1318.
> > But I'd need to know which model was targeted for your original fix in commit
> > 1e707769df07 and whether the regressed model is with ALC1318.
> 
> +	SND_PCI_QUIRK(0x17aa, 0x231e, "Thinkpad", ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318),
> +	SND_PCI_QUIRK(0x17aa, 0x231f, "Thinkpad", ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318),
> 
> Yes, this model include ALC1318.

Thanks for confirmation.  So, from the Realtek side, the current code
looks correct.

Dean, is the BIOS firmware up-to-date on your device?  Just to be
sure.


Takashi