From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
andrew@lunn.ch, sebastian.hesselbarth@gmail.com
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: [PATCH] ARM: dts: marvell: Add 7-segment LED display on x530
Date: Fri, 05 Jul 2024 14:37:58 +0200 [thread overview]
Message-ID: <87o77cj9p5.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20240530231608.3557782-1-chris.packham@alliedtelesis.co.nz>
Chris Packham <chris.packham@alliedtelesis.co.nz> writes:
> The Allied Telesis x530 products have a 7-segment LED display which is
> used for node identification when the devices are stacked. Represent
> this as a gpio-7-segment device.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> This was originally sent as part of the series that added the seg-led-gpio
> driver but wasn't applied with those changes. At the time I said I'd submit
> this separately but I forgot about it until now.
>
> arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> index 5a9ab8410b7b..2fb7304039be 100644
> --- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> +++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> @@ -43,6 +43,17 @@ uart0: serial@12000 {
> };
> };
> };
> +
> + led-7seg {
> + compatible = "gpio-7-segment";
> + segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 1 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 2 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 3 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 4 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 5 GPIO_ACTIVE_LOW>,
> + <&led_7seg_gpio 6 GPIO_ACTIVE_LOW>;
> + };
> };
>
> &pciec {
> @@ -149,7 +160,7 @@ i2c@3 {
> #size-cells = <0>;
> reg = <3>;
>
> - gpio@20 {
> + led_7seg_gpio: gpio@20 {
> compatible = "nxp,pca9554";
> gpio-controller;
> #gpio-cells = <2>;
> --
> 2.45.1
prev parent reply other threads:[~2024-07-05 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 23:16 [PATCH] ARM: dts: marvell: Add 7-segment LED display on x530 Chris Packham
2024-05-30 23:16 ` Chris Packham
2024-07-05 12:37 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o77cj9p5.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.