From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A5F3C2BD09 for ; Wed, 3 Jul 2024 16:49:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D75510E912; Wed, 3 Jul 2024 16:49:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UfY3ifiC"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A02F10E8FC for ; Wed, 3 Jul 2024 16:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720025382; x=1751561382; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=jBWOU+4xbexkygltMzadBEt6NMEnAPuHH/U5zOnNA1E=; b=UfY3ifiCwncCGJmdkCG08LcPSBkR4nTtGEnLh2UevXgjDyAW4Md56E9t 4AYMa56jumuwVKZNMtz7DkFBGHJapTc3khzAMmRG4Zk9wVHeBcigFhptd Xd1AtlWL04TGsuVpLfK7DYnwag/dm1ysVnJbQm8PM0fZT2CPttMbOTHDM LtSR4SKMr5TIay8T0JvIqIC18TGyTQQqd+PDj8H8UWqlK+Ui1iM4IIZvk OniWEINrG7KkY11C6OHiswNJ6PpR2imQXXYwKnTyJqyXdMzp5z0SwGka5 yLBf/JxyUqPbLATg4+IPk8bcU/PaaMWmhhWRSn6lAo0lMqYmiL7gHU/7t w==; X-CSE-ConnectionGUID: 7Uqk6ZRVTBeLwrXqWw+bWw== X-CSE-MsgGUID: CHEDOZlrRfauB/reovb+7w== X-IronPort-AV: E=McAfee;i="6700,10204,11122"; a="17105574" X-IronPort-AV: E=Sophos;i="6.09,182,1716274800"; d="scan'208";a="17105574" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2024 09:49:42 -0700 X-CSE-ConnectionGUID: P6WCdlovT92tlfKfXerjKg== X-CSE-MsgGUID: l6813k/9QZ6Dxjxx4MhLJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,182,1716274800"; d="scan'208";a="46740739" Received: from rtatoosk-mobl2.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.129.72]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2024 09:49:42 -0700 Date: Wed, 03 Jul 2024 09:41:42 -0700 Message-ID: <87o77ea0mx.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Souza, Jose" Cc: "intel-xe@lists.freedesktop.org" Subject: Re: [PATCH] drm/xe/uapi: Rename xe perf layer as xe observation layer In-Reply-To: <87plrua0vf.wl-ashutosh.dixit@intel.com> References: <20240702214034.2507446-1-ashutosh.dixit@intel.com> <405ecbace1f12fe2d70257da79764fd83d604b7e.camel@intel.com> <87r0caa2zi.wl-ashutosh.dixit@intel.com> <87plrua0vf.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 03 Jul 2024 09:36:36 -0700, Dixit, Ashutosh wrote: > > On Wed, 03 Jul 2024 09:12:45 -0700, Souza, Jose wrote: > > > > On Wed, 2024-07-03 at 08:50 -0700, Dixit, Ashutosh wrote: > > > On Wed, 03 Jul 2024 08:52:54 -0700, Souza, Jose wrote: > > > > > > > > > +static struct ctl_table observation_ctl_table[] = { > > > > > + { > > > > > + .procname = "xe_observation_paranoid", > > > > > > > > This will lead to /proc/sys/dev/xe/xe_observation_paranoid, is this the intention? > > > > Before it was /proc/sys/dev/xe/perf_stream_paranoid > > > > > > Yes, basically the "perf" name is purged and replaced by "observation" (or > > > "open a perf stream" is now replaced by "open an observation stream"). > > > > My main issue is with the "xe/xe_" why duplicate it? > > OK, fair point, I will drop the xe_ so it will be > /proc/sys/dev/xe/observation_paranoid. Changed in https://patchwork.freedesktop.org/patch/602182/?series=135667&rev=5 Thanks. -- Ashutosh