[PATCH v1] drm/i915/dp: Modify DP lane count from DPCD reading

[PATCH v1] drm/i915/dp: Modify DP lane count from DPCD reading

[Ben Kao]

We found that the external monitor would be failed to display
when hot-plug with dual Type-C USB cable on Dell WD19DC dock.
Due to the host would receive 2 lanes setting when the first HPD,
then receive 4 lanes setting later, but the host only sets 2 lanes
DP and skips to set 4 lanes DP. I modify DP lane count if the
current DP lane count is not the same as DPCD reading.

Signed-off-by: Ben Kao <ben.kao@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5b3b6ae1e3d7..a9b9023c6744 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5545,6 +5545,12 @@ intel_dp_detect_dpcd(struct intel_dp *intel_dp)
 	if (!intel_dp_get_dpcd(intel_dp))
 		return connector_status_disconnected;
 
+	/* lanes count changed */
+	if (intel_dp->lane_count != drm_dp_max_lane_count(intel_dp->dpcd)) {
+		intel_dp->lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
+		return connector_status_disconnected;
+	}
+
 	intel_dp->mst_detect = intel_dp_mst_detect(intel_dp);
 
 	/* if there's no downstream port, we're done */
-- 
2.17.1

Re: [PATCH v1] drm/i915/dp: Modify DP lane count from DPCD reading

[Jani Nikula]

On Fri, 28 Jun 2024, Ben Kao <ben.kao@intel.com> wrote:
> We found that the external monitor would be failed to display
> when hot-plug with dual Type-C USB cable on Dell WD19DC dock.
> Due to the host would receive 2 lanes setting when the first HPD,
> then receive 4 lanes setting later, but the host only sets 2 lanes
> DP and skips to set 4 lanes DP. I modify DP lane count if the
> current DP lane count is not the same as DPCD reading.
>
> Signed-off-by: Ben Kao <ben.kao@intel.com>

Please file a bug according to [1].

BR,
Jani.

[1] https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html


> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 5b3b6ae1e3d7..a9b9023c6744 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5545,6 +5545,12 @@ intel_dp_detect_dpcd(struct intel_dp *intel_dp)
>  	if (!intel_dp_get_dpcd(intel_dp))
>  		return connector_status_disconnected;
>  
> +	/* lanes count changed */
> +	if (intel_dp->lane_count != drm_dp_max_lane_count(intel_dp->dpcd)) {
> +		intel_dp->lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
> +		return connector_status_disconnected;
> +	}
> +
>  	intel_dp->mst_detect = intel_dp_mst_detect(intel_dp);
>  
>  	/* if there's no downstream port, we're done */

-- 
Jani Nikula, Intel

RE: [PATCH v1] drm/i915/dp: Modify DP lane count from DPCD reading

[Kao, Ben]

> On Fri, 28 Jun 2024, Ben Kao <ben.kao@intel.com> wrote:
> > We found that the external monitor would be failed to display when
> > hot-plug with dual Type-C USB cable on Dell WD19DC dock.
> > Due to the host would receive 2 lanes setting when the first HPD, then
> > receive 4 lanes setting later, but the host only sets 2 lanes DP and
> > skips to set 4 lanes DP. I modify DP lane count if the current DP lane
> > count is not the same as DPCD reading.
> >
> > Signed-off-by: Ben Kao <ben.kao@intel.com>
> 
> Please file a bug according to [1].
> 
> BR,
> Jani.
> 
> [1] https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html
This patch is for the bug number 11195
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11195

> 
> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 5b3b6ae1e3d7..a9b9023c6744 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -5545,6 +5545,12 @@ intel_dp_detect_dpcd(struct intel_dp *intel_dp)
> >  	if (!intel_dp_get_dpcd(intel_dp))
> >  		return connector_status_disconnected;
> >
> > +	/* lanes count changed */
> > +	if (intel_dp->lane_count != drm_dp_max_lane_count(intel_dp->dpcd)) {
> > +		intel_dp->lane_count = drm_dp_max_lane_count(intel_dp-
> >dpcd);
> > +		return connector_status_disconnected;
> > +	}
> > +
> >  	intel_dp->mst_detect = intel_dp_mst_detect(intel_dp);
> >
> >  	/* if there's no downstream port, we're done */
> 
> --
> Jani Nikula, Intel

✗ Fi.CI.BAT: failure for drm/i915/dp: Modify DP lane count from DPCD reading

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5795 bytes --]

== Series Details ==

Series: drm/i915/dp: Modify DP lane count from DPCD reading
URL   : https://patchwork.freedesktop.org/series/135505/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15013 -> Patchwork_135505v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_135505v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_135505v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/index.html

Participating hosts (42 -> 40)
------------------------------

  Missing    (2): bat-dg2-11 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_135505v1:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_addfb_basic@bad-pitch-999:
    - fi-kbl-7567u:       [PASS][1] -> [DMESG-WARN][2] +1 other test dmesg-warn
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@kms_addfb_basic@bad-pitch-999.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@kms_addfb_basic@bad-pitch-999.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
    - fi-kbl-7567u:       [PASS][3] -> [DMESG-FAIL][4] +2 other tests dmesg-fail
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-kbl-7567u:       [PASS][5] -> [FAIL][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@kms_frontbuffer_tracking@basic.html

  
Known issues
------------

  Here are the changes found in Patchwork_135505v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload:
    - fi-kbl-7567u:       [PASS][7] -> [DMESG-WARN][8] ([i915#10062] / [i915#180] / [i915#1982] / [i915#9925]) +1 other test dmesg-warn
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@i915_module_load@reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@i915_module_load@reload.html

  * igt@i915_selftest@live@guc_multi_lrc:
    - bat-arls-1:         [PASS][9] -> [DMESG-FAIL][10] ([i915#10262]) +3 other tests dmesg-fail
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-arls-1/igt@i915_selftest@live@guc_multi_lrc.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/bat-arls-1/igt@i915_selftest@live@guc_multi_lrc.html

  * igt@i915_selftest@live@sanitycheck:
    - fi-kbl-7567u:       [PASS][11] -> [DMESG-WARN][12] ([i915#11328]) +39 other tests dmesg-warn
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html

  * igt@i915_selftest@live@slpc:
    - bat-arls-1:         [PASS][13] -> [DMESG-WARN][14] ([i915#10341])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-arls-1/igt@i915_selftest@live@slpc.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/bat-arls-1/igt@i915_selftest@live@slpc.html

  * igt@kms_busy@basic@flip:
    - fi-kbl-7567u:       [PASS][15] -> [DMESG-WARN][16] ([i915#180])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@kms_busy@basic@flip.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@kms_busy@basic@flip.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-7567u:       NOTRUN -> [SKIP][17] +1 other test skip
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@kms_flip@basic-flip-vs-modeset.html

  * igt@kms_pm_rpm@basic-pci-d3-state:
    - fi-kbl-7567u:       [PASS][18] -> [DMESG-WARN][19] ([i915#10062] / [i915#180] / [i915#9925]) +61 other tests dmesg-warn
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html

  
  [i915#10062]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10062
  [i915#10262]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10262
  [i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
  [i915#11328]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11328
  [i915#180]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/180
  [i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
  [i915#9925]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9925


Build changes
-------------

  * Linux: CI_DRM_15013 -> Patchwork_135505v1

  CI-20190529: 20190529
  CI_DRM_15013: 0318a12ff6fb8c321458aa2b373e9322896ee951 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7906: ae91ba26f657bf11264f64bd2dc21f471a5d18f5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_135505v1: 0318a12ff6fb8c321458aa2b373e9322896ee951 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_135505v1/index.html

[-- Attachment #2: Type: text/html, Size: 6945 bytes --]