All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Quentin Schulz <quentin.schulz@cherry.de>,
	Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Cc: Mario Six <mario.six@gdsys.cc>, u-boot@lists.denx.de
Subject: Re: [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)
Date: Wed, 05 Jun 2024 10:11:28 +0200	[thread overview]
Message-ID: <87o78fizbj.fsf@baylibre.com> (raw)
In-Reply-To: <09afc533-681d-41ce-aa3e-5cbcb0469b21@cherry.de>

Hi Quentin,

Thank you for the review.

On mar., juin 04, 2024 at 17:25, Quentin Schulz <quentin.schulz@cherry.de> wrote:

> Hi Mattijs,
>
> On 6/4/24 5:15 PM, Mattijs Korpershoek wrote:
>> According to [1], we should use bootmeth when describing the
>> struct bootmeth:
>> 
>> """
>> For version 2, a new naming scheme is used as above:
>> 
>>      - bootdev is used instead of bootdevice, because 'device' is overused,
>>          is everywhere in U-Boot, can be confused with udevice
>>      - bootmeth - because 'method' is too vanilla, appears 1300 times in
>>          U-Boot
>> """
>> 
>> Replace all occurences in various comments for consistency.
>> 
>
> s/occurences/occurrences/

Urgh, I guess I spot typos from others but not my own ones :/

>
> Sorry, was too tempting to highlight a typo in a commit that fixes typos :)
>
> (Don't send a v3 for this please :) )

I won't. I hope the person applying this patch can do a fixup.

>
>> [1] https://lore.kernel.org/u-boot/20211023232635.9195-1-sjg@chromium.org/
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Thanks!
> Quentin

  reply	other threads:[~2024-06-05  8:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 15:15 [PATCH v2 0/2] bootstd: Fix a handful of doc typos in bootmeth Mattijs Korpershoek
2024-06-04 15:15 ` [PATCH v2 1/2] " Mattijs Korpershoek
2024-06-05 11:17   ` Guillaume LA ROQUE
2024-06-10  9:46   ` Julien Masson
2024-06-04 15:15 ` [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s) Mattijs Korpershoek
2024-06-04 15:25   ` Quentin Schulz
2024-06-05  8:11     ` Mattijs Korpershoek [this message]
2024-06-16  7:38   ` Heinrich Schuchardt
2024-06-17  6:31     ` Mattijs Korpershoek
2024-06-17  9:00       ` Quentin Schulz
2024-06-17  9:24         ` Heinrich Schuchardt
2024-06-17  9:44           ` Quentin Schulz
2024-06-17 13:53     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o78fizbj.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=mario.six@gdsys.cc \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.