From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DFFCC5475B for ; Mon, 11 Mar 2024 18:44:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjkdG-0007cO-7R; Mon, 11 Mar 2024 14:44:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjkdE-0007c6-MQ for qemu-devel@nongnu.org; Mon, 11 Mar 2024 14:44:16 -0400 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjkdD-0003RR-5S for qemu-devel@nongnu.org; Mon, 11 Mar 2024 14:44:16 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7D6845CA4A; Mon, 11 Mar 2024 18:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710182653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QSmHWcJQsMgD78VcJ165p7kZKIO2Q+T3NIa+geM7v7Q=; b=RzeJwPvQYoAqBWASk985bQeTFhtOyH8HIJy5KiboXwYNcb56YTYteRYK2IKjyWtMNwxOoy jlQmGVBb1dtRsZ4L90VGa/657iObwUyqngeFIXOfAQ1FbP/4ksqnywEX0fSaj4qOb61m81 XJWC0yKByfdrfZS3wbEC4OGC49u9hMg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710182653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QSmHWcJQsMgD78VcJ165p7kZKIO2Q+T3NIa+geM7v7Q=; b=qOLi4DLcHV133c7fGlDkFmRxO0ZPjtrIo3Cnt5gUaTm0fXhACZz1WwwXnw2Zg0Jb5S1Tm3 NbP/4EKXTCbXDyDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710182652; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QSmHWcJQsMgD78VcJ165p7kZKIO2Q+T3NIa+geM7v7Q=; b=SdQ2bxjWbnqWFHC883OiOFtFXIUJxJ1bCHgmhahOl8jJbAzDDqFWlJ+ijp+SPbKXUgFaav 7Aq6KEPWbKSr35ko0ctdWiwyYOGeNvvSFwrL0uKypS+olYzsdc4bAkA/NMypqm25uIM5r1 9yx6fUpCXnzzWxTk8xkMQFWYSZQvUhE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710182652; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QSmHWcJQsMgD78VcJ165p7kZKIO2Q+T3NIa+geM7v7Q=; b=Y1FLUKXa3R/qakrZMlKRvn5xDIJndhZuLyjx33AVVzFz54nVMS8Orpuh5WCuYEEBJ2HOV9 XLfyETr9ExNLsWDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 05DFF13695; Mon, 11 Mar 2024 18:44:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NERLLvtQ72UdQQAAD6G6ig (envelope-from ); Mon, 11 Mar 2024 18:44:11 +0000 From: Fabiano Rosas To: Het Gala , qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com, Het Gala Subject: Re: [PATCH v4 6/8] Add channels parameter in migrate_qmp In-Reply-To: <20240308205951.111747-7-het.gala@nutanix.com> References: <20240308205951.111747-1-het.gala@nutanix.com> <20240308205951.111747-7-het.gala@nutanix.com> Date: Mon, 11 Mar 2024 15:44:09 -0300 Message-ID: <87o7bkmww6.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-4.07 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.13)[-0.658]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.84)[99.31%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[nutanix.com:email,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Het Gala writes: > Alter migrate_qmp() to allow use of channels parameter, but only > fill the uri with correct port number if there are no channels. > Here we don't want to allow the wrong cases of having both or > none (ex: migrate_qmp_fail). > > Signed-off-by: Het Gala > Suggested-by: Fabiano Rosas Reviewed-by: Fabiano Rosas