From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EBB0C5478C for ; Tue, 27 Feb 2024 17:01:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf0pD-0001LZ-7Y; Tue, 27 Feb 2024 12:01:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf0ou-0001Dx-Br for qemu-riscv@nongnu.org; Tue, 27 Feb 2024 12:00:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf0os-0005kH-JK for qemu-riscv@nongnu.org; Tue, 27 Feb 2024 12:00:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709053241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Dc5uEDKmUP6lkgd5F+ELxhywGff4XDS5bKezLevdlDc=; b=KXsNtTd4MJ1jfYksbD0uTOhhYLZ3iCj8bb6ZINpPfria8LngX14R6TPR7IUJTrizt9J2gL e6x1CE6vuQmGi4iraWW7NozVlJVgrJCNFxfTzPKb2+xNV6WlsKVBmwYjqp+8X9SivWjWZ+ SYVDNnU5iNvuyWaonxcwrXPggKcMIkU= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-7O-1_E-rPlmSEC-NF5eE8w-1; Tue, 27 Feb 2024 12:00:38 -0500 X-MC-Unique: 7O-1_E-rPlmSEC-NF5eE8w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D590329ABA11; Tue, 27 Feb 2024 17:00:34 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04FBFC185C4; Tue, 27 Feb 2024 17:00:34 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C514C21E66D0; Tue, 27 Feb 2024 18:00:32 +0100 (CET) From: Markus Armbruster To: Igor Mammedov Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, mst@redhat.com, gaosong@loongson.cn, alistair.francis@wdc.com, palmer@dabbelt.com, bin.meng@windriver.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, anisinha@redhat.com, philmd@linaro.org, wangyanan55@huawei.com, eblake@redhat.com, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, f.ebner@proxmox.com Subject: Re: [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' value In-Reply-To: <20240227154749.1818189-14-imammedo@redhat.com> (Igor Mammedov's message of "Tue, 27 Feb 2024 16:47:43 +0100") References: <20240227154749.1818189-1-imammedo@redhat.com> <20240227154749.1818189-14-imammedo@redhat.com> Date: Tue, 27 Feb 2024 18:00:32 +0100 Message-ID: <87o7c1970v.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Igor Mammedov writes: > later patches will use it to pick SMBIOS version at runtime > depending on configuration. > > Signed-off-by: Igor Mammedov > --- > qapi/machine.json | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/qapi/machine.json b/qapi/machine.json > index 93b4677286..4c68528507 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -1802,10 +1802,13 @@ > # > # @64: SMBIOS version 3.0 (64-bit) Entry Point > # > +# @auto: Either 2.x or 3.x SMBIOS version, 2.x if configuration can be described > +# by it and 3.x otherwise (since: 9.0) Please format like # @auto: Either 2.x or 3.x SMBIOS version, 2.x if configuration can be # described by it and 3.x otherwise (since: 9.0) > +# > # Since: 7.0 > ## > { 'enum': 'SmbiosEntryPointType', > - 'data': [ '32', '64' ] } > + 'data': [ '32', '64', 'auto' ] } > > ## > # @MemorySizeConfiguration: With that Acked-by: Markus Armbruster