From: Thomas Gleixner <tglx@linutronix.de>
To: tip-bot2 for Ingo Molnar <tip-bot2@linutronix.de>,
linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
x86@kernel.org
Subject: Re: [tip: x86/apic] smp: Provide 'setup_max_cpus' definition on UP too
Date: Mon, 26 Feb 2024 19:19:29 +0100 [thread overview]
Message-ID: <87o7c39jgu.ffs@tglx> (raw)
In-Reply-To: <170894808668.398.2149303099223176501.tip-bot2@tip-bot2>
On Mon, Feb 26 2024 at 11:48, tip-bot2 for Ingo Molnar wrote:
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -218,6 +218,8 @@ smp_call_function_any(const struct cpumask *mask, smp_call_func_t func,
> static inline void kick_all_cpus_sync(void) { }
> static inline void wake_up_all_idle_cpus(void) { }
>
> +static const unsigned int setup_max_cpus = 0;
Oops. I missed that when looking at the patch. This is in a header file
and will be instantiated a gazillion times where ever the header is
included. It want's to be a define, no?
Thanks,
tglx
---
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -218,7 +218,7 @@ smp_call_function_any(const struct cpuma
static inline void kick_all_cpus_sync(void) { }
static inline void wake_up_all_idle_cpus(void) { }
-static const unsigned int setup_max_cpus = 0;
+#define setup_max_cpus (0)
#ifdef CONFIG_UP_LATE_INIT
extern void __init up_late_init(void);
next prev parent reply other threads:[~2024-02-26 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 11:48 [tip: x86/apic] smp: Provide 'setup_max_cpus' definition on UP too tip-bot2 for Ingo Molnar
2024-02-26 15:02 ` Borislav Petkov
2024-02-27 9:19 ` Ingo Molnar
2024-02-26 18:19 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-27 9:17 tip-bot2 for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7c39jgu.ffs@tglx \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tip-bot2@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.