Re: [PATCH] docs/sphinx: Fix TOC scroll hack for the home page

[Jonathan Corbet <corbet@lwn.net>]

Gustavo Sousa <gustavo.sousa@intel.com> writes:

> When on the documentation home page, there won't be any ".current"
> element since no entry from the TOC was selected yet. That results in a
> javascript error. Fix that by only trying to set the scrollTop if we
> have matches for current entries.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
>  Documentation/sphinx/templates/kernel-toc.html | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/sphinx/templates/kernel-toc.html b/Documentation/sphinx/templates/kernel-toc.html
> index b58efa99df52..41f1efbe64bb 100644
> --- a/Documentation/sphinx/templates/kernel-toc.html
> +++ b/Documentation/sphinx/templates/kernel-toc.html
> @@ -12,5 +12,7 @@
>  <script type="text/javascript"> <!--
>    var sbar = document.getElementsByClassName("sphinxsidebar")[0];
>    let currents = document.getElementsByClassName("current")
> -  sbar.scrollTop = currents[currents.length - 1].offsetTop;
> +  if (currents.length) {
> +    sbar.scrollTop = currents[currents.length - 1].offsetTop;
> +  }
>    --> </script>

Interesting, that's definitely a bug.  Did you stumble across this in
the console, or did it manifest in some other way for you?

Either way, I've applied this, thanks.

jon