From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EBA318C0A; Thu, 9 Nov 2023 10:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="RkjdJPjV" Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D2D310A; Thu, 9 Nov 2023 02:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699525158; bh=Z7EokJ1UdALEP2SiDB7dbNsZW0NCKV/oetJXlal69iM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RkjdJPjVAbZzNEKAPr8JL0kTpGz0UCZJIdVVndOCvDWZpxSw6ec518RfWPQG/IkiI 3U4qG8PeFJgQ1oMBVz7fnILZyAKQ1zplGG4nJux7vUUQsPp8SkZBfT889gzvIRdpmw WUQ+WW+9cu902RASJ4kEWsLYh3rMgChUmz1/ldOW9QzCrZm2l5oTa8LM/dau5laC33 KuCy2ECFzxgm0lOmPhhDCsKGLIbtABjZozYU/ee/LMkGnCNdVshd/3IasKaSCJFT9/ KHxNE3JhUBjryUMosmrOQrOBshaRABEKKf3tZkVHzFqfXwk5cxkuGy4gRH9dIH1XGz jvo7A0kAqYwOw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SQybm4Pg2z4xhd; Thu, 9 Nov 2023 21:19:00 +1100 (AEDT) From: Michael Ellerman To: Arnd Bergmann , Christophe Leroy , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> Date: Thu, 09 Nov 2023 21:18:54 +1100 Message-ID: <87o7g3qlf5.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Arnd Bergmann" writes: > On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >> Le 08/11/2023 =C3=A0 13:58, Arnd Bergmann a =C3=A9crit=C2=A0: > >> powerpc has functions doing more or less the same, they are called=20 >> __c_kernel_clock_gettime() and alike with their prototypes siting in=20 >> arch/powerpc/include/asm/vdso/gettimeofday.h >> >> Should those prototypes be moved to include/vdso/gettime.h too and=20 >> eventually renamed, or are they considered too powerpc specific ? > > I don't actually know, my initial interpretation was that > these function names are part of the user ABI for the vdso, > but I never looked closely enough at how vdso works to > be sure what the actual ABI is. AFAIK the ABI is just the symbols we export, as defined in the linker script: /* * This controls what symbols we export from the DSO. */ VERSION { VDSO_VERSION_STRING { global: __kernel_get_syscall_map; __kernel_gettimeofday; __kernel_clock_gettime; __kernel_clock_getres; __kernel_get_tbfreq; __kernel_sync_dicache; __kernel_sigtramp_rt64; __kernel_getcpu; __kernel_time; https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arc= h/powerpc/kernel/vdso/vdso64.lds.S?h=3Dv6.6&#n117 > If __c_kernel_clock_gettime() etc are not part of the user-facing > ABI, I think renaming them for consistency with the other > architectures would be best. The __c symbols are not part of the ABI, so we could rename them. At the moment though they don't have the same prototype as the generic versions, because we find the VDSO data in asm and pass it to the C functions, eg: int __c_kernel_gettimeofday(struct __kernel_old_timeval *tv, struct timezon= e *tz, const struct vdso_data *vd); I think we can rework that though, by implementing __arch_get_vdso_data() and getting the vdso_data in C. Then we'd be able to share the prototypes. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5BEBC4332F for ; Thu, 9 Nov 2023 10:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ATPirL9oH/Jh+4PvMpKoQkdm9Kfh94Casg3BXf12Hc=; b=0jeLPwEZfKRi5F A/UYQwUW78VQdRX1vKVdR+2wlV4E0D5IivQwrSy/B3lqDFLDkEiBtrf8r6NU1yQIcpEvFmEWVxb4m tEuY7EH1du55yep29eo9wgKNfmmsVTBgSyXIsxq8AjSPcCjA4uWQQ6AjR3Q2ilXBEZ3F8cTnKwLz/ 06LRxZC8FDS5AmHmZldgDOmjM+tj+iIPS/O+A0I8z90mGOFqen8dLDjndorXyg8t0FUPGQ/fIxIjp +WVdE2SwxfzNdihUN5J62Mjq8trANGWXFRY1xeb6zv4VV0mKfOCehegEC39BN/LS6WlM7w3hvUkE4 l+14lwvmWfLXLGCeMiyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r128J-005vIx-1D; Thu, 09 Nov 2023 10:19:31 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r128E-005vFi-1t; Thu, 09 Nov 2023 10:19:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699525158; bh=Z7EokJ1UdALEP2SiDB7dbNsZW0NCKV/oetJXlal69iM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RkjdJPjVAbZzNEKAPr8JL0kTpGz0UCZJIdVVndOCvDWZpxSw6ec518RfWPQG/IkiI 3U4qG8PeFJgQ1oMBVz7fnILZyAKQ1zplGG4nJux7vUUQsPp8SkZBfT889gzvIRdpmw WUQ+WW+9cu902RASJ4kEWsLYh3rMgChUmz1/ldOW9QzCrZm2l5oTa8LM/dau5laC33 KuCy2ECFzxgm0lOmPhhDCsKGLIbtABjZozYU/ee/LMkGnCNdVshd/3IasKaSCJFT9/ KHxNE3JhUBjryUMosmrOQrOBshaRABEKKf3tZkVHzFqfXwk5cxkuGy4gRH9dIH1XGz jvo7A0kAqYwOw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SQybm4Pg2z4xhd; Thu, 9 Nov 2023 21:19:00 +1100 (AEDT) From: Michael Ellerman To: Arnd Bergmann , Christophe Leroy , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> Date: Thu, 09 Nov 2023 21:18:54 +1100 Message-ID: <87o7g3qlf5.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_021926_909424_73E92EA7 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org IkFybmQgQmVyZ21hbm4iIDxhcm5kQGFybmRiLmRlPiB3cml0ZXM6Cj4gT24gV2VkLCBOb3YgOCwg MjAyMywgYXQgMTk6MzEsIENocmlzdG9waGUgTGVyb3kgd3JvdGU6Cj4+IExlIDA4LzExLzIwMjMg w6AgMTM6NTgsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPgo+PiBwb3dlcnBjIGhhcyBmdW5j dGlvbnMgZG9pbmcgbW9yZSBvciBsZXNzIHRoZSBzYW1lLCB0aGV5IGFyZSBjYWxsZWQgCj4+IF9f Y19rZXJuZWxfY2xvY2tfZ2V0dGltZSgpIGFuZCBhbGlrZSB3aXRoIHRoZWlyIHByb3RvdHlwZXMg c2l0aW5nIGluIAo+PiBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdmRzby9nZXR0aW1lb2ZkYXku aAo+Pgo+PiBTaG91bGQgdGhvc2UgcHJvdG90eXBlcyBiZSBtb3ZlZCB0byBpbmNsdWRlL3Zkc28v Z2V0dGltZS5oIHRvbyBhbmQgCj4+IGV2ZW50dWFsbHkgcmVuYW1lZCwgb3IgYXJlIHRoZXkgY29u c2lkZXJlZCB0b28gcG93ZXJwYyBzcGVjaWZpYyA/Cj4KPiBJIGRvbid0IGFjdHVhbGx5IGtub3cs IG15IGluaXRpYWwgaW50ZXJwcmV0YXRpb24gd2FzIHRoYXQKPiB0aGVzZSBmdW5jdGlvbiBuYW1l cyBhcmUgcGFydCBvZiB0aGUgdXNlciBBQkkgZm9yIHRoZSB2ZHNvLAo+IGJ1dCBJIG5ldmVyIGxv b2tlZCBjbG9zZWx5IGVub3VnaCBhdCBob3cgdmRzbyB3b3JrcyB0bwo+IGJlIHN1cmUgd2hhdCB0 aGUgYWN0dWFsIEFCSSBpcy4KCkFGQUlLIHRoZSBBQkkgaXMganVzdCB0aGUgc3ltYm9scyB3ZSBl eHBvcnQsIGFzIGRlZmluZWQgaW4gdGhlIGxpbmtlcgpzY3JpcHQ6CgovKgogKiBUaGlzIGNvbnRy b2xzIHdoYXQgc3ltYm9scyB3ZSBleHBvcnQgZnJvbSB0aGUgRFNPLgogKi8KVkVSU0lPTgp7CglW RFNPX1ZFUlNJT05fU1RSSU5HIHsKCWdsb2JhbDoKCQlfX2tlcm5lbF9nZXRfc3lzY2FsbF9tYXA7 CgkJX19rZXJuZWxfZ2V0dGltZW9mZGF5OwoJCV9fa2VybmVsX2Nsb2NrX2dldHRpbWU7CgkJX19r ZXJuZWxfY2xvY2tfZ2V0cmVzOwoJCV9fa2VybmVsX2dldF90YmZyZXE7CgkJX19rZXJuZWxfc3lu Y19kaWNhY2hlOwoJCV9fa2VybmVsX3NpZ3RyYW1wX3J0NjQ7CgkJX19rZXJuZWxfZ2V0Y3B1OwoJ CV9fa2VybmVsX3RpbWU7CgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2Vy bmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9hcmNoL3Bvd2VycGMva2VybmVsL3Zkc28v dmRzbzY0Lmxkcy5TP2g9djYuNiYjbjExNwoKPiBJZiBfX2Nfa2VybmVsX2Nsb2NrX2dldHRpbWUo KSBldGMgYXJlIG5vdCBwYXJ0IG9mIHRoZSB1c2VyLWZhY2luZwo+IEFCSSwgSSB0aGluayByZW5h bWluZyB0aGVtIGZvciBjb25zaXN0ZW5jeSB3aXRoIHRoZSBvdGhlcgo+IGFyY2hpdGVjdHVyZXMg d291bGQgYmUgYmVzdC4KClRoZSBfX2Mgc3ltYm9scyBhcmUgbm90IHBhcnQgb2YgdGhlIEFCSSwg c28gd2UgY291bGQgcmVuYW1lIHRoZW0uCgpBdCB0aGUgbW9tZW50IHRob3VnaCB0aGV5IGRvbid0 IGhhdmUgdGhlIHNhbWUgcHJvdG90eXBlIGFzIHRoZSBnZW5lcmljCnZlcnNpb25zLCBiZWNhdXNl IHdlIGZpbmQgdGhlIFZEU08gZGF0YSBpbiBhc20gYW5kIHBhc3MgaXQgdG8gdGhlIEMKZnVuY3Rp b25zLCBlZzoKCmludCBfX2Nfa2VybmVsX2dldHRpbWVvZmRheShzdHJ1Y3QgX19rZXJuZWxfb2xk X3RpbWV2YWwgKnR2LCBzdHJ1Y3QgdGltZXpvbmUgKnR6LAoJCQkgICAgY29uc3Qgc3RydWN0IHZk c29fZGF0YSAqdmQpOwoKSSB0aGluayB3ZSBjYW4gcmV3b3JrIHRoYXQgdGhvdWdoLCBieSBpbXBs ZW1lbnRpbmcKX19hcmNoX2dldF92ZHNvX2RhdGEoKSBhbmQgZ2V0dGluZyB0aGUgdmRzb19kYXRh IGluIEMuIFRoZW4gd2UnZCBiZSBhYmxlCnRvIHNoYXJlIHRoZSBwcm90b3R5cGVzLgoKY2hlZXJz CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2ED1C4167D for ; Thu, 9 Nov 2023 10:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ecqpv+gbzW2G084WeoFeaIN+dCPGxGbP6JIACTw9T7Q=; b=DnNnd/oBTESTGi mzd/eIDndsndFxBI4iizwOY/OwpbrGYrAg7zF/eWRe/7qEvYM2bp+DBZbzHHh1kRmhjyKntNNEY2h Q/fHdm4aywV329SHruvUE7DSjUA8TGRUFfkwGmOP1wzdNyKSaG2tcdSoOh+vVIk12lcVQHerZfU3M ZkNgHdy3v4pPH0SkzYM2+pL8HAnAhekpwec9SGURC4dx8VmnNWuZe3BX6OLtfl0Hrh28Yd3QKjyA2 TYGcsPjnJvNWNlu1QBNPBCEjsCNIprI1r34rylOOaKtVTCliAjnrGnQIVvwYVvwSO4WNzjeNRqzSp HUN6gAIzkiAx7c3RirGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r128J-005vJH-30; Thu, 09 Nov 2023 10:19:31 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r128E-005vFi-1t; Thu, 09 Nov 2023 10:19:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699525158; bh=Z7EokJ1UdALEP2SiDB7dbNsZW0NCKV/oetJXlal69iM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RkjdJPjVAbZzNEKAPr8JL0kTpGz0UCZJIdVVndOCvDWZpxSw6ec518RfWPQG/IkiI 3U4qG8PeFJgQ1oMBVz7fnILZyAKQ1zplGG4nJux7vUUQsPp8SkZBfT889gzvIRdpmw WUQ+WW+9cu902RASJ4kEWsLYh3rMgChUmz1/ldOW9QzCrZm2l5oTa8LM/dau5laC33 KuCy2ECFzxgm0lOmPhhDCsKGLIbtABjZozYU/ee/LMkGnCNdVshd/3IasKaSCJFT9/ KHxNE3JhUBjryUMosmrOQrOBshaRABEKKf3tZkVHzFqfXwk5cxkuGy4gRH9dIH1XGz jvo7A0kAqYwOw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SQybm4Pg2z4xhd; Thu, 9 Nov 2023 21:19:00 +1100 (AEDT) From: Michael Ellerman To: Arnd Bergmann , Christophe Leroy , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> Date: Thu, 09 Nov 2023 21:18:54 +1100 Message-ID: <87o7g3qlf5.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_021926_909424_73E92EA7 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org IkFybmQgQmVyZ21hbm4iIDxhcm5kQGFybmRiLmRlPiB3cml0ZXM6Cj4gT24gV2VkLCBOb3YgOCwg MjAyMywgYXQgMTk6MzEsIENocmlzdG9waGUgTGVyb3kgd3JvdGU6Cj4+IExlIDA4LzExLzIwMjMg w6AgMTM6NTgsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPgo+PiBwb3dlcnBjIGhhcyBmdW5j dGlvbnMgZG9pbmcgbW9yZSBvciBsZXNzIHRoZSBzYW1lLCB0aGV5IGFyZSBjYWxsZWQgCj4+IF9f Y19rZXJuZWxfY2xvY2tfZ2V0dGltZSgpIGFuZCBhbGlrZSB3aXRoIHRoZWlyIHByb3RvdHlwZXMg c2l0aW5nIGluIAo+PiBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdmRzby9nZXR0aW1lb2ZkYXku aAo+Pgo+PiBTaG91bGQgdGhvc2UgcHJvdG90eXBlcyBiZSBtb3ZlZCB0byBpbmNsdWRlL3Zkc28v Z2V0dGltZS5oIHRvbyBhbmQgCj4+IGV2ZW50dWFsbHkgcmVuYW1lZCwgb3IgYXJlIHRoZXkgY29u c2lkZXJlZCB0b28gcG93ZXJwYyBzcGVjaWZpYyA/Cj4KPiBJIGRvbid0IGFjdHVhbGx5IGtub3cs IG15IGluaXRpYWwgaW50ZXJwcmV0YXRpb24gd2FzIHRoYXQKPiB0aGVzZSBmdW5jdGlvbiBuYW1l cyBhcmUgcGFydCBvZiB0aGUgdXNlciBBQkkgZm9yIHRoZSB2ZHNvLAo+IGJ1dCBJIG5ldmVyIGxv b2tlZCBjbG9zZWx5IGVub3VnaCBhdCBob3cgdmRzbyB3b3JrcyB0bwo+IGJlIHN1cmUgd2hhdCB0 aGUgYWN0dWFsIEFCSSBpcy4KCkFGQUlLIHRoZSBBQkkgaXMganVzdCB0aGUgc3ltYm9scyB3ZSBl eHBvcnQsIGFzIGRlZmluZWQgaW4gdGhlIGxpbmtlcgpzY3JpcHQ6CgovKgogKiBUaGlzIGNvbnRy b2xzIHdoYXQgc3ltYm9scyB3ZSBleHBvcnQgZnJvbSB0aGUgRFNPLgogKi8KVkVSU0lPTgp7CglW RFNPX1ZFUlNJT05fU1RSSU5HIHsKCWdsb2JhbDoKCQlfX2tlcm5lbF9nZXRfc3lzY2FsbF9tYXA7 CgkJX19rZXJuZWxfZ2V0dGltZW9mZGF5OwoJCV9fa2VybmVsX2Nsb2NrX2dldHRpbWU7CgkJX19r ZXJuZWxfY2xvY2tfZ2V0cmVzOwoJCV9fa2VybmVsX2dldF90YmZyZXE7CgkJX19rZXJuZWxfc3lu Y19kaWNhY2hlOwoJCV9fa2VybmVsX3NpZ3RyYW1wX3J0NjQ7CgkJX19rZXJuZWxfZ2V0Y3B1OwoJ CV9fa2VybmVsX3RpbWU7CgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2Vy bmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9hcmNoL3Bvd2VycGMva2VybmVsL3Zkc28v dmRzbzY0Lmxkcy5TP2g9djYuNiYjbjExNwoKPiBJZiBfX2Nfa2VybmVsX2Nsb2NrX2dldHRpbWUo KSBldGMgYXJlIG5vdCBwYXJ0IG9mIHRoZSB1c2VyLWZhY2luZwo+IEFCSSwgSSB0aGluayByZW5h bWluZyB0aGVtIGZvciBjb25zaXN0ZW5jeSB3aXRoIHRoZSBvdGhlcgo+IGFyY2hpdGVjdHVyZXMg d291bGQgYmUgYmVzdC4KClRoZSBfX2Mgc3ltYm9scyBhcmUgbm90IHBhcnQgb2YgdGhlIEFCSSwg c28gd2UgY291bGQgcmVuYW1lIHRoZW0uCgpBdCB0aGUgbW9tZW50IHRob3VnaCB0aGV5IGRvbid0 IGhhdmUgdGhlIHNhbWUgcHJvdG90eXBlIGFzIHRoZSBnZW5lcmljCnZlcnNpb25zLCBiZWNhdXNl IHdlIGZpbmQgdGhlIFZEU08gZGF0YSBpbiBhc20gYW5kIHBhc3MgaXQgdG8gdGhlIEMKZnVuY3Rp b25zLCBlZzoKCmludCBfX2Nfa2VybmVsX2dldHRpbWVvZmRheShzdHJ1Y3QgX19rZXJuZWxfb2xk X3RpbWV2YWwgKnR2LCBzdHJ1Y3QgdGltZXpvbmUgKnR6LAoJCQkgICAgY29uc3Qgc3RydWN0IHZk c29fZGF0YSAqdmQpOwoKSSB0aGluayB3ZSBjYW4gcmV3b3JrIHRoYXQgdGhvdWdoLCBieSBpbXBs ZW1lbnRpbmcKX19hcmNoX2dldF92ZHNvX2RhdGEoKSBhbmQgZ2V0dGluZyB0aGUgdmRzb19kYXRh IGluIEMuIFRoZW4gd2UnZCBiZSBhYmxlCnRvIHNoYXJlIHRoZSBwcm90b3R5cGVzLgoKY2hlZXJz CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1y aXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46445C4332F for ; Thu, 9 Nov 2023 10:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KfzqOfHHPU7NgB0lFN21vgAZVWdAZqrrlyeAfLB/ElI=; b=mEWP8VSs4I0tNa R/IQ2BHE50v35nEQTJo4FPFirKx3RiAU2IsYv2s583cRfStb60NgYayrqK3F7fb2fEkyyIf4o7c/C wLk6qylEmeBQ/K2Nl7mY9MZuWwWWI5phK+0qMOUpY5il6+bjAkV5A7CYKdR9YtuSKNa+WnTtsuKxq 4vhd2N03JcDnQdh9F9fThtrMbez8WeOrLewQxZumZpVk/VUtqltz03ys0Lq7tvIRl3SwHOiMwqqXm EKV/YyG/6l+RnjQ/wqZXhpgLBcx8mEr7tXi6q3gV1ZT+umzbHX6M7GROeGtpjgIkg3rEJHvqJmqY6 5YKTXyeM5nX2AzBcrmEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r128K-005vJh-1s; Thu, 09 Nov 2023 10:19:32 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r128E-005vFi-1t; Thu, 09 Nov 2023 10:19:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699525158; bh=Z7EokJ1UdALEP2SiDB7dbNsZW0NCKV/oetJXlal69iM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RkjdJPjVAbZzNEKAPr8JL0kTpGz0UCZJIdVVndOCvDWZpxSw6ec518RfWPQG/IkiI 3U4qG8PeFJgQ1oMBVz7fnILZyAKQ1zplGG4nJux7vUUQsPp8SkZBfT889gzvIRdpmw WUQ+WW+9cu902RASJ4kEWsLYh3rMgChUmz1/ldOW9QzCrZm2l5oTa8LM/dau5laC33 KuCy2ECFzxgm0lOmPhhDCsKGLIbtABjZozYU/ee/LMkGnCNdVshd/3IasKaSCJFT9/ KHxNE3JhUBjryUMosmrOQrOBshaRABEKKf3tZkVHzFqfXwk5cxkuGy4gRH9dIH1XGz jvo7A0kAqYwOw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SQybm4Pg2z4xhd; Thu, 9 Nov 2023 21:19:00 +1100 (AEDT) From: Michael Ellerman To: Arnd Bergmann , Christophe Leroy , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> Date: Thu, 09 Nov 2023 21:18:54 +1100 Message-ID: <87o7g3qlf5.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_021926_909424_73E92EA7 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org IkFybmQgQmVyZ21hbm4iIDxhcm5kQGFybmRiLmRlPiB3cml0ZXM6Cj4gT24gV2VkLCBOb3YgOCwg MjAyMywgYXQgMTk6MzEsIENocmlzdG9waGUgTGVyb3kgd3JvdGU6Cj4+IExlIDA4LzExLzIwMjMg w6AgMTM6NTgsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPgo+PiBwb3dlcnBjIGhhcyBmdW5j dGlvbnMgZG9pbmcgbW9yZSBvciBsZXNzIHRoZSBzYW1lLCB0aGV5IGFyZSBjYWxsZWQgCj4+IF9f Y19rZXJuZWxfY2xvY2tfZ2V0dGltZSgpIGFuZCBhbGlrZSB3aXRoIHRoZWlyIHByb3RvdHlwZXMg c2l0aW5nIGluIAo+PiBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdmRzby9nZXR0aW1lb2ZkYXku aAo+Pgo+PiBTaG91bGQgdGhvc2UgcHJvdG90eXBlcyBiZSBtb3ZlZCB0byBpbmNsdWRlL3Zkc28v Z2V0dGltZS5oIHRvbyBhbmQgCj4+IGV2ZW50dWFsbHkgcmVuYW1lZCwgb3IgYXJlIHRoZXkgY29u c2lkZXJlZCB0b28gcG93ZXJwYyBzcGVjaWZpYyA/Cj4KPiBJIGRvbid0IGFjdHVhbGx5IGtub3cs IG15IGluaXRpYWwgaW50ZXJwcmV0YXRpb24gd2FzIHRoYXQKPiB0aGVzZSBmdW5jdGlvbiBuYW1l cyBhcmUgcGFydCBvZiB0aGUgdXNlciBBQkkgZm9yIHRoZSB2ZHNvLAo+IGJ1dCBJIG5ldmVyIGxv b2tlZCBjbG9zZWx5IGVub3VnaCBhdCBob3cgdmRzbyB3b3JrcyB0bwo+IGJlIHN1cmUgd2hhdCB0 aGUgYWN0dWFsIEFCSSBpcy4KCkFGQUlLIHRoZSBBQkkgaXMganVzdCB0aGUgc3ltYm9scyB3ZSBl eHBvcnQsIGFzIGRlZmluZWQgaW4gdGhlIGxpbmtlcgpzY3JpcHQ6CgovKgogKiBUaGlzIGNvbnRy b2xzIHdoYXQgc3ltYm9scyB3ZSBleHBvcnQgZnJvbSB0aGUgRFNPLgogKi8KVkVSU0lPTgp7CglW RFNPX1ZFUlNJT05fU1RSSU5HIHsKCWdsb2JhbDoKCQlfX2tlcm5lbF9nZXRfc3lzY2FsbF9tYXA7 CgkJX19rZXJuZWxfZ2V0dGltZW9mZGF5OwoJCV9fa2VybmVsX2Nsb2NrX2dldHRpbWU7CgkJX19r ZXJuZWxfY2xvY2tfZ2V0cmVzOwoJCV9fa2VybmVsX2dldF90YmZyZXE7CgkJX19rZXJuZWxfc3lu Y19kaWNhY2hlOwoJCV9fa2VybmVsX3NpZ3RyYW1wX3J0NjQ7CgkJX19rZXJuZWxfZ2V0Y3B1OwoJ CV9fa2VybmVsX3RpbWU7CgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2Vy bmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9hcmNoL3Bvd2VycGMva2VybmVsL3Zkc28v dmRzbzY0Lmxkcy5TP2g9djYuNiYjbjExNwoKPiBJZiBfX2Nfa2VybmVsX2Nsb2NrX2dldHRpbWUo KSBldGMgYXJlIG5vdCBwYXJ0IG9mIHRoZSB1c2VyLWZhY2luZwo+IEFCSSwgSSB0aGluayByZW5h bWluZyB0aGVtIGZvciBjb25zaXN0ZW5jeSB3aXRoIHRoZSBvdGhlcgo+IGFyY2hpdGVjdHVyZXMg d291bGQgYmUgYmVzdC4KClRoZSBfX2Mgc3ltYm9scyBhcmUgbm90IHBhcnQgb2YgdGhlIEFCSSwg c28gd2UgY291bGQgcmVuYW1lIHRoZW0uCgpBdCB0aGUgbW9tZW50IHRob3VnaCB0aGV5IGRvbid0 IGhhdmUgdGhlIHNhbWUgcHJvdG90eXBlIGFzIHRoZSBnZW5lcmljCnZlcnNpb25zLCBiZWNhdXNl IHdlIGZpbmQgdGhlIFZEU08gZGF0YSBpbiBhc20gYW5kIHBhc3MgaXQgdG8gdGhlIEMKZnVuY3Rp b25zLCBlZzoKCmludCBfX2Nfa2VybmVsX2dldHRpbWVvZmRheShzdHJ1Y3QgX19rZXJuZWxfb2xk X3RpbWV2YWwgKnR2LCBzdHJ1Y3QgdGltZXpvbmUgKnR6LAoJCQkgICAgY29uc3Qgc3RydWN0IHZk c29fZGF0YSAqdmQpOwoKSSB0aGluayB3ZSBjYW4gcmV3b3JrIHRoYXQgdGhvdWdoLCBieSBpbXBs ZW1lbnRpbmcKX19hcmNoX2dldF92ZHNvX2RhdGEoKSBhbmQgZ2V0dGluZyB0aGUgdmRzb19kYXRh IGluIEMuIFRoZW4gd2UnZCBiZSBhYmxlCnRvIHNoYXJlIHRoZSBwcm90b3R5cGVzLgoKY2hlZXJz CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1z bnBzLWFyYyBtYWlsaW5nIGxpc3QKbGludXgtc25wcy1hcmNAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXNucHMtYXJj Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F01C0018C for ; Thu, 9 Nov 2023 11:20:25 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=RkjdJPjV; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SQzyb5tPbz3cb6 for ; Thu, 9 Nov 2023 22:20:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=RkjdJPjV; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SQycC0CL6z3c1L for ; Thu, 9 Nov 2023 21:19:23 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699525158; bh=Z7EokJ1UdALEP2SiDB7dbNsZW0NCKV/oetJXlal69iM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RkjdJPjVAbZzNEKAPr8JL0kTpGz0UCZJIdVVndOCvDWZpxSw6ec518RfWPQG/IkiI 3U4qG8PeFJgQ1oMBVz7fnILZyAKQ1zplGG4nJux7vUUQsPp8SkZBfT889gzvIRdpmw WUQ+WW+9cu902RASJ4kEWsLYh3rMgChUmz1/ldOW9QzCrZm2l5oTa8LM/dau5laC33 KuCy2ECFzxgm0lOmPhhDCsKGLIbtABjZozYU/ee/LMkGnCNdVshd/3IasKaSCJFT9/ KHxNE3JhUBjryUMosmrOQrOBshaRABEKKf3tZkVHzFqfXwk5cxkuGy4gRH9dIH1XGz jvo7A0kAqYwOw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SQybm4Pg2z4xhd; Thu, 9 Nov 2023 21:19:00 +1100 (AEDT) From: Michael Ellerman To: Arnd Bergmann , Christophe Leroy , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> Date: Thu, 09 Nov 2023 21:18:54 +1100 Message-ID: <87o7g3qlf5.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 09 Nov 2023 22:18:45 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , "linux-fbdev@vger.kernel.org" , "x86@kernel.org" , "loongarch@lists.linux.dev" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Catalin Marinas , "dri-devel@lists.freedesktop.org" , Netdev , guoren , "linux-csky@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Vincenzo Frascino , Will Deacon , Greg Ungerer , Nicolas Schier , "linux-s390@vger.kernel.org" , Vincent Guittot , Helge Deller , Huacai Chen , Russell King , Anil S Keshavamurthy , Ard Biesheuvel , "linux-bcachefs@vger.kernel.org" , Ingo Molnar , Vineet Gupta , "Naveen N. Rao" , Matt Turner , "linux-snps-arc@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , Kees Cook , Heiko Carstens , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linuxppc-dev@lists.ozlabs.org" , Nicholas Piggin , Nathan Chancellor , "linux-m68k@lists.linux-m68k.org" , Steven Rostedt , Andy Lutomirski , John Paul Adrian Glaubitz , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Michal Simek , Thomas Bogendoerfer , "linux-parisc@vger.kernel.org" , Timur Tabi , Geoff Levand , Greg Kroah-Hartman , Kent Overstreet , Nick Desaulniers , "linux-mips@vger.kernel.org" , Sudip Mukherjee , Dinh Nguyen , "linux-usb@vger.kernel.org" , Palmer Dabbelt , Masami Hiramatsu , "linux-alpha@vger.kernel.org" , "linux-mtd@lists.infradead.org" , David Woodhouse , "David S . Miller" , Alexander Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" "Arnd Bergmann" writes: > On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >> Le 08/11/2023 =C3=A0 13:58, Arnd Bergmann a =C3=A9crit=C2=A0: > >> powerpc has functions doing more or less the same, they are called=20 >> __c_kernel_clock_gettime() and alike with their prototypes siting in=20 >> arch/powerpc/include/asm/vdso/gettimeofday.h >> >> Should those prototypes be moved to include/vdso/gettime.h too and=20 >> eventually renamed, or are they considered too powerpc specific ? > > I don't actually know, my initial interpretation was that > these function names are part of the user ABI for the vdso, > but I never looked closely enough at how vdso works to > be sure what the actual ABI is. AFAIK the ABI is just the symbols we export, as defined in the linker script: /* * This controls what symbols we export from the DSO. */ VERSION { VDSO_VERSION_STRING { global: __kernel_get_syscall_map; __kernel_gettimeofday; __kernel_clock_gettime; __kernel_clock_getres; __kernel_get_tbfreq; __kernel_sync_dicache; __kernel_sigtramp_rt64; __kernel_getcpu; __kernel_time; https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arc= h/powerpc/kernel/vdso/vdso64.lds.S?h=3Dv6.6&#n117 > If __c_kernel_clock_gettime() etc are not part of the user-facing > ABI, I think renaming them for consistency with the other > architectures would be best. The __c symbols are not part of the ABI, so we could rename them. At the moment though they don't have the same prototype as the generic versions, because we find the VDSO data in asm and pass it to the C functions, eg: int __c_kernel_gettimeofday(struct __kernel_old_timeval *tv, struct timezon= e *tz, const struct vdso_data *vd); I think we can rework that though, by implementing __arch_get_vdso_data() and getting the vdso_data in C. Then we'd be able to share the prototypes. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86C3DC04E88 for ; Thu, 9 Nov 2023 10:19:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E63B10E894; Thu, 9 Nov 2023 10:19:28 +0000 (UTC) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gabe.freedesktop.org (Postfix) with ESMTPS id B823010E205 for ; Thu, 9 Nov 2023 10:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699525158; bh=Z7EokJ1UdALEP2SiDB7dbNsZW0NCKV/oetJXlal69iM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RkjdJPjVAbZzNEKAPr8JL0kTpGz0UCZJIdVVndOCvDWZpxSw6ec518RfWPQG/IkiI 3U4qG8PeFJgQ1oMBVz7fnILZyAKQ1zplGG4nJux7vUUQsPp8SkZBfT889gzvIRdpmw WUQ+WW+9cu902RASJ4kEWsLYh3rMgChUmz1/ldOW9QzCrZm2l5oTa8LM/dau5laC33 KuCy2ECFzxgm0lOmPhhDCsKGLIbtABjZozYU/ee/LMkGnCNdVshd/3IasKaSCJFT9/ KHxNE3JhUBjryUMosmrOQrOBshaRABEKKf3tZkVHzFqfXwk5cxkuGy4gRH9dIH1XGz jvo7A0kAqYwOw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SQybm4Pg2z4xhd; Thu, 9 Nov 2023 21:19:00 +1100 (AEDT) From: Michael Ellerman To: Arnd Bergmann , Christophe Leroy , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> Date: Thu, 09 Nov 2023 21:18:54 +1100 Message-ID: <87o7g3qlf5.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , "linux-fbdev@vger.kernel.org" , "x86@kernel.org" , "loongarch@lists.linux.dev" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Catalin Marinas , "dri-devel@lists.freedesktop.org" , Netdev , guoren , "linux-csky@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Vincenzo Frascino , Will Deacon , Greg Ungerer , Nicolas Schier , "linux-s390@vger.kernel.org" , Vincent Guittot , Helge Deller , Huacai Chen , Russell King , Anil S Keshavamurthy , Ard Biesheuvel , "linux-bcachefs@vger.kernel.org" , Ingo Molnar , Vineet Gupta , "Naveen N. Rao" , Matt Turner , "linux-snps-arc@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , Kees Cook , Heiko Carstens , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linuxppc-dev@lists.ozlabs.org" , Nicholas Piggin , Nathan Chancellor , "linux-m68k@lists.linux-m68k.org" , Steven Rostedt , Andy Lutomirski , John Paul Adrian Glaubitz , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Michal Simek , Thomas Bogendoerfer , "linux-parisc@vger.kernel.org" , Timur Tabi , Geoff Levand , Greg Kroah-Hartman , Kent Overstreet , Nick Desaulniers , "linux-mips@vger.kernel.org" , Sudip Mukherjee , Dinh Nguyen , "linux-usb@vger.kernel.org" , Palmer Dabbelt , Masami Hiramatsu , "linux-alpha@vger.kernel.org" , "linux-mtd@lists.infradead.org" , David Woodhouse , "David S . Miller" , Alexander Viro Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" "Arnd Bergmann" writes: > On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >> Le 08/11/2023 =C3=A0 13:58, Arnd Bergmann a =C3=A9crit=C2=A0: > >> powerpc has functions doing more or less the same, they are called=20 >> __c_kernel_clock_gettime() and alike with their prototypes siting in=20 >> arch/powerpc/include/asm/vdso/gettimeofday.h >> >> Should those prototypes be moved to include/vdso/gettime.h too and=20 >> eventually renamed, or are they considered too powerpc specific ? > > I don't actually know, my initial interpretation was that > these function names are part of the user ABI for the vdso, > but I never looked closely enough at how vdso works to > be sure what the actual ABI is. AFAIK the ABI is just the symbols we export, as defined in the linker script: /* * This controls what symbols we export from the DSO. */ VERSION { VDSO_VERSION_STRING { global: __kernel_get_syscall_map; __kernel_gettimeofday; __kernel_clock_gettime; __kernel_clock_getres; __kernel_get_tbfreq; __kernel_sync_dicache; __kernel_sigtramp_rt64; __kernel_getcpu; __kernel_time; https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arc= h/powerpc/kernel/vdso/vdso64.lds.S?h=3Dv6.6&#n117 > If __c_kernel_clock_gettime() etc are not part of the user-facing > ABI, I think renaming them for consistency with the other > architectures would be best. The __c symbols are not part of the ABI, so we could rename them. At the moment though they don't have the same prototype as the generic versions, because we find the VDSO data in asm and pass it to the C functions, eg: int __c_kernel_gettimeofday(struct __kernel_old_timeval *tv, struct timezon= e *tz, const struct vdso_data *vd); I think we can rework that though, by implementing __arch_get_vdso_data() and getting the vdso_data in C. Then we'd be able to share the prototypes. cheers