From: Markus Armbruster <armbru@redhat.com>
To: Dinah B <dinahbaum123@gmail.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>
Subject: Re: [PATCH v3 1/3] qapi: Moved architecture agnostic data types to `machine`
Date: Thu, 02 Nov 2023 07:59:35 +0100 [thread overview]
Message-ID: <87o7gcd4iw.fsf@pond.sub.org> (raw)
In-Reply-To: <CAH50XRd_7w1OzLpyBZt-MRL4HMA6_MoKg28qO3h65UU2Dt2uFw@mail.gmail.com> (Dinah B.'s message of "Tue, 31 Oct 2023 22:24:13 -0400")
Dinah B <dinahbaum123@gmail.com> writes:
> Hi,
>
> I noticed that qapi now has a machine-common category - do you think these
> changes would be more appropriate in that file
> rather than "machine" for the revision?
You're right.
We created machine-common.json for stuff needed by both machine.json and
machine-target.json. The alternative was to have machine-target.json
include machine.json instead. When we discussed which alternative to
pick, I didn't remember your patch adds the include.
Picking both makes no sense. Please look into adding stuff in a way
that avoids the include.
Thanks for paying attention!
> Thanks and sorry for the delay,
I'm not in a hurry here :)
next prev parent reply other threads:[~2023-11-02 7:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 6:40 [PATCH v3 0/3] Enable -cpu <cpu>,help Dinah Baum
2023-07-30 6:40 ` [PATCH v3 1/3] qapi: Moved architecture agnostic data types to `machine` Dinah Baum
2023-07-31 9:54 ` Philippe Mathieu-Daudé
2023-08-01 13:09 ` Markus Armbruster
2023-11-01 2:24 ` Dinah B
2023-11-02 6:59 ` Markus Armbruster [this message]
2023-07-30 6:40 ` [PATCH v3 2/3] qapi, target/: Enable 'query-cpu-model-expansion' on all architectures Dinah Baum
2023-08-01 13:44 ` Markus Armbruster
2023-07-30 6:40 ` [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help to print options for the CPU type similar to how the '-device' option works Dinah Baum
2023-08-01 13:02 ` Dinah B
2023-08-01 14:09 ` [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu,help " Markus Armbruster
2023-08-01 21:00 ` [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help " Dinah B
2023-08-02 5:36 ` [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu,help " Markus Armbruster
2023-11-14 16:22 ` [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help " Dinah B
2023-11-14 17:44 ` [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu,help " Markus Armbruster
2023-12-11 6:02 ` [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help " Dinah B
2023-07-30 15:15 ` [PATCH v3 0/3] Enable -cpu <cpu>,help Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7gcd4iw.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=dinahbaum123@gmail.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.