From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>, peterx@redhat.com
Subject: Re: [PATCH] migration: Fix parse_ramblock() on overwritten retvals
Date: Tue, 17 Oct 2023 19:30:50 -0300 [thread overview]
Message-ID: <87o7gwhof9.fsf@suse.de> (raw)
In-Reply-To: <20231017203855.298260-1-peterx@redhat.com>
Peter Xu <peterx@redhat.com> writes:
> It's possible that some errors can be overwritten with success retval later
> on, and then ignored. Always capture all errors and report.
>
> Reported by Coverity 1522861, but actually I spot one more in the same
> function.
>
> Fixes: CID 1522861
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2023-10-17 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 20:38 [PATCH] migration: Fix parse_ramblock() on overwritten retvals Peter Xu
2023-10-17 22:30 ` Fabiano Rosas [this message]
2023-10-18 7:12 ` Juan Quintela
2023-10-18 13:16 ` Peter Xu
2023-10-18 13:54 ` Juan Quintela
2023-10-19 12:40 ` Peter Maydell
2023-10-19 14:50 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7gwhof9.fsf@suse.de \
--to=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.