From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BFB8CD5BDE for ; Thu, 21 Sep 2023 16:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjIUQ6x (ORCPT ); Thu, 21 Sep 2023 12:58:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjIUQ6w (ORCPT ); Thu, 21 Sep 2023 12:58:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3DAE1BD6 for ; Thu, 21 Sep 2023 09:58:16 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5ACEBC4E66D; Thu, 21 Sep 2023 12:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695298346; bh=0oOKV5dd8K+N8q0nDh5k3SZD+WjqZu42p4J1UFU6oR8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UGiiGfV3KJCu3NO3o4MsPbiX5YZgKfLI/tQle52lRMMwVmDtELeCb8l6h7lIjZMOw 6HLVSfV9O+ncaAW7KnDdwNrOfwaeGf/i07i5pe9MP2mX3VlAjtyRMvJ9Kchb5ETAsi m6/9hvXB9SrVUxkamEVzEN7e2QkwwKSvycR6qNETwnNhc2p4IS2Xnq/80CVucxOcR2 LEQ21mAGwqFzNGAWVq6NdavWFQVLJDXlaPZPJGfeZNIQn4+kLqXuZB1+Sl6/SfYk3g 5TozBzk/GtEoxsRukE32bUuF3YS74j/P6FV8tclPSmG0pbPzBKs+pEjdgQ6bgo/wkM HBdJ7Jnzmfybw== From: Kalle Valo To: Dmitry Antipov Cc: Brian Norris , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] wifi: mwifiex: fix SDIO firmware dump wait References: <20230920112259.18656-1-dmantipov@yandex.ru> Date: Thu, 21 Sep 2023 15:12:23 +0300 In-Reply-To: (Dmitry Antipov's message of "Thu, 21 Sep 2023 12:22:59 +0300") Message-ID: <87o7hvafo8.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov writes: > On 9/21/23 02:15, Brian Norris wrote: > >> Have you tested this patch? You've certainly caught a logic bug, but >> that doesn't mean the seemingly obvious solution actually works. > > Unfortunately by eyes only :-(. IIUC there should be a weird hardware > stall to trigger an execution of the branch in subject, so I'm not sure > how to actually test it even if I would have an access to the hardware. I don't know about Brian but for me testing for regressions is the most important part. If the patch is only compile tested it could break the whole driver without anyone noticing. And then it's in a release and too late. That's why I have been asking you to add "Compile tested only" to the commit log so that it's obvious to everyone that your patches have received zero testing but you don't seem to care. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches