From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 435F9EE643D for ; Fri, 15 Sep 2023 08:33:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A5711852; Fri, 15 Sep 2023 10:32:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A5711852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694766816; bh=7a2pAZv+lVyqQv5oMAegiTF/XssIWnDCr68dZjHxxGI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=J9rwSaE07AIKmbxpCGKZJM74rtxJBNel/wmBgwcBXCC8gnK9AyEaoAwmOllOBYLNC 9rhUWZnD6fZ6+G7biXnt3zP5ZUZynPEeW//MIIGu+rV9p2GQmZaVxLfA7n5G6VZ7U/ kvi8N6tvhOwX23L8CAU2e0H16ISEOmODyKdcwHzI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id B96A1F8056F; Fri, 15 Sep 2023 10:31:30 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5F761F8047D; Fri, 15 Sep 2023 10:31:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9EC1BF80552; Fri, 15 Sep 2023 10:31:26 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0F2C4F8007C for ; Fri, 15 Sep 2023 10:31:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0F2C4F8007C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rwOdIsx5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TL/0dtrA Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DC06A2187D; Fri, 15 Sep 2023 08:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694766681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2Beeu5CPtfOOLJTu6GgdOUwpcTJvByrQgKRtH+jqas=; b=rwOdIsx5ZAji3I0kvtYRyEICeSjZDJV7AVZfAxDjDdpOAcxgxt7gzfFquV4VyKf6b66TSW 4h0H0MXSuhcNz4Hze9nvbFE7pW+7IwOvh/kzd7vfuTQszdxZBkjTttVSnSQBHeq+C273iJ yM+gkJkCViqw3tRNMg3KI78JHlMJXtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694766681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2Beeu5CPtfOOLJTu6GgdOUwpcTJvByrQgKRtH+jqas=; b=TL/0dtrAOQ0daQwqQtmkkm+RqbpF2gHaH80OM/UQymRDE9BlRwlq2dFQIFRInUtCGXGzuh 6JP9BH3KnlKnSiBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A05491358A; Fri, 15 Sep 2023 08:31:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GnXmJVkWBGVuQwAAMHmgww (envelope-from ); Fri, 15 Sep 2023 08:31:21 +0000 Date: Fri, 15 Sep 2023 10:31:21 +0200 Message-ID: <87o7i3x2g6.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , Subject: Re: [PATCH v2] ALSA: hda: cs35l56: Fix missing RESET GPIO if _SUB is missing In-Reply-To: <20230914152525.20829-1-rf@opensource.cirrus.com> References: <20230914152525.20829-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: BFFRABZSVZQIJPIXKZRDGDXDJMHDEQ5E X-Message-ID-Hash: BFFRABZSVZQIJPIXKZRDGDXDJMHDEQ5E X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 14 Sep 2023 17:25:25 +0200, Richard Fitzgerald wrote: > > In cs35l56_hda_read_acpi() do not return if ACPI _SUB is missing. > > A missing _SUB means that the driver cannot load a system-specific > firmware, because the firmware is identified by the _SUB. But it can > fallback to a generic firmware. Unfortunately this was being handled > by immediately returning 0, which would skip the remaining ACPI > configuration in cs35l56_hda_read_acpi() and so it would not get the > RESET GPIO. > > Signed-off-by: Richard Fitzgerald > Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") Thanks, applied now. Takashi