From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E42CEB8FAF for ; Wed, 6 Sep 2023 08:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Z/PnTaDBCq7Si8iWdGbWd1KkT34U0dCZzk5o+FIgx0=; b=gc12gu3mMsoCd7 zaO7VvLiZ4/JEM6Q9BbgUtlp+/6lQamshBm+3kbKP1u3WWAWK9QSBxb6K/pJzBM34C2pYA7ELD2Am 83YOzm4quqBmba/4rs8G7jOh2+IwTZxePusGfEprZG+I99ndBw7ZHQgntoLeCRnHiOc2PKir0zo7z gF6/aGYA9HASz8w2CmQpUwIO4TXxldXJTPI+5LFrGiplZsKOtJUF55mQET1P8qI1ULcQiAICDrvRs hwtdftSTk+fsE+2RCx739MZWzE1YY8Gg96jbTBJjiPa60YBClxlBu/7YMUFDw6cPUVVozgxpXeJr6 aKWYgDFzSXWzUGhGnhww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdo5y-007ldd-2r; Wed, 06 Sep 2023 08:41:06 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdo5x-007ldJ-2v for ath11k@bombadil.infradead.org; Wed, 06 Sep 2023 08:41:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=YUFebss2i1howj2H2bCpkSr1yD1P7RCpTR6z4A7omOE=; b=fxXK4Jeyv2gSPVI2P5/a6ledPl 9nPUD2VP/sVU8WQs3WkCQQrOLbV2soudrfh86alFzuEmg1ft80tMiKpO+xHr2BdtAIRa6Qos5nfH1 UwXDQl6yyGxsAEqnOL//n5ayzCm3qX76yHZ8SNTvh2MB+omUeCapg3mjb/fzP+p7AkwQpCI1WCpCw YsA2pZi02K9hsNsw7V4UuqxEokoFAxRg/NchhZ4o6hFtvfKI+qkzW5BmK7zyk4O5aPb57gpiopPNB WcnOLpPJogVutZt1AlOVK7i/ost2sY8A4dIDsPPpdYCW6q220hg1PIRh0OMcDvzgR+huG7TmMuJxR 8KOIx1wg==; Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdo5s-000zKx-17 for ath11k@lists.infradead.org; Wed, 06 Sep 2023 08:41:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8238BB818C2; Wed, 6 Sep 2023 08:40:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D520CC433C9; Wed, 6 Sep 2023 08:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693989656; bh=33osJvMi9BkVlhAaa6FIokdBDnUZlNZzV6kbO/dmsVI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=qXSpfDQOyB1xWgYrcNz+6QSgQyCR06Yj44CINKaWehowHXiUO73ng8lfQD0d2Jpoj wqHa7F3iZl7r0mzZIOu8Npa4pa9ZU/Qqssm7fcr6nWHRkT1aH7RSDg7gUeKcVp7EH6 dZsxh/Paw9NOLeWCrgtA8ps8tS3Va+53HBzYUaQZA/oBzj/yg96aBdGgGATzXa4T/k gUQE6g+sDDTpHu4E6sRzJHM3uRN0AhxEzO0JyCErPqdh8hkiuOvDyZGiBODWbN/DJQ 02E2qr4cQGvwmYdHBbfLNm9v8oxAd2hJXhmWOn8lAYZ9ALF7QU+T3QtYGQAdcK7uXt 3ErZC2knqhscA== From: Kalle Valo To: Ross Lagerwall Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, regressions@lists.linux.dev Subject: Re: [regression v6.5-rc1] PCI: comm "swapper/0" leaking memory References: <878r9sga1t.fsf@kernel.org> Date: Wed, 06 Sep 2023 11:40:52 +0300 In-Reply-To: (Ross Lagerwall's message of "Tue, 5 Sep 2023 17:28:38 +0100") Message-ID: <87o7ifelt7.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230906_094102_019130_BD862E58 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Um9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNsb3VkLmNvbT4gd3JpdGVzOgoKPiBPbiBX ZWQsIEF1ZyAzMCwgMjAyMyBhdCAxMDoyMeKAr0FNIEthbGxlIFZhbG8gPGt2YWxvQGtlcm5lbC5v cmc+IHdyb3RlOgo+Cj4+Cj4+IEkgbm90aWNlZCB0aGF0IHN0YXJ0aW5nIGZyb20gdjYuNS1yYzEg bXkgYXRoMTFrIHRlc3RzIHJlcG9ydGVkIHNldmVyYWwKPj4gbWVtb3J5IGxlYWtzIGZyb20gc3dh cHBlci8wOgo+Pgo+PiB1bnJlZmVyZW5jZWQgb2JqZWN0IDB4ZmZmZjg4ODEwYTAyYjdhOCAoc2l6 ZSA5Nik6Cj4+ICAgY29tbSAic3dhcHBlci8wIiwgcGlkIDEsIGppZmZpZXMgNDI5NDY3MTgzOCAo YWdlIDk4LjEyMHMpCj4+ICAgaGV4IGR1bXAgKGZpcnN0IDMyIGJ5dGVzKToKPj4gICAgIDgwIGI4 IDAyIDBhIDgxIDg4IGZmIGZmIGI4IDcyIDA3IDAwIDAwIGM5IGZmIGZmICAuLi4uLi4uLi5yLi4u Li4uCj4+ICAgICBjOCBiNyAwMiAwYSA4MSA4OCBmZiBmZiAwMCAwMCAwMCAwMCAwMCAwMCAwMCAw MCAgLi4uLi4uLi4uLi4uLi4uLgo+PiAgIGJhY2t0cmFjZToKPj4gdW5yZWZlcmVuY2VkIG9iamVj dCAweGZmZmY4ODgxMGEwMmI4ODAgKHNpemUgOTYpOgo+PiAgIGNvbW0gInN3YXBwZXIvMCIsIHBp ZCAxLCBqaWZmaWVzIDQyOTQ2NzE4MzggKGFnZSA5OC4xMjBzKQo+PiAgIGhleCBkdW1wIChmaXJz dCAzMiBieXRlcyk6Cj4+ICAgICA1OCBiOSAwMiAwYSA4MSA4OCBmZiBmZiBhOCBiNyAwMiAwYSA4 MSA4OCBmZiBmZiAgWC4uLi4uLi4uLi4uLi4uLgo+PiAgICAgYTAgYjggMDIgMGEgODEgODggZmYg ZmYgMDAgMDAgMDAgMDAgMDAgMDAgMDAgMDAgIC4uLi4uLi4uLi4uLi4uLi4KPj4gICBiYWNrdHJh Y2U6Cj4+IHVucmVmZXJlbmNlZCBvYmplY3QgMHhmZmZmODg4MTBhMDJiOTU4IChzaXplIDk2KToK Pj4gICBjb21tICJzd2FwcGVyLzAiLCBwaWQgMSwgamlmZmllcyA0Mjk0NjcxODM4IChhZ2UgOTgu MTIwcykKPj4gICBoZXggZHVtcCAoZmlyc3QgMzIgYnl0ZXMpOgo+PiAgICAgMzAgYmEgMDIgMGEg ODEgODggZmYgZmYgODAgYjggMDIgMGEgODEgODggZmYgZmYgIDAuLi4uLi4uLi4uLi4uLi4KPj4g ICAgIDc4IGI5IDAyIDBhIDgxIDg4IGZmIGZmIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwICB4Li4u Li4uLi4uLi4uLi4uCj4+ICAgYmFja3RyYWNlOgo+PiB1bnJlZmVyZW5jZWQgb2JqZWN0IDB4ZmZm Zjg4ODEwYTAyYmEzMCAoc2l6ZSA5Nik6Cj4+ICAgY29tbSAic3dhcHBlci8wIiwgcGlkIDEsIGpp ZmZpZXMgNDI5NDY3MTgzOCAoYWdlIDk4LjEyMHMpCj4+ICAgaGV4IGR1bXAgKGZpcnN0IDMyIGJ5 dGVzKToKPj4gICAgIDA4IGJiIDAyIDBhIDgxIDg4IGZmIGZmIDU4IGI5IDAyIDBhIDgxIDg4IGZm IGZmICAuLi4uLi4uLlguLi4uLi4uCj4+ICAgICA1MCBiYSAwMiAwYSA4MSA4OCBmZiBmZiAwMCAw MCAwMCAwMCAwMCAwMCAwMCAwMCAgUC4uLi4uLi4uLi4uLi4uLgo+PiAgIGJhY2t0cmFjZToKPj4g dW5yZWZlcmVuY2VkIG9iamVjdCAweGZmZmY4ODgxMGEwMmJiMDggKHNpemUgOTYpOgo+PiAgIGNv bW0gInN3YXBwZXIvMCIsIHBpZCAxLCBqaWZmaWVzIDQyOTQ2NzE4MzggKGFnZSA5OC4xMjBzKQo+ PiAgIGhleCBkdW1wIChmaXJzdCAzMiBieXRlcyk6Cj4+ICAgICBlMCBiYiAwMiAwYSA4MSA4OCBm ZiBmZiAzMCBiYSAwMiAwYSA4MSA4OCBmZiBmZiAgLi4uLi4uLi4wLi4uLi4uLgo+PiAgICAgMjgg YmIgMDIgMGEgODEgODggZmYgZmYgMDAgMDAgMDAgMDAgMDAgMDAgMDAgMDAgICguLi4uLi4uLi4u Li4uLi4KPj4gICBiYWNrdHJhY2U6Cj4+Cj4+IEkgY2FuIGVhc2lseSByZXByb2R1Y2UgdGhpcyBi eSBkb2luZyBhIHNpbXBsZSBpbnNtb2QgYW5kIHJtbW9kIG9mIGF0aDExawo+PiBhbmQgaXQncyBk ZXBlbmRlbmNpZXMgKG1hYzgwMjExLCBNSEkgZXRjKS4gSSBjYW4gcmVsaWFiaWxpdHkgcmVwcm9k dWNlCj4+IHRoZSBsZWFrcyBidXQgSSBvbmx5IHNlZSB0aGVtIG9uY2UgYWZ0ZXIgYSBib290LCBJ IG5lZWQgdG8gcmVib290IHRoZQo+PiBob3N0IHRvIHNlZSB0aGUgbGVha3MgYWdhaW4uIHY2LjQg aGFzIG5vIGxlYWtzLgo+Pgo+PiBJIGRpZCBhIGJpc2VjdCBhbmQgZm91bmQgdGhlIGNvbW1pdCBi ZWxvdy4gSSB2ZXJpZmllZCByZXZlcnRpbmcgdGhlCj4+IGNvbW1pdCBtYWtlcyB0aGUgbGVha3Mg Z28gYXdheS4KPj4KPj4gY29tbWl0IGU1NDIyMzI3NWJhMWJjNmY3MDRhNmJhYjAxNWZjZDJhZTRm NzI1NzIKPj4gQXV0aG9yOiAgICAgUm9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJp eC5jb20+Cj4+IEF1dGhvckRhdGU6IFRodSBNYXkgMjUgMTY6MzI6NDggMjAyMyArMDEwMAo+PiBD b21taXQ6ICAgICBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgo+PiBDb21taXRE YXRlOiBGcmkgSnVuIDkgMTU6MDY6MTYgMjAyMyAtMDUwMAo+Pgo+PiAgICAgUENJOiBSZWxlYXNl IHJlc291cmNlIGludmFsaWRhdGVkIGJ5IGNvYWxlc2NpbmcKPgo+IEhpIEthbGxlLAo+Cj4gSSBj YW4ndCByZXByb2R1Y2UgdGhlIGxlYWsgYnkgbG9hZGluZy91bmxvYWRpbmcgdGhlIGF0aDExayBt b2R1bGUuIEkgc3VzcGVjdAo+IHRoYXQgdGhlIGxlYWsgaXMgYWx3YXlzIHRoZXJlIHdoZW4gUENJ IHJlc291cmNlcyBhcmUgY29hbGVzY2VkIGJ1dAo+IGttZW1sZWFrIGRvZXNuJ3Qgbm90aWNlIHVu dGlsIGF0aDExayBpcyBsb2FkZWQuCj4KPiBDYW4geW91IHBsZWFzZSB0cnkgdGhlIGZvbGxvd2lu ZyB0byBjb25maXJtIGl0IGZpeGVzIGl0PwoKSSBydW4gdmFyaW91cyB0ZXN0cyB3aXRoIHlvdXIg cGF0Y2ggYW5kIEkgZG9uJ3Qgc2VlIGxlYWtzIGFueW1vcmUuIEkKYWxzbyB2ZXJpZWQgdGhhdCB3 aXRob3V0IHlvdXIgcGF0Y2ggSSBzZWUgdGhlIGxlYWsgaW1tZWRpYXRlbHkuCgpUaGFua3MgZm9y IGZpeGluZyB0aGlzIHNvIHF1aWNrbHksIGl0IHdvdWxkIGdvb2QgdG8gaGF2ZSB0aGlzIGZpeCBp bgp2Ni42IGlmIHBvc3NpYmxlLgoKVGVzdGVkLWJ5OiBLYWxsZSBWYWxvIDxrdmFsb0BrZXJuZWwu b3JnPgoKLS0gCmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9saW51eC13aXJl bGVzcy9saXN0LwoKaHR0cHM6Ly93aXJlbGVzcy53aWtpLmtlcm5lbC5vcmcvZW4vZGV2ZWxvcGVy cy9kb2N1bWVudGF0aW9uL3N1Ym1pdHRpbmdwYXRjaGVzCgotLSAKYXRoMTFrIG1haWxpbmcgbGlz dAphdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2F0aDExawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4FCEB8FA5 for ; Wed, 6 Sep 2023 08:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbjIFIlA (ORCPT ); Wed, 6 Sep 2023 04:41:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjIFIlA (ORCPT ); Wed, 6 Sep 2023 04:41:00 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E6C68F; Wed, 6 Sep 2023 01:40:56 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D520CC433C9; Wed, 6 Sep 2023 08:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693989656; bh=33osJvMi9BkVlhAaa6FIokdBDnUZlNZzV6kbO/dmsVI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=qXSpfDQOyB1xWgYrcNz+6QSgQyCR06Yj44CINKaWehowHXiUO73ng8lfQD0d2Jpoj wqHa7F3iZl7r0mzZIOu8Npa4pa9ZU/Qqssm7fcr6nWHRkT1aH7RSDg7gUeKcVp7EH6 dZsxh/Paw9NOLeWCrgtA8ps8tS3Va+53HBzYUaQZA/oBzj/yg96aBdGgGATzXa4T/k gUQE6g+sDDTpHu4E6sRzJHM3uRN0AhxEzO0JyCErPqdh8hkiuOvDyZGiBODWbN/DJQ 02E2qr4cQGvwmYdHBbfLNm9v8oxAd2hJXhmWOn8lAYZ9ALF7QU+T3QtYGQAdcK7uXt 3ErZC2knqhscA== From: Kalle Valo To: Ross Lagerwall Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, regressions@lists.linux.dev Subject: Re: [regression v6.5-rc1] PCI: comm "swapper/0" leaking memory References: <878r9sga1t.fsf@kernel.org> Date: Wed, 06 Sep 2023 11:40:52 +0300 In-Reply-To: (Ross Lagerwall's message of "Tue, 5 Sep 2023 17:28:38 +0100") Message-ID: <87o7ifelt7.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Ross Lagerwall writes: > On Wed, Aug 30, 2023 at 10:21=E2=80=AFAM Kalle Valo wr= ote: > >> >> I noticed that starting from v6.5-rc1 my ath11k tests reported several >> memory leaks from swapper/0: >> >> unreferenced object 0xffff88810a02b7a8 (size 96): >> comm "swapper/0", pid 1, jiffies 4294671838 (age 98.120s) >> hex dump (first 32 bytes): >> 80 b8 02 0a 81 88 ff ff b8 72 07 00 00 c9 ff ff .........r...... >> c8 b7 02 0a 81 88 ff ff 00 00 00 00 00 00 00 00 ................ >> backtrace: >> unreferenced object 0xffff88810a02b880 (size 96): >> comm "swapper/0", pid 1, jiffies 4294671838 (age 98.120s) >> hex dump (first 32 bytes): >> 58 b9 02 0a 81 88 ff ff a8 b7 02 0a 81 88 ff ff X............... >> a0 b8 02 0a 81 88 ff ff 00 00 00 00 00 00 00 00 ................ >> backtrace: >> unreferenced object 0xffff88810a02b958 (size 96): >> comm "swapper/0", pid 1, jiffies 4294671838 (age 98.120s) >> hex dump (first 32 bytes): >> 30 ba 02 0a 81 88 ff ff 80 b8 02 0a 81 88 ff ff 0............... >> 78 b9 02 0a 81 88 ff ff 00 00 00 00 00 00 00 00 x............... >> backtrace: >> unreferenced object 0xffff88810a02ba30 (size 96): >> comm "swapper/0", pid 1, jiffies 4294671838 (age 98.120s) >> hex dump (first 32 bytes): >> 08 bb 02 0a 81 88 ff ff 58 b9 02 0a 81 88 ff ff ........X....... >> 50 ba 02 0a 81 88 ff ff 00 00 00 00 00 00 00 00 P............... >> backtrace: >> unreferenced object 0xffff88810a02bb08 (size 96): >> comm "swapper/0", pid 1, jiffies 4294671838 (age 98.120s) >> hex dump (first 32 bytes): >> e0 bb 02 0a 81 88 ff ff 30 ba 02 0a 81 88 ff ff ........0....... >> 28 bb 02 0a 81 88 ff ff 00 00 00 00 00 00 00 00 (............... >> backtrace: >> >> I can easily reproduce this by doing a simple insmod and rmmod of ath11k >> and it's dependencies (mac80211, MHI etc). I can reliability reproduce >> the leaks but I only see them once after a boot, I need to reboot the >> host to see the leaks again. v6.4 has no leaks. >> >> I did a bisect and found the commit below. I verified reverting the >> commit makes the leaks go away. >> >> commit e54223275ba1bc6f704a6bab015fcd2ae4f72572 >> Author: Ross Lagerwall >> AuthorDate: Thu May 25 16:32:48 2023 +0100 >> Commit: Bjorn Helgaas >> CommitDate: Fri Jun 9 15:06:16 2023 -0500 >> >> PCI: Release resource invalidated by coalescing > > Hi Kalle, > > I can't reproduce the leak by loading/unloading the ath11k module. I susp= ect > that the leak is always there when PCI resources are coalesced but > kmemleak doesn't notice until ath11k is loaded. > > Can you please try the following to confirm it fixes it? I run various tests with your patch and I don't see leaks anymore. I also veried that without your patch I see the leak immediately. Thanks for fixing this so quickly, it would good to have this fix in v6.6 if possible. Tested-by: Kalle Valo --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes