From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dongliang Mu <dzm91@hust.edu.cn>, Kalle Valo <kvalo@kernel.org>
Cc: hust-os-kernel-patches@googlegroups.com,
Dongliang Mu <dzm91@hust.edu.cn>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume
Date: Tue, 05 Sep 2023 19:33:00 +0200 [thread overview]
Message-ID: <87o7igpltf.fsf@toke.dk> (raw)
In-Reply-To: <87r0ncq1hp.fsf@toke.dk>
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> Dongliang Mu <dzm91@hust.edu.cn> writes:
>
>> In ath9k_hif_usb_resume, the error handling code calls
>> ath9k_hif_usb_dealloc_urbs twice in different paths.
>>
>> To unify the error handling code, we move the else branch before
>> the if branch and drop one level of indentation of the if branch.
>>
>> In addition, move the ret variable at the end of variable declarations
>> to be reverse x-mas tree order.
>>
>> Note that this patch does not incur any functionability change.
>>
>> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>
> So it seems this didn't make it to the lists; could you please try
> re-sending?
Never mind, it made it through now :)
-Toke
next prev parent reply other threads:[~2023-09-05 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 1:35 [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume Dongliang Mu
2023-09-05 11:19 ` Dan Carpenter
2023-09-05 11:54 ` Toke Høiland-Jørgensen
2023-09-05 17:33 ` Toke Høiland-Jørgensen [this message]
2023-09-05 17:33 ` Toke Høiland-Jørgensen
2023-09-21 8:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7igpltf.fsf@toke.dk \
--to=toke@toke.dk \
--cc=dzm91@hust.edu.cn \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.