From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06BFEEE498D for ; Fri, 18 Aug 2023 18:30:14 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 11BC8ED0; Fri, 18 Aug 2023 20:29:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 11BC8ED0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692383412; bh=jtZ2X/RvkdtuhYfAVtyuWSHUM2M2dqD+8L+e8EeZ6sQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ObDbS4nrhrLBpIb0c2goxTXRjY7FauErMX7BnaIpMy1NV4x0xcwmIPmI5FMUTDG+Y /QCOD7m/sexgUz+oQB+3OEQZN0E3WJO3NXJZ0QBaCl7Bt6NPzIMFzAPnMYrjL01K22 ZoUeQGnZfC24dPpnEHL1yulMTBH902Jakw0g6+u0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9D034F8016D; Fri, 18 Aug 2023 20:28:53 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 413E3F801EB; Fri, 18 Aug 2023 20:28:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9D95BF801EB; Fri, 18 Aug 2023 20:28:47 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D37A1F800D1 for ; Fri, 18 Aug 2023 20:28:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D37A1F800D1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xOXZ6EL9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q7K5BQDS Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 184971F74B; Fri, 18 Aug 2023 18:28:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692383317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSIOC01SNEMHZE/GJDc/41dzaL6uTedaZsYjL6U2Nt8=; b=xOXZ6EL9L/KQILtgnFXrXLJ7nr3scvjXdaYoMrmfdqP8GGRz3IYuXCY/Mf0xpq97nWnV3a cwBQj5mFC0KJJfgMEtQHvQJoTJ53dhGwiTU1864Vwt3AYlhc560umDsrtmV1ZaXVJ3a3ZF UH/5J9tp4123UCzgPJhg/CvjEsTLK9Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692383317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSIOC01SNEMHZE/GJDc/41dzaL6uTedaZsYjL6U2Nt8=; b=q7K5BQDSbkG+fmkEIz0IlVEBdBuHGd09xpgSEleIQHV2wcbZg55/ztQ4D1mYuqXbVDLLez YWjY9RKWy40TT7CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B3B0313441; Fri, 18 Aug 2023 18:28:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id M/PyKlS432RhMgAAMHmgww (envelope-from ); Fri, 18 Aug 2023 18:28:36 +0000 Date: Fri, 18 Aug 2023 20:28:36 +0200 Message-ID: <87o7j4gq7f.wl-tiwai@suse.de> From: Takashi Iwai To: Pierre-Louis Bossart Cc: Shenghao Ding , robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, kevin-lu@ti.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, mengdong.lin@intel.com, baojun.xu@ti.com, thomas.gfeller@q-drop.com, peeyush@ti.com, navada@ti.com, broonie@kernel.org, gentuser@gmail.com Subject: Re: [PATCH v4 1/2] ALSA: hda/tas2781: Add tas2781 HDA driver In-Reply-To: <87r0o0gssk.wl-tiwai@suse.de> References: <20230818085836.1442-1-shenghao-ding@ti.com> <87pm3kk63a.wl-tiwai@suse.de> <72960354-3f69-e2fa-e7b0-dc8b61ca4940@linux.intel.com> <87r0o0gssk.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 5ITSFAE7EJZEAAW24PUWR4NUOPKVKXGB X-Message-ID-Hash: 5ITSFAE7EJZEAAW24PUWR4NUOPKVKXGB X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 18 Aug 2023 19:32:43 +0200, Takashi Iwai wrote: > > On Fri, 18 Aug 2023 18:36:16 +0200, > Pierre-Louis Bossart wrote: > > > > > > > > On 8/18/23 05:17, Takashi Iwai wrote: > > > On Fri, 18 Aug 2023 10:58:35 +0200, > > > Shenghao Ding wrote: > > >> > > >> Integrate tas2781 configs for Lenovo Laptops. All of the tas2781s in the > > >> laptop will be aggregated as one audio device. The code support realtek > > >> as the primary codec. Rename "struct cs35l41_dev_name" to > > >> "struct scodec_dev_name" for all other side codecs instead of the certain > > >> one. > > >> > > >> Signed-off-by: Shenghao Ding > > > > > > Now I applied both patches to for-next branch. > > > > > > The patch 2 needed some minor adjustment in Kconfig to be applied to > > > the latest branch, but I resolved it locally. > > > > There are a number of issues I just reported, I guess they will have to > > be handled with a follow-up patch now? > > Yes, let's fix incrementally on the top. ... and since it's already merged, it means that everyone can submit patches for fixing issues there, and I'd happily apply fixes no matter who submitted them, as long as the fixes are correct ;) Takashi