From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B068EB64DC for ; Mon, 3 Jul 2023 08:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbjGCIuz (ORCPT ); Mon, 3 Jul 2023 04:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbjGCIuv (ORCPT ); Mon, 3 Jul 2023 04:50:51 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDCA010D4 for ; Mon, 3 Jul 2023 01:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688374175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=+TImfC7tK2SsSjZEh/HT3vdbJQbag2Dkm/n26z7WMho=; b=Nme9C41kSZ57gRoAj4g/SfFueSciOMPiWDxnysOxi6IIFv3ydb1J2J+aGYGQIJAYOYdiFo R39vEAy/dJLX73q4zrcnu6pJ/KrXLj8goCOtTuDJ4F4spMa3DmDiuvW7jRneOh5QEDmUbF FzDhWK41YuF4/MhD5QT3ouj7FKCNsDg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-CVnV9TlgOKuDzUKbqQpxVQ-1; Mon, 03 Jul 2023 04:49:34 -0400 X-MC-Unique: CVnV9TlgOKuDzUKbqQpxVQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3141e72a2e9so2031600f8f.2 for ; Mon, 03 Jul 2023 01:49:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688374173; x=1690966173; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+TImfC7tK2SsSjZEh/HT3vdbJQbag2Dkm/n26z7WMho=; b=Lvcg/2kt8rh0PNeVZjhFL3grwZzwrU4i6bTCPFF3mto6LX7FAHVRJpLwu0tiBy2IYX lqkdWCrXFTE+aTutylqwSmbKUKlXuniicAYZyD00IyJcTINPXuaKey9iampZ9I+Izak/ BTaWvA9iAEKAEjL0t/Y3DKtcf/jWz42C6RJMFY4OZqTs+buiFCDHOfWb4OatBxkYVRZS 9kvoFmYOWsDnM4j2Y+RjmCmf5T4icswPWRGWZ8hXZKqY+zpp1Eub1j8iDSwj5JLviL8B fGtY/liOI74/hwe95KSpjkmNUnpQYADupJFzHrULz/clWwrTX7F5BT+sH86+A0qAgdDV x/hA== X-Gm-Message-State: ABy/qLbnFiUjAG0yNewobz3mNCu/nqqbeJxkNotjq72BjdI+Zr74sKSV 8QD+yUA9hVSsZnC4BV8NhKaa6sNMauMUFqvjMUV5QccxQTrwkrQalrEsJlfIFk3Z3Gq8YNGfAKQ CYeb1pEziEqMzzN6Nt8ygNfs= X-Received: by 2002:a5d:5141:0:b0:313:e88d:e6d6 with SMTP id u1-20020a5d5141000000b00313e88de6d6mr8286635wrt.14.1688374173214; Mon, 03 Jul 2023 01:49:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGg6K8WUHE8euyn+3LOEa30xbblNJ36iK0ft7TSKaKSogN5/e+nUCA42ROWlI7aSWhx9VYj0A== X-Received: by 2002:a5d:5141:0:b0:313:e88d:e6d6 with SMTP id u1-20020a5d5141000000b00313e88de6d6mr8286616wrt.14.1688374172926; Mon, 03 Jul 2023 01:49:32 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id da16-20020a056000197000b0031274a184d5sm25157550wrb.109.2023.07.03.01.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 01:49:32 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , linux-kernel@vger.kernel.org Cc: linux-fbdev@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Greg Kroah-Hartman , Helge Deller , x86@kernel.org, dri-devel@lists.freedesktop.org, Dave Hansen , Ingo Molnar , Geert Uytterhoeven , "H. Peter Anvin" , Borislav Petkov , Thomas Gleixner , Andy Shevchenko , Sam Ravnborg Subject: Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols In-Reply-To: <04fa72f3-d6ca-bd68-7ed9-57151c1877df@suse.de> Date: Mon, 03 Jul 2023 10:49:26 +0200 Message-ID: <87o7ktz8fd.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Thomas Zimmermann writes: [...] >>>> config FB_DEVICE >>>> bool "Provide legacy /dev/fb* device" >>>> - depends on FB >>>> + select FB_CORE >>> >>> This should depend on FB_CORE. >>> >> >> Yes, already fixed in v3 too. I did a select to prevent symbol circular >> dependencies but doing that lead to CONFIG_FB_CORE=y even if CONFIG_DRM >> was set as a module. >> >> But with the "select FB_CORE if DRM_FBDEV_EMULATION" in the DRM symbol as >> Arnd suggested, I was able to have FB_DEVICE to depend on FB_CORE again. > > BTW, where does this item now show up in the menu? It used to be in the > framebuffer menu. It's now in the graphics-drivers menu? > No, it's still in the framebuffer menu. But after the FB_CORE split the menuconfig ends broken (no sub-level for fbdev drivers anymore). I was talking with Arnd and Geert about this. I think that will pause this series and instead first focus on cleaning up the fbdev Kconfig, then it should be easier to add the FB_CORE on top of that. > Best regards > Thomas > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2748BEB64DD for ; Mon, 3 Jul 2023 08:49:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4162E10E1D9; Mon, 3 Jul 2023 08:49:40 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA44D10E1D9 for ; Mon, 3 Jul 2023 08:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688374177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=+TImfC7tK2SsSjZEh/HT3vdbJQbag2Dkm/n26z7WMho=; b=c1VwygpOJBrOcP4j+EQ8TnhNQqSvGCHyhKAVvpmFUKrZ4gPVHnlvTvylE17UPaymiVDRrm 48xw7Z3FZKBeQ/Dbs9169DqMdXFL5QOSsj1fOT33/qXQT6VuSAcKC4ZZ5eLtJLCzPgf0+J R6yujP027rQFAH1WP/cJJsU6C9sO16s= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-XH80ut-_MnOn38PcH0pvJQ-1; Mon, 03 Jul 2023 04:49:34 -0400 X-MC-Unique: XH80ut-_MnOn38PcH0pvJQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31421c900b7so1806258f8f.3 for ; Mon, 03 Jul 2023 01:49:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688374173; x=1690966173; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+TImfC7tK2SsSjZEh/HT3vdbJQbag2Dkm/n26z7WMho=; b=JTI8bUCacv/CJccWPOG39AGeb8XbxMLaKMO+yqVIGLY2NDK9d1qh3s1/4Bl/FJDIc8 vuQvfiQwFTyX3aC1tU4paq8pFwIzDuNMAU8TFSIvf2YxFlP2+nWjH7KUs+PDqMUCe/l/ l5POT7nYWcArt7EZyStWq+B7Gxqf/xAZaWvSX1OP6VKo+HlwLL5DjZX7Bx3UU0Ye//em K0HxEizag70DCvz9QGJQDH9WlXOBvj/CYUlqjJSYYFS7EZzKyNiWKm50sPXa/YhncjB+ Jq4uyCBNm7wWmZ1TUUwhZxQdJAeslXPGwGJDo/bRgdjo9S1MEBIhwNptE6GGSTQrjzcw BDJg== X-Gm-Message-State: ABy/qLZZ1Qrk3MvCBeQAex1mrqlo/aC06+50zn4roO3SHEP434p8XFhV G56iluZX1q52bkFUGv3PtV8uF50pSalHgr/w7c3kbM1vFl6Qp8rYD4CpT3Kx4N5TUtGKZXiEFZW vOpIYM5dZ3qq3h7LJ3yU2WmyrRRov X-Received: by 2002:a5d:5141:0:b0:313:e88d:e6d6 with SMTP id u1-20020a5d5141000000b00313e88de6d6mr8286638wrt.14.1688374173214; Mon, 03 Jul 2023 01:49:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGg6K8WUHE8euyn+3LOEa30xbblNJ36iK0ft7TSKaKSogN5/e+nUCA42ROWlI7aSWhx9VYj0A== X-Received: by 2002:a5d:5141:0:b0:313:e88d:e6d6 with SMTP id u1-20020a5d5141000000b00313e88de6d6mr8286616wrt.14.1688374172926; Mon, 03 Jul 2023 01:49:32 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id da16-20020a056000197000b0031274a184d5sm25157550wrb.109.2023.07.03.01.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 01:49:32 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols In-Reply-To: <04fa72f3-d6ca-bd68-7ed9-57151c1877df@suse.de> Date: Mon, 03 Jul 2023 10:49:26 +0200 Message-ID: <87o7ktz8fd.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Greg Kroah-Hartman , Helge Deller , x86@kernel.org, dri-devel@lists.freedesktop.org, Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Borislav Petkov , Geert Uytterhoeven , Thomas Gleixner , Andy Shevchenko , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thomas Zimmermann writes: [...] >>>> config FB_DEVICE >>>> bool "Provide legacy /dev/fb* device" >>>> - depends on FB >>>> + select FB_CORE >>> >>> This should depend on FB_CORE. >>> >> >> Yes, already fixed in v3 too. I did a select to prevent symbol circular >> dependencies but doing that lead to CONFIG_FB_CORE=y even if CONFIG_DRM >> was set as a module. >> >> But with the "select FB_CORE if DRM_FBDEV_EMULATION" in the DRM symbol as >> Arnd suggested, I was able to have FB_DEVICE to depend on FB_CORE again. > > BTW, where does this item now show up in the menu? It used to be in the > framebuffer menu. It's now in the graphics-drivers menu? > No, it's still in the framebuffer menu. But after the FB_CORE split the menuconfig ends broken (no sub-level for fbdev drivers anymore). I was talking with Arnd and Geert about this. I think that will pause this series and instead first focus on cleaning up the fbdev Kconfig, then it should be easier to add the FB_CORE on top of that. > Best regards > Thomas > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat