From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id c13-20020adfe74d000000b0030ae499da59sm903980wrn.111.2023.06.29.06.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 06:47:49 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DB4341FFBB; Thu, 29 Jun 2023 14:47:48 +0100 (BST) References: <20230627160943.2956928-1-alex.bennee@linaro.org> <20230627160943.2956928-16-alex.bennee@linaro.org> User-agent: mu4e 1.11.7; emacs 29.0.92 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Cc: qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Juan Quintela , Thomas Huth , Cleber Rosa , Leonardo Bras , Beraldo Leal , Peter Maydell , Bin Meng , Yanan Wang , Darren Kenny , Alexander Bulekov , Marcel Apfelbaum , Peter Xu , Radoslaw Biernacki , Laurent Vivier , Paolo Bonzini , Eduardo Habkost , qemu-arm@nongnu.org, Stefan Hajnoczi , Bandan Das , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Alexandre Iooss , Marcin Juszkiewicz , Leif Lindholm , Laurent Vivier , Qiuhao Li , Mahmoud Mandour , Riku Voipio Subject: Re: [PATCH v3 15/36] tests/docker: convert riscv64-cross to lcitool Date: Thu, 29 Jun 2023 14:47:44 +0100 In-reply-to: Message-ID: <87o7kyxtvf.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: cYBpRhhlqugk Richard Henderson writes: > On 6/27/23 18:09, Alex Benn=C3=A9e wrote: >> --- a/tests/lcitool/projects/qemu-minimal.yml >> +++ b/tests/lcitool/projects/qemu-minimal.yml >> @@ -4,6 +4,8 @@ packages: >> - bash >> - bc >> - bison >> + - ccache >> + - findutils >> - flex >> - g++ >> - gcc >> @@ -21,3 +23,5 @@ packages: >> - pkg-config >> - python3 >> - python3-venv >> + - sed >> + - tar > > Same comment as against v2: Why not squash this patch with previous, > which adds qemu-minimal.yml. Especially since you're changing it here > in the next patch. Done. --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro