Re: [Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 26 Jun 2023, Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> wrote:
> Currently we do not check if there is enough bandwidth for
> audio, and what channels and freq it can really support.
> Also sometimes there can be HW constraints e.g. GLK where audio
> channels supported are only 2.
>
> https://patchwork.freedesktop.org/series/107647/
>
> Obtain the optimal audio rate and channel based on available display
> timing constraints.
>
> This can be achieved by:
> - Retrieve the supported channel and rate information from SADs
> - Adding audio-related config parameters in the CRTC state, such
> as audio support, rate, and channel.
> - Initializing the audio config parameters with the maximum supported
> rate and channel by the audio source.
> - Computing the SADs based on the audio source's capabilities.

Please don't send so many iterations of the series consecutively. And
please add the version in the subject.

I've given feedback on the previous posting, and won't give further
feedback on this thread.

BR,
Jani.


>
> Mitul Golani (3):
>   drm/i915/hdmi: Optimize source audio parameter handling
>   drm/i915/display: Configure and initialize HDMI audio capabilities
>   drm/i915/display: Add wrapper to Compute SAD
>
>  drivers/gpu/drm/i915/display/g4x_dp.c         |  4 +-
>  drivers/gpu/drm/i915/display/g4x_hdmi.c       | 16 ++--
>  drivers/gpu/drm/i915/display/intel_audio.c    | 75 ++++++++++++++++++-
>  drivers/gpu/drm/i915/display/intel_audio.h    |  4 +
>  drivers/gpu/drm/i915/display/intel_cdclk.c    |  6 +-
>  .../drm/i915/display/intel_crtc_state_dump.c  |  4 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  2 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |  4 +-
>  .../drm/i915/display/intel_display_types.h    | 12 ++-
>  drivers/gpu/drm/i915/display/intel_dp.c       |  2 +-
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |  2 +-
>  drivers/gpu/drm/i915/display/intel_hdmi.c     | 38 +++++++++-
>  drivers/gpu/drm/i915/display/intel_hdmi.h     |  1 +
>  drivers/gpu/drm/i915/display/intel_sdvo.c     | 10 +--
>  14 files changed, 148 insertions(+), 32 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center