From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13BEBDF5C; Wed, 21 Jun 2023 11:18:04 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06B7C184; Wed, 21 Jun 2023 04:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346282; x=1718882282; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=UwWPAw+/N37hMw7X+nGZKpKlbKMwdZwvU+RQSpoKtcCgHwAHlhG1R0Bz mdQuYCMMNAaFMEkH7GrE4t3WUk2LY/5Pcnf2XGALDNK9RwMDVImCbKHMg qoOzDu8Gcpxdq/rZVd9n7TljpxDRVX4QNw/YfVDT6F30txm34vFMxXfrb KOm3AeOH23cSslUWfXulopUv1Ymrabi373RGtL5NwNXUaKveRfwRjWum2 5UHnjpMjtR78BKPbQg5XHQQBYzvRvOHoG3xnfMxW2NmjyCJbH96j0tEg6 nOjpaqQe/fp4wEK6ZzsCO4YL+JCONvGwpYn8qdpKeL2Pwdr9aQXiY+jDK Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="339758007" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="339758007" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:17:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="664623042" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="664623042" Received: from unknown (HELO localhost) ([10.237.66.162]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:16:58 -0700 From: Jani Nikula To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , coda@cs.cmu.edu, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen Cc: Joel Granados , Nicholas Piggin , Christophe Leroy , Christian Borntraeger , Sven Schnelle , "H. Peter Anvin" , "Rafael J. Wysocki" , Mike Travis , Oleksandr Tyshchenko , Amir Goldstein , Matthew Bobrowski , John Fastabend , Martin KaFai Lau , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Stephen Boyd , Miaohe Lin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-cachefs@redhat.com, codalist@coda.cs.cmu.edu, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, fsverity@lists.linux.dev, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-hams@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, dccp@vger.kernel.org, linux-wpan@vger.kernel.org, mptcp@lists.linux.dev, lvs-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-afs@lists.infradead.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-x25@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-ID: <87o7l92hg8.fsf@intel.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org F3FD841D7B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4917F418E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346281; x=1718882281; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=HLDgmo/Az6NkgE+D6yL5JMGr2Pp1WVOXbzcdpTFcOQWQMf1scnfKLRsK qcM0pd7y57FmT0H91DPqWk/q3XD7rX73oC4LMk6bQoLGXYxSMfup3x+4N u+WxV2MaqV3ul8KHLuA9plVHlezkS4MxGbiBl56QdBEOxmpsWBotktuca 1xdZUEokxzpOa1y613kxEP3qDv8IBNz03kQMGCsX5X+kKPRaDc8gVBYhs +S035kDarl9rPtjkZEcerIWYUyk2WSAqBMihZ6zJ/jOZbz7HwjJi8AZ7S C5jtYbzTsaaZjtqBaFJpsTIWQ8LaVFEIU8hI731ciYI0TuD88/0uS6qjA Q==; From: Jani Nikula In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-ID: <87o7l92hg8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Bridge] [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , coda@cs.cmu.edu, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen Cc: Joel Granados , Miaohe Lin , linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, "Rafael J. Wysocki" , linux-aio@kvack.org, Amir Goldstein , mptcp@lists.linux.dev, KP Singh , dri-devel@lists.freedesktop.org, Ben Segall , linux-mm@kvack.org, linux-sctp@vger.kernel.org, keyrings@vger.kernel.org, Stanislav Fomichev , "H. Peter Anvin" , linux-afs@lists.infradead.org, linux-s390@vger.kernel.org, Valentin Schneider , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org, John Fastabend , linux-ntfs-dev@lists.sourceforge.net, Christophe Leroy , codalist@coda.cs.cmu.edu, lvs-devel@vger.kernel.org, Matthew Bobrowski , linux-cachefs@redhat.com, Mel Gorman , tipc-discussion@lists.sourceforge.net, Yonghong Song , Christian Borntraeger , intel-gfx@lists.freedesktop.org, linux-crypto@vger.kernel.org, linux-wpan@vger.kernel.org, coreteam@netfilter.org, John Ogness , Mike Travis , Boqun Feng , apparmor@lists.ubuntu.com, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , rds-devel@oss.oracle.com, linux-raid@vger.kernel.org, Waiman Long , linux-hams@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, fsverity@lists.linux.dev, Hao Luo , linux-nfs@vger.kernel.org, Will Drewry , linux-x25@vger.kernel.org, Stephen Boyd , Daniel Bristot de Oliveira , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Lutomirski , linux-xfs@vger.kernel.org, Oleksandr Tyshchenko , linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org, Sven Schnelle , Jiri Olsa , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Martin KaFai Lau , ocfs2-devel@oss.oracle.com On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Wed, 21 Jun 2023 11:16:55 +0000 Subject: Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays Message-Id: <87o7l92hg8.fsf@intel.com> List-Id: References: <20230621094817.433842-1-j.granados@samsung.com> In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA663EB64D9 for ; Tue, 27 Jun 2023 14:39:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C091D10E34B; Tue, 27 Jun 2023 14:39:13 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0C4710E04B; Wed, 21 Jun 2023 11:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346281; x=1718882281; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=HLDgmo/Az6NkgE+D6yL5JMGr2Pp1WVOXbzcdpTFcOQWQMf1scnfKLRsK qcM0pd7y57FmT0H91DPqWk/q3XD7rX73oC4LMk6bQoLGXYxSMfup3x+4N u+WxV2MaqV3ul8KHLuA9plVHlezkS4MxGbiBl56QdBEOxmpsWBotktuca 1xdZUEokxzpOa1y613kxEP3qDv8IBNz03kQMGCsX5X+kKPRaDc8gVBYhs +S035kDarl9rPtjkZEcerIWYUyk2WSAqBMihZ6zJ/jOZbz7HwjJi8AZ7S C5jtYbzTsaaZjtqBaFJpsTIWQ8LaVFEIU8hI731ciYI0TuD88/0uS6qjA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="339758038" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="339758038" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:17:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="664623042" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="664623042" Received: from unknown (HELO localhost) ([10.237.66.162]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:16:58 -0700 From: Jani Nikula To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , coda@cs.cmu.edu, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-ID: <87o7l92hg8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Tue, 27 Jun 2023 14:38:30 +0000 Subject: Re: [Intel-gfx] [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joel Granados , Miaohe Lin , linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, "Rafael J. Wysocki" , linux-aio@kvack.org, Amir Goldstein , mptcp@lists.linux.dev, KP Singh , dri-devel@lists.freedesktop.org, Ben Segall , linux-mm@kvack.org, linux-sctp@vger.kernel.org, keyrings@vger.kernel.org, Stanislav Fomichev , "H. Peter Anvin" , linux-afs@lists.infradead.org, linux-s390@vger.kernel.org, Valentin Schneider , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org, John Fastabend , linux-ntfs-dev@lists.sourceforge.net, Christophe Leroy , codalist@coda.cs.cmu.edu, lvs-devel@vger.kernel.org, Matthew Bobrowski , linux-cachefs@redhat.com, Mel Gorman , tipc-discussion@lists.sourceforge.net, Yonghong Song , Christian Borntraeger , intel-gfx@lists.freedesktop.org, linux-crypto@vger.kernel.org, linux-wpan@vger.kernel.org, coreteam@netfilter.org, John Ogness , Mike Travis , Boqun Feng , apparmor@lists.ubuntu.com, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , rds-devel@oss.oracle.com, linux-raid@vger.kernel.org, Waiman Long , linux-hams@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, fsverity@lists.linux.dev, Hao Luo , linux-nfs@vger.kernel.org, Will Drewry , linux-x25@vger.kernel.org, Stephen Boyd , Daniel Bristot de Oliveira , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Lutomirski , linux-xfs@vger.kernel.org, Oleksandr Tyshchenko , linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org, Sven Schnelle , Jiri Olsa , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Martin KaFai Lau , ocfs2-devel@oss.oracle.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-ID: <87o7l92hg8.fsf@intel.com> References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346282; x=1718882282; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=UwWPAw+/N37hMw7X+nGZKpKlbKMwdZwvU+RQSpoKtcCgHwAHlhG1R0Bz mdQuYCMMNAaFMEkH7GrE4t3WUk2LY/5Pcnf2XGALDNK9RwMDVImCbKHMg qoOzDu8Gcpxdq/rZVd9n7TljpxDRVX4QNw/YfVDT6F30txm34vFMxXfrb KOm3AeOH23cSslUWfXulopUv1Ymrabi373RGtL5NwNXUaKveRfwRjWum2 5UHnjpMjtR78BKPbQg5XHQQBYzvRvOHoG3xnfMxW2NmjyCJbH96j0tEg6 nOjpaqQe/fp4wEK6ZzsCO4YL+JCONvGwpYn8qdpKeL2Pwdr9aQXiY+jDK Q==; In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter <> Cc: Joel Granados , Nicholas Piggin , Christophe Leroy , Christian Borntraeger , Sven Schnelle , "H. Peter Anvin" , "Rafael J. Wysocki" , Mike Travis , Oleksandr Tyshchenko , Amir Goldstein , Matthew Bobrowski , John Fastabend , Martin KaFai Lau , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc255.phx1.oracleemaildelivery.com (aib29ajc255.phx1.oracleemaildelivery.com [192.29.103.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34FC5EB64D8 for ; Wed, 21 Jun 2023 16:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=52IxTfg6LENuevF0oB7JrZBvlSqVCHr4JqptpQj0qG8=; b=k127nSZlL9SnIyZPLcFtaeMD0RWtacDE8hk1zN3bu46VBcjxjcwnkqKyTfAjWbkSJ5j63THrptem ASuyoee/TRYRDMmJJxRSqqOjYmC5GrNGYYBo5DXjGSNcwOfIEMKSj2WnnRiM8A4vy62loNljYYhH FFkBtTOrUNf80uuvThuTJ4L6QgAjgvnHSAnDH51u0Bs2rghT0/qzMipy60QrUA+Q2OD49IZyvQfu IigGOHIn0uIbgLPQurRNOCyINL+pz1ODfgAsekyoYl/8OJv8fkZLmQHUTeuiVAb6Z+iyllPq3jpi 5AL6i53kt4SClxblE1FfIWVTxPWp0FzEP6Uusw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=52IxTfg6LENuevF0oB7JrZBvlSqVCHr4JqptpQj0qG8=; b=PzkljMti08URJMDmcaUUVNCBXhEjsnvrkyfMMhmYw+qB9i+zAZ9MfKlvUHJPNPuSs8H/ia+UXtmU 9LrWb4iW1Dnwz71pr4AjbYXeFePY6XYTR6FLFdXMSEc21BreXDgYhJlljV8m7xMtaFSDT/B+lu2b dpXb022VGhzfMs/B0fGCynZbH/f36v5W/3ql+5IC3uk1lJJnZ2Nz4vvNPwXS5XqpeO1GB/Rxm46m TOZaOPOsA3UZmTS0bjwchbAt99S0+5MOWvnmb6O29lL3eGFj5WJ5FPP0PCJ77xMyRK+12oCZTXrJ KB2RyDpOkA687V2Wg/lwWgLfO9+MxVy8JGxZEA== Received: by omta-ad3-fd3-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20230523 64bit (built May 23 2023)) with ESMTPS id <0RWM00GGN23RGR20@omta-ad3-fd3-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Wed, 21 Jun 2023 16:07:03 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346280; x=1718882280; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=ApPnOFBrcbHpM84lXIkCPfg0CKRe5U6lh5Egd+pmdnRJ053x/pZmvifj L9zQN5xw2jTVPSHtNLsCbwOH0EXE++jHjHqeMprK8V8AqJE/2pLM3qkU5 bALMAYsUgD5vnw66cPikASRkto+gmSlghN+No+2l/uWrnzUEy7YCaIj5a oJrW5uJ5gravNGKNq1OrCs1BpmI3e0qmDedn4A6Wx79EKERJzh21rZGRU pOTLzK6VGxhg4OIluix62/F+WZ32hqFp2o4ef9X7p4vrjnjtP4fOVkud0 LX5EF4FhtdKluO7APTGGBlDqPv1Yq7LxlvCI37Z0vJTlkIA+/zH2gKuPw w==; To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , coda@cs.cmu.edu, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen In-reply-to: <20230621094817.433842-1-j.granados@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-id: <87o7l92hg8.fsf@intel.com> MIME-version: 1.0 X-Source-IP: 192.55.52.136 X-Proofpoint-Virus-Version: vendor=nai engine=6500 definitions=10747 signatures=596816 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 malwarescore=0 priorityscore=202 impostorscore=0 clxscore=284 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=641 adultscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306210094 domainage_hfrom=13602 Cc: Joel Granados , Miaohe Lin , linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, "Rafael J. Wysocki" , linux-aio@kvack.org, Amir Goldstein , mptcp@lists.linux.dev, KP Singh , dri-devel@lists.freedesktop.org, Ben Segall , linux-mm@kvack.org, linux-sctp@vger.kernel.org, keyrings@vger.kernel.org, Stanislav Fomichev , "H. Peter Anvin" , linux-afs@lists.infradead.org, linux-s390@vger.kernel.org, Valentin Schneider , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org, John Fastabend , linux-ntfs-dev@lists.sourceforge.net, Christophe Leroy , codalist@coda.cs.cmu.edu, lvs-devel@vger.kernel.org, Matthew Bobrowski , linux-cachefs@redhat.com, Mel Gorman , tipc-discussion@lists.sourceforge.net, Yonghong Song , Christian Borntraeger , intel-gfx@lists.freedesktop.org, linux-crypto@vger.kernel.org, linux-wpan@vger.kernel.org, coreteam@netfilter.org, John Ogness , Mike Travis , Boqun Feng , apparmor@lists.ubuntu.com, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , rds-devel@oss.oracle.com, linux-raid@vger.kernel.org, Waiman Long , linux-hams@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, fsverity@lists.linux.dev, Hao Luo , linux-nfs@vger.kernel.org, Will Drewry , linux-x25@vger.kernel.org, Stephen Boyd , Daniel Bristot de Oliveira , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Lutomirski , linux-xfs@vger.kernel.org, Oleksandr Tyshchenko , linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org, Sven Schnelle , Jiri Olsa , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Martin KaFai Lau , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jani Nikula via Ocfs2-devel Reply-to: Jani Nikula Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit Errors-to: ocfs2-devel-bounces@oss.oracle.com X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="339757987" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="339757987" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="664623042" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="664623042" X-ServerName: mga12.intel.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:_spf.intel.com -all X-Spam: Clean X-Proofpoint-ORIG-GUID: AoxsWRc1oW1fhQhnUDsRX8F4Ig_LQ3O0 X-Proofpoint-GUID: AoxsWRc1oW1fhQhnUDsRX8F4Ig_LQ3O0 X-Mailman-Approved-At: Wed, 21 Jun 2023 16:07:01 +0000 Reporting-Meta: AAHJUWYrXSBVZXvJTWkXH4EPs7V7RGtvVe3Ceq/Ks6PJSx8e0xD5hQvotON6KA1x FVPJkQe9oSIaPOHsS//NPZvVrnbgtSiY1wVhjQ72QkFy4J673uhNSTmeTbG4Fv3y lZv9KTC7/8T2K8SorVwAbUd9ezsuEfJbAaC8kWkNuwkIurpcpK+qlpUtXgbYtPNy 5cmLwg5S+EY9Dhkhs2s/WpncmdErumBdxQ4H9qNPLI3/pUDsf1RRK3z+b2pRwhdn vsYGFArr4Y3DhkveAApl7+0i7WsXOgAPHlTjEo5YzPTbxiq4Oxe5OoVCKMu4PxIZ eXBI6GRY7SVLHrE2zPyEKyB+kQQht89v6cMa+wK+lP2oLy/Xk3kQNUAZYw/KoUKR dlHgfMKQV7xSmA2PdChCWzas3qUxTZTf6Y1GdYu55EstzgIjLI3qCHO+he828H6J GjSqcQVYMCHUxGYgca6yOl5x5MfvdkAB5Wi0rkcyhM0VGuAlC2BMK80KhiLdVmAF w+zkaEPiarUkuF/JaKpEAf4x0b1zgClxjMYAAoLrGA== On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E5A2EB64D8 for ; Wed, 21 Jun 2023 18:41:49 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Uei1MveJ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QmXQz5BV5z3clJ for ; Thu, 22 Jun 2023 04:41:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Uei1MveJ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=jani.nikula@intel.com; receiver=lists.ozlabs.org) X-Greylist: delayed 63 seconds by postgrey-1.37 at boromir; Wed, 21 Jun 2023 21:19:32 AEST Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QmLch3sltz30gj for ; Wed, 21 Jun 2023 21:19:32 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346371; x=1718882371; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=Uei1MveJMp2Vc4hvl3dMT9qrG90Odr4K+g0mrXZu3dL8AXgC+wmUTqIr LGyS6KjpPhpq+g7joMOihT1PUYG7DzlNXfOA5rhLjExMwtme9vzHx7wNP WgSYVuVsaErT/nF/O8gxKANXs4wyONn64QJygHrgFw8+kwAQU2my7CE/9 J+vVN6UGOB2t+67YCJfynsQ/mjAXD2O+eu+qm8+ayJfTJQnsugCQK2WmU ANZnRW3jvNBo0z8BVeUPSeS2istw+RMOKWMwf2hzrIu6L/Xb7c2pYMVwt YLMNCocZA0dLZO2vXq5RxVtVwKmtwINcn9hTeLaRckqIhacvs2d7NH/Fw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="339757998" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="339757998" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:17:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="664623042" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="664623042" Received: from unknown (HELO localhost) ([10.237.66.162]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:16:58 -0700 From: Jani Nikula To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , coda@cs.cmu.edu, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen Subject: Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-ID: <87o7l92hg8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Thu, 22 Jun 2023 04:32:35 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joel Granados , Miaohe Lin , linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, "Rafael J. Wysocki" , linux-aio@kvack.org, Amir Goldstein , mptcp@lists.linux.dev, KP Singh , dri-devel@lists.freedesktop.org, Ben Segall , linux-mm@kvack.org, linux-sctp@vger.kernel.org, keyrings@vger.kernel.org, Stanislav Fomichev , "H. Peter Anvin" , linux-afs@lists.infradead.org, linux-s390@vger.kernel.org, Valentin Schneider , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org, John Fastabend , linux-ntfs-dev@lists.sourceforge.net, codalist@coda.cs.cmu.edu, lvs-devel@vger.kernel.org, Matthew Bobrowski , linux-cachefs@redhat.com, Mel Gorman , tipc-discussion@lists.sourceforge.net, Yonghong Song , Christian Borntraeger , intel-gfx@lists.freedesktop.org, linux-crypto@vger.kernel.org, linux-wpan@vger.kernel.org, coreteam@netfilter.org, John Ogness , Mike Travis , Boqun Feng , apparmor@lists.ubuntu.com, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , rds-devel@oss.oracle.com, linux-raid@vger.kernel.org, Waiman Long , linux-hams@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, fsverity@lists.linux.dev, Hao Luo , linux-nfs@vger.kernel.org, Will Drewry , linux-x25@vger.kernel.org, Stephen Boyd , Daniel Bristot de Oliveira , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Lutomirski , linux-xfs@vger.kernel.org, Oleksandr Tyshchenko , linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org, Sven Schnelle , Jiri Olsa , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Martin KaFai Lau , ocfs2-devel@oss.oracle.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAB7CEB64D8 for ; Thu, 22 Jun 2023 07:33:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB99210E4F8; Thu, 22 Jun 2023 07:32:58 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0C4710E04B; Wed, 21 Jun 2023 11:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346281; x=1718882281; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=HLDgmo/Az6NkgE+D6yL5JMGr2Pp1WVOXbzcdpTFcOQWQMf1scnfKLRsK qcM0pd7y57FmT0H91DPqWk/q3XD7rX73oC4LMk6bQoLGXYxSMfup3x+4N u+WxV2MaqV3ul8KHLuA9plVHlezkS4MxGbiBl56QdBEOxmpsWBotktuca 1xdZUEokxzpOa1y613kxEP3qDv8IBNz03kQMGCsX5X+kKPRaDc8gVBYhs +S035kDarl9rPtjkZEcerIWYUyk2WSAqBMihZ6zJ/jOZbz7HwjJi8AZ7S C5jtYbzTsaaZjtqBaFJpsTIWQ8LaVFEIU8hI731ciYI0TuD88/0uS6qjA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="339758038" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="339758038" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:17:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="664623042" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="664623042" Received: from unknown (HELO localhost) ([10.237.66.162]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 04:16:58 -0700 From: Jani Nikula To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , coda@cs.cmu.edu, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen Subject: Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-ID: <87o7l92hg8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Thu, 22 Jun 2023 07:32:28 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joel Granados , Miaohe Lin , linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, "Rafael J. Wysocki" , linux-aio@kvack.org, Amir Goldstein , mptcp@lists.linux.dev, KP Singh , dri-devel@lists.freedesktop.org, Ben Segall , linux-mm@kvack.org, linux-sctp@vger.kernel.org, keyrings@vger.kernel.org, Stanislav Fomichev , "H. Peter Anvin" , linux-afs@lists.infradead.org, linux-s390@vger.kernel.org, Valentin Schneider , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org, John Fastabend , linux-ntfs-dev@lists.sourceforge.net, Christophe Leroy , codalist@coda.cs.cmu.edu, lvs-devel@vger.kernel.org, Matthew Bobrowski , linux-cachefs@redhat.com, Mel Gorman , tipc-discussion@lists.sourceforge.net, Yonghong Song , Christian Borntraeger , intel-gfx@lists.freedesktop.org, linux-crypto@vger.kernel.org, linux-wpan@vger.kernel.org, coreteam@netfilter.org, John Ogness , Mike Travis , Boqun Feng , apparmor@lists.ubuntu.com, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , rds-devel@oss.oracle.com, linux-raid@vger.kernel.org, Waiman Long , linux-hams@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, fsverity@lists.linux.dev, Hao Luo , linux-nfs@vger.kernel.org, Will Drewry , linux-x25@vger.kernel.org, Stephen Boyd , Daniel Bristot de Oliveira , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Lutomirski , linux-xfs@vger.kernel.org, Oleksandr Tyshchenko , linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org, Sven Schnelle , Jiri Olsa , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Martin KaFai Lau , ocfs2-devel@oss.oracle.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center