From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH 5/5] tests/tcg/aarch64: Rename bti-crt.inc.c -> bti-crt.c.inc
Date: Tue, 06 Jun 2023 18:05:20 +0100 [thread overview]
Message-ID: <87o7lsh67f.fsf@linaro.org> (raw)
In-Reply-To: <20230606141252.95032-6-philmd@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Since commit 139c1837db ("meson: rename included C source files
> to .c.inc"), QEMU standard procedure for included C files is to
> use *.c.inc.
>
> Besides, since commit 6a0057aa22 ("docs/devel: make a statement
> about includes") this is documented as the Coding Style:
>
> If you do use template header files they should be named with
> the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
> being included for expansion.
>
> Therefore rename 'bti-crt.inc.c' as 'bti-crt.c.inc'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-06-06 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:12 [PATCH 0/5] misc: Enforce .[ch].inc extension for re-included .c/.h files Philippe Mathieu-Daudé
2023-06-06 14:12 ` [PATCH 1/5] bsd-user: Rename elfcore.c -> elfcore.c.inc Philippe Mathieu-Daudé
2023-06-06 14:29 ` Richard Henderson
2023-06-06 18:08 ` Warner Losh
2023-06-06 19:08 ` Philippe Mathieu-Daudé
2023-06-06 14:12 ` [PATCH 2/5] target/arm: Rename helper template headers as '.h.inc' Philippe Mathieu-Daudé
2023-06-06 14:37 ` Richard Henderson
2023-06-06 15:49 ` Philippe Mathieu-Daudé
2023-06-06 15:55 ` Peter Maydell
2023-06-06 16:31 ` Richard Henderson
2023-06-06 14:12 ` [PATCH 3/5] target/i386: " Philippe Mathieu-Daudé
2023-06-06 14:38 ` Richard Henderson
2023-06-06 14:12 ` [PATCH 4/5] target: Rename per-target 'helper.h' -> 'helper.h.inc' Philippe Mathieu-Daudé
2023-06-06 14:43 ` Richard Henderson
2023-06-08 6:46 ` Philippe Mathieu-Daudé
2023-06-06 14:12 ` [PATCH 5/5] tests/tcg/aarch64: Rename bti-crt.inc.c -> bti-crt.c.inc Philippe Mathieu-Daudé
2023-06-06 14:29 ` Richard Henderson
2023-06-06 17:05 ` Alex Bennée [this message]
2023-06-06 17:02 ` [PATCH 0/5] misc: Enforce .[ch].inc extension for re-included .c/.h files Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7lsh67f.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.