From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9013C7EE23 for ; Mon, 5 Jun 2023 07:47:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 94CFE83E; Mon, 5 Jun 2023 09:46:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 94CFE83E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1685951230; bh=0fnpx5CN4eQxyPW5GMI2cnvOgD/kMqVV/lvb+O+fxQo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=UoPpH3ZQeJGsIoNrsEw7zNLOHZvEOwncir3a1KTAZWhmrDYGmHbKWRBUArTOdLDq6 UNjYLZAq3EHAT7CQ2fJw9szcufi+PCLNa0f5GJMQBAvvNtoK2DeTpDoATXkSYioPQf aDkiQ2kYJ3G1AM/EHHkJbQ/0K3Pj5CXKxx1urHds= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1FEB2F80199; Mon, 5 Jun 2023 09:46:10 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 426B8F8016C; Mon, 5 Jun 2023 09:46:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 59E96F8016C; Mon, 5 Jun 2023 09:46:06 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A3B06F80130 for ; Mon, 5 Jun 2023 09:46:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A3B06F80130 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=czChibNB; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=p/ctsSfP Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 349C321B24; Mon, 5 Jun 2023 07:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685951160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KCiBgo7Tff3DxtHsnVuCDVDp2cOHWwgyp4qryvGmLBU=; b=czChibNB6dS1UQW97KmKgZh6Tkw/Rdb+tAkHCogriGPD6K2hmI7pviLNmcQb4VAZSgTs1D 4Yfe8ouIuj7jrn/P1U8ZdGCBJrpWqpkIFbX6KyTml9FJj4D0fRkjSKo2P/5CVxCHVf5jf2 9uc1VXuJNFeA29bS7TfJYImwsi8OouY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685951160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KCiBgo7Tff3DxtHsnVuCDVDp2cOHWwgyp4qryvGmLBU=; b=p/ctsSfP7DEJ9p96CDV69bmqNfLV5NsyzNNRWd964tPt2ewDYut1hYVt9V3dhtxMMnmKHt fn9AewiTSAv/nbDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F3E10139C7; Mon, 5 Jun 2023 07:45:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aNtuOreSfWRCdAAAMHmgww (envelope-from ); Mon, 05 Jun 2023 07:45:59 +0000 Date: Mon, 05 Jun 2023 09:45:59 +0200 Message-ID: <87o7luic7c.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , , , Subject: Re: [PATCH v4 00/12] ALSA: hda: Adding support for CS35L56 on HDA systems In-Reply-To: <20230601154731.3210572-1-rf@opensource.cirrus.com> References: <20230601154731.3210572-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: H3LKOXHSYAAIZ7HF3OQAGNEMVVIQ2HER X-Message-ID-Hash: H3LKOXHSYAAIZ7HF3OQAGNEMVVIQ2HER X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 01 Jun 2023 17:47:19 +0200, Richard Fitzgerald wrote: > > This set of patches adds support for using the CS35L56 boosted smart > amplifier on HDA systems. In these systems the CS35L56 audio is > routed through a HDA-to-I2S bridge codec. > > This doesn't include the changes to the Realtek driver to actually hook > up the CS35L56 driver, because we don't yet have the QUIRK IDs to > associate it with. But we want to publish the driver now so that it is > available for bringing up hardware with the CS35L56. > > The first 9 patches are moving code out of the ASoC driver and into the > shared library so that it can be shared with the HDA driver. > > Patch #10 fixes missing #includes in the HDA headers so that the CS35L56 > driver doesn't have to #include headers that it doesn't use. > > Finally, #11 and #12 actually add the support for CS35L56 on HDA. > > CHANGES SINCE V3 > Patch 01: > - Fix double-free of IRQ caused by passing wrong cookie to devm_irq_free() > Patch 12: > - Fix memory leak of struct firmware object and firmware name strings. > - Find and open firmware files before taking the irq_lock mutex and pm_runtime. > - Don't bother executing the firmware loading code if no firmware files were > found. > > Richard Fitzgerald (4): > ASoC: cs35l56: Move runtime suspend/resume to shared library > ASoC: cs35l56: Move cs_dsp init into shared library > ASoC: cs35l56: Move part of cs35l56_init() to shared library > ALSA: hda: Fix missing header dependencies > > Simon Trimmer (8): > ASoC: cs35l56: Move shared data into a common data structure > ASoC: cs35l56: Make cs35l56_system_reset() code more generic > ASoC: cs35l56: Convert utility functions to use common data structure > ASoC: cs35l56: Move utility functions to shared file > ASoC: cs35l56: Make common function for control port wait > ASoC: cs35l56: Make a common function to shutdown the DSP > ALSA: hda: Add mute_hook to hda_component > ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier It'd be likely easier to merge all those via ASoC tree, I suppose, as some patches seem to have prerequisite in the recent ASoC changes. So, Mark, could you take those through yours? Feel free to put my ack: Reviewed-by: Takashi Iwai thanks, Takashi