From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F024C74A5B for ; Tue, 21 Mar 2023 08:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bVABakuC9OASaxuShRDqrJ58UbV2qbAr+XFAf9ZboT4=; b=rcI6eQP4cIRAbI UGpbqsB9gLr7bMRWMMNgitZC3mQYNRuVAL5ryRKD3BHasMdyu28/RZu6KsxdmY8yRGOcB6lxSf+fX tCL5ciRY9aYZK20uPqEL6HeJHe8oFAr0uXNDBBSa0cYDlzBImM9SxMRtsrWn73U0DIBZqD2eT6mVQ PsZYOZVQ4AzTQWd4Rwbpf+R77Xi49cxwUfNP3YgSOBCs5BYH9vE6O0NX2aCJLnr9ZShj34NA5Z/9M Ap6HN4v9vRCTBkW4kVbrbl0tE7t80YRXsAT5yK9XH4E1qHBQlKgaoXSyhUrhewRsxrAMCQ04/oUq4 ysIPF+ivsk3GVT4qa7vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peWuJ-00Bbld-2a; Tue, 21 Mar 2023 07:59:47 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peWuH-00Bbl2-0i for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 07:59:46 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=igor.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peWuF-00037K-8t; Tue, 21 Mar 2023 08:59:43 +0100 References: <20230320132755.2150384-1-s.trumtrar@pengutronix.de> <20230320132755.2150384-10-s.trumtrar@pengutronix.de> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Steffen Trumtrar To: Alexandre TORGUE Cc: linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski , Maxime Coquelin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM Date: Tue, 21 Mar 2023 08:14:52 +0100 In-reply-to: Message-ID: <87o7omedqr.fsf@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_005945_282733_574E3498 X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexandre, Alexandre TORGUE writes: > [1. text/plain] > Hi Steffen > > On 3/20/23 14:27, Steffen Trumtrar wrote: >> The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB >> eMMC, up to 16 MB QSPI and up to 128 GB NAND flash. >> Signed-off-by: Steffen Trumtrar >> --- >> Notes: >> checkpatch warns about un-documented binding >> According to checkpatch the binding for "winbond,w25q128" >> used in this dtsi is un-documented. >> However, 'jedec,spi-nor.yaml' defines the pattern >> (winbond,)?w25q(16|32(w|dw)?|64(dw)?|80bl|128(fw)?|256))$" >> so, this should be good!? > > We recently added some yaml fixes and we continue to send others (i.e., GPU yaml > error fix is under review) so please don't add new ones. Some of follownig > errors are directly linked to your board so please fix them. > sorry about that, seems like I wasn't using dt_binding_check correctly :( However, how did you generate these? > arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb: > /soc/i2c@40012000/touch@44: failed to match any schema with compatible: > ['st,stmpe811'] > arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb: > /soc/i2c@40012000/touch@44/touchscreen: failed to match any schema with > compatible: ['st,stmpe-ts'] > arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb: /soc/i2c@40012000/leds@62: > failed to match any schema with compatible: ['nxp,pca9533'] The bindings are there and if I explicitly run dt_bindings_check with e.g. Documentation/devicetree/bindings/leds there is no warning/error. I will fixup the rest. Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3C5C6FD1D for ; Tue, 21 Mar 2023 07:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbjCUH7s (ORCPT ); Tue, 21 Mar 2023 03:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbjCUH7r (ORCPT ); Tue, 21 Mar 2023 03:59:47 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E07DA3A843 for ; Tue, 21 Mar 2023 00:59:44 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=igor.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peWuF-00037K-8t; Tue, 21 Mar 2023 08:59:43 +0100 References: <20230320132755.2150384-1-s.trumtrar@pengutronix.de> <20230320132755.2150384-10-s.trumtrar@pengutronix.de> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Steffen Trumtrar To: Alexandre TORGUE Cc: linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski , Maxime Coquelin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM Date: Tue, 21 Mar 2023 08:14:52 +0100 In-reply-to: Message-ID: <87o7omedqr.fsf@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Alexandre, Alexandre TORGUE writes: > [1. text/plain] > Hi Steffen > > On 3/20/23 14:27, Steffen Trumtrar wrote: >> The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB >> eMMC, up to 16 MB QSPI and up to 128 GB NAND flash. >> Signed-off-by: Steffen Trumtrar >> --- >> Notes: >> checkpatch warns about un-documented binding >> According to checkpatch the binding for "winbond,w25q128" >> used in this dtsi is un-documented. >> However, 'jedec,spi-nor.yaml' defines the pattern >> (winbond,)?w25q(16|32(w|dw)?|64(dw)?|80bl|128(fw)?|256))$" >> so, this should be good!? > > We recently added some yaml fixes and we continue to send others (i.e., GPU yaml > error fix is under review) so please don't add new ones. Some of follownig > errors are directly linked to your board so please fix them. > sorry about that, seems like I wasn't using dt_binding_check correctly :( However, how did you generate these? > arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb: > /soc/i2c@40012000/touch@44: failed to match any schema with compatible: > ['st,stmpe811'] > arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb: > /soc/i2c@40012000/touch@44/touchscreen: failed to match any schema with > compatible: ['st,stmpe-ts'] > arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb: /soc/i2c@40012000/leds@62: > failed to match any schema with compatible: ['nxp,pca9533'] The bindings are there and if I explicitly run dt_bindings_check with e.g. Documentation/devicetree/bindings/leds there is no warning/error. I will fixup the rest. Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |