From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [git commit] boot/barebox: use $$ instead of $ where needed
Date: Wed, 22 Feb 2023 17:11:13 +0100 [thread overview]
Message-ID: <87o7plvfxa.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20230206105723.71FF4838DC@busybox.osuosl.org> (Thomas Petazzoni via buildroot's message of "Mon, 6 Feb 2023 11:57:08 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=75c313816eb526fe09a6baab8b327279e01be5ef
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> Commit c90bd74ebb264ccc925f10a142ccd82ef63a4601 ("boot/barebox: pass
> required environment variables for reproducible build") caused the
> build to generate a spurious error message due to the $(shell
> ... date -d @$(SOURCE_DATE_EPOCH)) command being executed even when
> BR2_REPRODUCIBLE was disabled.
> This is due to the fact that variable references must be done using $$
> within macros. This commit fixes that for the two variables that we
> are referencing in the code added in commit
> c90bd74ebb264ccc925f10a142ccd82ef63a4601.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2022.11.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-22 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 10:57 [Buildroot] [git commit] boot/barebox: use $$ instead of $ where needed Thomas Petazzoni via buildroot
2023-02-22 16:11 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7plvfxa.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.