From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: From: Cornelia Huck In-Reply-To: References: <20230220093551.1619951-1-alvaro.karsz@solid-run.com> Date: Mon, 20 Feb 2023 11:25:16 +0100 Message-ID: <87o7poljlf.fsf@redhat.com> MIME-Version: 1.0 Subject: Re: [virtio-dev] Re: [PATCH] virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit Content-Type: text/plain To: Alvaro Karsz , mst@redhat.com Cc: jasowang@redhat.com, virtio-comment@lists.oasis-open.org, hengqi@linux.alibaba.com, parav@nvidia.com, "virtio-dev @ lists . oasis-open . org" List-ID: On Mon, Feb 20 2023, Alvaro Karsz wrote: > I didn't add the control vq feature as a feature bit requirement for > the same reason as [1]. > > If you think that we can add a feature bit requirement instead of > "SHOULD NOT offer" and "SHOULD NOT negotiate", I can add it in v2. > > [1] https://github.com/oasis-tcs/virtio-spec/issues/158 I agree that we need to stick with SHOULD here. Are VIRTIO_NET_F_CTRL_RX_EXTRA and VIRTIO_NET_F_CTRL_RX independent of each other, i.e. can you negotiate VIRTIO_NET_F_CTRL_RX_EXTRA but not VIRTIO_NET_F_CTRL_RX? Looks like it to me, but would like to confirm. (We would at most be able to add a SHOULD statement anyway.) --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org