From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F2BDC636CC for ; Tue, 31 Jan 2023 14:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t6ThawqW3GMpgME4hpx8rRHgTm4NmrGHGahMoAlyfjI=; b=ePFSmGCncTV1lc 0/D9yMjPCalZuA+CWIuyDjWJEP2jYWetutS0a4YWEm6ZaTD7k19Sieuw81oaEiQPqnVRp/m+WHLRn rH+YUTlmfmm4wghKWAyngpFWB73Fk390Lms8InXDsPjLKTvdOluSoJWJjPp3XIbDcODp4nrydvGTi Eowaxj/WNZ4pCGOou2Z22pTE654lp5ejzf61//hgoYKycP+QUyBIVxvltFRoqxUXLyR6a7YXmnaJ7 WjddK7JGjiML6w04Xsgx5xbkF2BZdjHWYx9MOFIp43IQ2SEbZ8r14FjVFJJXn0RdcCTY20F1iUFk8 5cK2ACXsJ2jVktTumNBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMrnU-008Joh-1U; Tue, 31 Jan 2023 14:39:44 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMrnQ-008JnM-HB for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 14:39:42 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B19E4C000C; Tue, 31 Jan 2023 14:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1675175974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGOCmZXkzDIr1SkQAHhEaNwnpysSKPubHEZh+d3fk54=; b=R/udLyfxLz6s+Ng61h8q3eqE6CLA/dMBIn6Qjrk7XvYFDPKMtCh8vs/fHyW34UqbdcsXyI 7jm9OO3cXOKqEFiS24dXrpZ2Zrmeq3j85LKHaIne5mEhTiki6UUMlg0XvAXMVEKUgu5KMI eKvggYb/82AxFLcyVlCE/fqFGqpTe37tZBTnnoZq3NSsFDAYKEjEBURJDBxEu6Wj0qnUXi Dz5xUrnMoHHJFm4LDw1g+Q0tWV78IIzS8zVcnsFlfF07vxRnz5ssdboXqUaPTahRU4JCet o3EyLOhlawqulMLqBuWNkddv3SfFchHCnb9e3gBnjGJCn4cGPXFr9hg+R6y1eQ== From: Gregory CLEMENT To: =?utf-8?Q?Micha=C5=82?= Grzelak , linux-kernel@vger.kernel.org Cc: andrew@lunn.ch, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, mw@semihalf.com, upstream@semihalf.com, mchl.grzlk@gmail.com, =?utf-8?Q?Micha=C5=82?= Grzelak Subject: Re: [PATCH v3] ARM: dts: dove.dtsi: Move ethphy to fix schema error In-Reply-To: <20221229180155.99303-1-mig@semihalf.com> References: <20221229180155.99303-1-mig@semihalf.com> Date: Tue, 31 Jan 2023 15:39:28 +0100 Message-ID: <87o7qebwf3.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_063940_905105_F6AB4A56 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TWljaGHFgiBHcnplbGFrIDxtaWdAc2VtaWhhbGYuY29tPiB3cml0ZXM6Cgo+IFJ1bm5pbmcgJ21h a2UgZHRic19jaGVjaycgd2l0aCBzY2hlbWEgaW4gbmV0L21hcnZlbGwsb3Jpb24tbWRpby55YW1s Cj4gZ2l2ZXMgZm9sbG93aW5nIHdhcm5pbmdzOgo+IG1kaW8tYnVzQDcyMDA0OiBVbmV2YWx1YXRl ZCBwcm9wZXJ0aWVzIGFyZSBub3QgYWxsb3dlZAo+ICgnZXRoZXJuZXQtcGh5JyB3YXMgdW5leHBl Y3RlZCkKPiAJYXJjaC9hcm0vYm9vdC9kdHMvZG92ZS1jdWJveC5kdGIKPiAJYXJjaC9hcm0vYm9v dC9kdHMvZG92ZS1jdWJveC1lcy5kdGIKPiAJYXJjaC9hcm0vYm9vdC9kdHMvZG92ZS1kMnBsdWcu ZHRiCj4gCWFyY2gvYXJtL2Jvb3QvZHRzL2RvdmUtZDJwbHVnLmR0Ygo+IAlhcmNoL2FybS9ib290 L2R0cy9kb3ZlLWRvdmUtZGIuZHRiCj4gCWFyY2gvYXJtL2Jvb3QvZHRzL2RvdmUtZDNwbHVnLmR0 Ygo+IAlhcmNoL2FybS9ib290L2R0cy9kb3ZlLXNiYy1hNTEwLmR0Ygo+IEFzIGV2ZXJ5IHN1Ym5v ZGUgb2YgbWRpbyBpcyBleHBlY3RlZCB0byBoYXZlIGFuIEBYLCBldGhlcm5ldC1waHkgc3Vibm9k ZQo+IGluIGRvdmUuZHRzaSBkb2Vzbid0IGhhdmUgb25lLiBGaXggdGhlc2UgZXJyb3JzIGJ5IG1v dmluZyBldGhlcm5ldC1waHkKPiBpbnRvIHJlbGV2YW50IC5kdHMgZmlsZXMgd2l0aCBjb3JyZWN0 IEA8cmVnIGFkZHJlc3M+Lgo+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGHFgiBHcnplbGFrIDxtaWdA c2VtaWhhbGYuY29tPgoKQXBwbGllZCBvbiBtdmVidS9kdAoKVGhhbmtzLAoKR3JlZ29yeQoKPiAt LS0KPiBDaGFuZ2Vsb2c6Cj4gdjItPnYzCj4gLSBlZGl0IGNvbW1pdCBtZXNzYWdlIGFjY29yZGlu ZyB0bwo+ICAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsL1k2enVKcmIrOGorWENrc05AbHVu bi5jaC8KPgo+IHYxLT52Mgo+IC0gcmVtb3ZlIHBhdHRlcm5Qcm9wZXJ0aWVzOiBmcm9tIC55YW1s Cj4gLSBtb3ZlIGV0aHBoeSBmcm9tIGRvdmUuZHRzaSBpbnRvIHJlbGV2YW50IC5kdHMgZmlsZXMK Pgo+ICBhcmNoL2FybS9ib290L2R0cy9kb3ZlLWNtLWE1MTAuZHRzaSB8IDE0ICsrKysrKysrKysr LS0tCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL2RvdmUtY3Vib3guZHRzICAgIHwgMTUgKysrKysrKysr KystLS0tCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL2RvdmUuZHRzaSAgICAgICAgIHwgIDUgLS0tLS0K PiAgMyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9kb3ZlLWNtLWE1MTAuZHRzaSBiL2FyY2gv YXJtL2Jvb3QvZHRzL2RvdmUtY20tYTUxMC5kdHNpCj4gaW5kZXggOWI5ZGZiZTA3YmU0Li4yZjJm MGE0YmYwMDQgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvZG92ZS1jbS1hNTEwLmR0 c2kKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9kb3ZlLWNtLWE1MTAuZHRzaQo+IEBAIC0xMjQs OSArMTI0LDE3IEBAIHdpZmlfcG93ZXI6IHJlZ3VsYXRvckAxIHsKPiAgfTsKPiAgCj4gIC8qIE9w dGlvbmFsIFJUTDgyMTFEIEdiRSBQSFkgb24gU01JIGFkZHJlc3MgMHgwMyAqLwo+IC0mZXRocGh5 IHsKPiAtCXJlZyA9IDwzPjsKPiAtCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKyZtZGlvIHsKPiAr CWV0aHBoeTogZXRoZXJuZXQtcGh5QDMgewo+ICsJCXJlZyA9IDwzPjsKPiArCQlzdGF0dXMgPSAi ZGlzYWJsZWQiOwo+ICsJfTsKPiArfTsKPiArCj4gKyZldGggewo+ICsJZXRoZXJuZXQtcG9ydEAw IHsKPiArCQlwaHktaGFuZGxlID0gPCZldGhwaHk+Owo+ICsJfTsKPiAgfTsKPiAgCj4gICZpMmMw IHsKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvZG92ZS1jdWJveC5kdHMgYi9hcmNo L2FybS9ib290L2R0cy9kb3ZlLWN1Ym94LmR0cwo+IGluZGV4IDI2MzliOWZlMGFiNC4uMTcwYzE0 ZDdmNWM4IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2RvdmUtY3Vib3guZHRzCj4g KysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvZG92ZS1jdWJveC5kdHMKPiBAQCAtNzIsMTEgKzcyLDE4 IEBAIGdwdS1zdWJzeXN0ZW0gewo+ICAmdWFydDAgeyBzdGF0dXMgPSAib2theSI7IH07Cj4gICZz YXRhMCB7IHN0YXR1cyA9ICJva2F5IjsgfTsKPiAgJm1kaW8geyBzdGF0dXMgPSAib2theSI7IH07 Cj4gLSZldGggeyBzdGF0dXMgPSAib2theSI7IH07Cj4gKyZldGggewo+ICsJc3RhdHVzID0gIm9r YXkiOwo+ICsJZXRoZXJuZXQtcG9ydEAwIHsKPiArCQlwaHktaGFuZGxlID0gPCZldGhwaHk+Owo+ ICsJfTsKPiArfTsKPiAgCj4gLSZldGhwaHkgewo+IC0JY29tcGF0aWJsZSA9ICJtYXJ2ZWxsLDg4 ZTEzMTAiOwo+IC0JcmVnID0gPDE+Owo+ICsmbWRpbyB7Cj4gKwlldGhwaHk6IGV0aGVybmV0LXBo eUAxIHsKPiArCQljb21wYXRpYmxlID0gIm1hcnZlbGwsODhlMTMxMCI7Cj4gKwkJcmVnID0gPDE+ Owo+ICsJfTsKPiAgfTsKPiAgCj4gICZncHUgewo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290 L2R0cy9kb3ZlLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9kb3ZlLmR0c2kKPiBpbmRleCAwMGEz NmZiYTJmZDIuLmM3YTNmYTMzYzU2ZSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9k b3ZlLmR0c2kKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9kb3ZlLmR0c2kKPiBAQCAtMzgyLDcg KzM4Miw2IEBAIGV0aGVybmV0LXBvcnRAMCB7Cj4gIAkJCQkJaW50ZXJydXB0cyA9IDwyOT47Cj4g IAkJCQkJLyogb3ZlcndyaXRlIE1BQyBhZGRyZXNzIGluIGJvb3Rsb2FkZXIgKi8KPiAgCQkJCQls b2NhbC1tYWMtYWRkcmVzcyA9IFswMCAwMCAwMCAwMCAwMCAwMF07Cj4gLQkJCQkJcGh5LWhhbmRs ZSA9IDwmZXRocGh5PjsKPiAgCQkJCX07Cj4gIAkJCX07Cj4gIAo+IEBAIC0zOTQsMTAgKzM5Myw2 IEBAIG1kaW86IG1kaW8tYnVzQDcyMDA0IHsKPiAgCQkJCWludGVycnVwdHMgPSA8MzA+Owo+ICAJ CQkJY2xvY2tzID0gPCZnYXRlX2NsayAyPjsKPiAgCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4g LQo+IC0JCQkJZXRocGh5OiBldGhlcm5ldC1waHkgewo+IC0JCQkJCS8qIHNldCBwaHkgYWRkcmVz cyBpbiBib2FyZCBmaWxlICovCj4gLQkJCQl9Owo+ICAJCQl9Owo+ICAKPiAgCQkJc2RpbzA6IHNk aW8taG9zdEA5MjAwMCB7Cj4gLS0gCj4gMi4zNC4xCj4KCi0tIApHcmVnb3J5IENsZW1lbnQsIEJv b3RsaW4KRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwOi8vYm9vdGxp bi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F11C38142 for ; Tue, 31 Jan 2023 14:39:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229468AbjAaOjj (ORCPT ); Tue, 31 Jan 2023 09:39:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231287AbjAaOji (ORCPT ); Tue, 31 Jan 2023 09:39:38 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B6355B95; Tue, 31 Jan 2023 06:39:36 -0800 (PST) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B19E4C000C; Tue, 31 Jan 2023 14:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1675175974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGOCmZXkzDIr1SkQAHhEaNwnpysSKPubHEZh+d3fk54=; b=R/udLyfxLz6s+Ng61h8q3eqE6CLA/dMBIn6Qjrk7XvYFDPKMtCh8vs/fHyW34UqbdcsXyI 7jm9OO3cXOKqEFiS24dXrpZ2Zrmeq3j85LKHaIne5mEhTiki6UUMlg0XvAXMVEKUgu5KMI eKvggYb/82AxFLcyVlCE/fqFGqpTe37tZBTnnoZq3NSsFDAYKEjEBURJDBxEu6Wj0qnUXi Dz5xUrnMoHHJFm4LDw1g+Q0tWV78IIzS8zVcnsFlfF07vxRnz5ssdboXqUaPTahRU4JCet o3EyLOhlawqulMLqBuWNkddv3SfFchHCnb9e3gBnjGJCn4cGPXFr9hg+R6y1eQ== From: Gregory CLEMENT To: =?utf-8?Q?Micha=C5=82?= Grzelak , linux-kernel@vger.kernel.org Cc: andrew@lunn.ch, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, mw@semihalf.com, upstream@semihalf.com, mchl.grzlk@gmail.com, =?utf-8?Q?Micha=C5=82?= Grzelak Subject: Re: [PATCH v3] ARM: dts: dove.dtsi: Move ethphy to fix schema error In-Reply-To: <20221229180155.99303-1-mig@semihalf.com> References: <20221229180155.99303-1-mig@semihalf.com> Date: Tue, 31 Jan 2023 15:39:28 +0100 Message-ID: <87o7qebwf3.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Micha=C5=82 Grzelak writes: > Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml > gives following warnings: > mdio-bus@72004: Unevaluated properties are not allowed > ('ethernet-phy' was unexpected) > arch/arm/boot/dts/dove-cubox.dtb > arch/arm/boot/dts/dove-cubox-es.dtb > arch/arm/boot/dts/dove-d2plug.dtb > arch/arm/boot/dts/dove-d2plug.dtb > arch/arm/boot/dts/dove-dove-db.dtb > arch/arm/boot/dts/dove-d3plug.dtb > arch/arm/boot/dts/dove-sbc-a510.dtb > As every subnode of mdio is expected to have an @X, ethernet-phy subnode > in dove.dtsi doesn't have one. Fix these errors by moving ethernet-phy > into relevant .dts files with correct @. > > Signed-off-by: Micha=C5=82 Grzelak Applied on mvebu/dt Thanks, Gregory > --- > Changelog: > v2->v3 > - edit commit message according to > https://lore.kernel.org/all/Y6zuJrb+8j+XCksN@lunn.ch/ > > v1->v2 > - remove patternProperties: from .yaml > - move ethphy from dove.dtsi into relevant .dts files > > arch/arm/boot/dts/dove-cm-a510.dtsi | 14 +++++++++++--- > arch/arm/boot/dts/dove-cubox.dts | 15 +++++++++++---- > arch/arm/boot/dts/dove.dtsi | 5 ----- > 3 files changed, 22 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/boot/dts/dove-cm-a510.dtsi b/arch/arm/boot/dts/dove= -cm-a510.dtsi > index 9b9dfbe07be4..2f2f0a4bf004 100644 > --- a/arch/arm/boot/dts/dove-cm-a510.dtsi > +++ b/arch/arm/boot/dts/dove-cm-a510.dtsi > @@ -124,9 +124,17 @@ wifi_power: regulator@1 { > }; >=20=20 > /* Optional RTL8211D GbE PHY on SMI address 0x03 */ > -ðphy { > - reg =3D <3>; > - status =3D "disabled"; > +&mdio { > + ethphy: ethernet-phy@3 { > + reg =3D <3>; > + status =3D "disabled"; > + }; > +}; > + > +ð { > + ethernet-port@0 { > + phy-handle =3D <ðphy>; > + }; > }; >=20=20 > &i2c0 { > diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cu= box.dts > index 2639b9fe0ab4..170c14d7f5c8 100644 > --- a/arch/arm/boot/dts/dove-cubox.dts > +++ b/arch/arm/boot/dts/dove-cubox.dts > @@ -72,11 +72,18 @@ gpu-subsystem { > &uart0 { status =3D "okay"; }; > &sata0 { status =3D "okay"; }; > &mdio { status =3D "okay"; }; > -ð { status =3D "okay"; }; > +ð { > + status =3D "okay"; > + ethernet-port@0 { > + phy-handle =3D <ðphy>; > + }; > +}; >=20=20 > -ðphy { > - compatible =3D "marvell,88e1310"; > - reg =3D <1>; > +&mdio { > + ethphy: ethernet-phy@1 { > + compatible =3D "marvell,88e1310"; > + reg =3D <1>; > + }; > }; >=20=20 > &gpu { > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > index 00a36fba2fd2..c7a3fa33c56e 100644 > --- a/arch/arm/boot/dts/dove.dtsi > +++ b/arch/arm/boot/dts/dove.dtsi > @@ -382,7 +382,6 @@ ethernet-port@0 { > interrupts =3D <29>; > /* overwrite MAC address in bootloader */ > local-mac-address =3D [00 00 00 00 00 00]; > - phy-handle =3D <ðphy>; > }; > }; >=20=20 > @@ -394,10 +393,6 @@ mdio: mdio-bus@72004 { > interrupts =3D <30>; > clocks =3D <&gate_clk 2>; > status =3D "disabled"; > - > - ethphy: ethernet-phy { > - /* set phy address in board file */ > - }; > }; >=20=20 > sdio0: sdio-host@92000 { > --=20 > 2.34.1 > --=20 Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com