From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE18C05027 for ; Mon, 23 Jan 2023 16:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232709AbjAWQev (ORCPT ); Mon, 23 Jan 2023 11:34:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231592AbjAWQev (ORCPT ); Mon, 23 Jan 2023 11:34:51 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4038228874 for ; Mon, 23 Jan 2023 08:34:50 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id b4so15320979edf.0 for ; Mon, 23 Jan 2023 08:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=dHio8a3tIrQaWpph9OBwqj4XpRUo5bPq+VspbIj+xTs=; b=QhAE20mnYiKKOlJhdSQ8kVPDlDvUjQNa3d25KqW/oAn8ghq5yRQdgPnUe/2lDAO+x0 kx4Kftcf1MA5y6PDWx0RQvPgZkYY+EtCIswLYZzhq5S0hDQBT3roLE4d4dzlVNv8n3z7 7WIAHbXBn/O6NQfY+5aNQiIew2tGAXIpdNBexsKOZfCr9mhWBvvvAJKsRrRbXGO3Eqc4 /6iWNbEzsCSDgt2F5zxU7gGw1G3i5M2PdjXiQV45qfnqtF0Azgz5c4Cxs2JTKmfobGGQ CWkMYEeEw9Xga4YfWt+Rag8vTcMcYJ9zdTqf+s2Iy5J2zf6dFxJyXxs1kza/Y9upFmi7 Yd4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dHio8a3tIrQaWpph9OBwqj4XpRUo5bPq+VspbIj+xTs=; b=N2a51SunhLZAAk8n+JHOO7XCd+eZuF0F8qXmx1WI3eA1xIPKDRT49lO17ycJxfWN2s TUByN0dspShcQDs0H2Ug1l0823ZuCRc+QeJbL7+svblWTx/o0g9818X56p+EKFJrNvR4 rFb9kEl47puZW3vpj6o0mqNCXxQsfInhWM/JUwxQn6e/Yj+2zjty5LohDXH+jXfaHmw0 Zymcy6c2Jv/eT4KB9DEPC7RrTtuHBa3RAoFvz0n8cE0/H4nf5f+8LTqwfW8Pc6fGH78l rvbeJEnpyl7qKx2z9yHjAva3Zsb3B03HBxi93FJLMQHGjeutqZq5Lhd6uJ5rxQc6lkqQ S32g== X-Gm-Message-State: AFqh2kpNIA5A5rnQU4JAC2xDuAOnxNzykhUPD7TOTfWv1jIyJZlFmZVP 3lNVFZxDcMj+mwdJMqTc8is= X-Google-Smtp-Source: AMrXdXvAEjqpa5P3+tgI4gAQbvm7ZLRbw4gaKg/RDH9IyV5sJy1FRpBmOJyUrxw8WilY66p6ZSbk5Q== X-Received: by 2002:a05:6402:cba:b0:49d:25f3:6b4e with SMTP id cn26-20020a0564020cba00b0049d25f36b4emr26145826edb.28.1674491688704; Mon, 23 Jan 2023 08:34:48 -0800 (PST) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id n20-20020a05640205d400b0049e4458c991sm8610242edx.64.2023.01.23.08.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 08:34:47 -0800 (PST) From: Sergey Organov To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: Stefan Wahren , linux-serial , Fabio Estevam , Greg Kroah-Hartman , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , Tomasz =?utf-8?Q?Mo=C5=84?= , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Johan Hovold , Sherry Sun , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH v1 3/7] serial: imx: do not sysrq broken chars References: <87bko4e65y.fsf@osv.gnss.ru> <20230121153639.15402-1-sorganov@gmail.com> <20230121153639.15402-4-sorganov@gmail.com> <6dc81996-6ffc-c1bc-6c3f-ca65055c94a2@i2se.com> <87fsc3wqdl.fsf@osv.gnss.ru> <34438e1a-1978-7c66-26b-311258a86e30@linux.intel.com> Date: Mon, 23 Jan 2023 19:34:46 +0300 In-Reply-To: <34438e1a-1978-7c66-26b-311258a86e30@linux.intel.com> ("Ilpo =?utf-8?Q?J=C3=A4rvinen=22's?= message of "Mon, 23 Jan 2023 14:38:15 +0200 (EET)") Message-ID: <87o7qp43bt.fsf@osv.gnss.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Ilpo Järvinen writes: > On Sun, 22 Jan 2023, Sergey Organov wrote: > >> Hi Stefan, >> >> Stefan Wahren writes: >> >> > Hi Sergey, >> > >> > Am 21.01.23 um 16:36 schrieb Sergey Organov: >> >> Do not call uart_handle_sysrq_char() if we got any receive error >> >> along with the character, as we don't want random junk to be >> >> considered a sysrq. >> >> Signed-off-by: Sergey Organov >> > >> > this looks like a bugfix to me. Since the relevant code is pretty old, >> > i'm not sure about the fixes tag here: >> > >> > Fixes: 279a9acc9b72 ("2.6.11 import") ? >> >> Dunno. I've checked a few drivers, and it seems that they don't care >> either, e.g., look at atmel_serial.c, or mpc52xx_uart.c. >> >> Either it doesn't matter, or a few drivers need similar fix? What's >> going on here, I wonder? > > Usually when one finds a bug from one of the drivers, the other drivers > indeed turn out to have the same/similar bug(s). It's not something > uncommon. Yep, it looks like deriving from the same template, with the same issue. > > So just fix them all, it's very much appreciated. :-) I understand it > might not be possible to test all such fixes on those other HWs but > usually such bugs are simple enough to fix that it isn't be a big problem. I'm not even sure this is really a bug, as nobody seems to confirm it with authority yet. Thanks, -- Sergey Organov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C67EDC05027 for ; Mon, 23 Jan 2023 16:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gH8pim9vr7ikeMuIuUxJab973uxkL2Q1wVJ+OD5/AB4=; b=PWXa7mCsIXZp37 FanwQcYRTE9juR+31RyZIcXasMSXlxT1Jk810h+BJPndbXKadzWizjdZvMH+vi5IazjN08SOFt+z9 e94Ow1MJVcCKfjw+dVKpcIeIX3nC9mTvqVAMvntDDm0jQlQtA6V+aN006WMRzeumJqKZ1zNTP+Tws M9oXh99JcUhiitMEp3+jyEtEVeoMNNO2GL3wKOLjkPLVMw2JUpVstErQjLqxW8mYp0rmrZUuUDz0d l4wYwIwAuZoKa8QLcL6YT1zjQNg6JYt3bi7E2WDp9BuPIY5uvwSITNW3YN3VMu2UZixAQolYFujlA NvSpGiyzytwcKj6IiGFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJzot-000bCJ-9w; Mon, 23 Jan 2023 16:37:20 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJzmV-000a7D-Bn for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 16:34:52 +0000 Received: by mail-ed1-x532.google.com with SMTP id s3so15261066edd.4 for ; Mon, 23 Jan 2023 08:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=dHio8a3tIrQaWpph9OBwqj4XpRUo5bPq+VspbIj+xTs=; b=QhAE20mnYiKKOlJhdSQ8kVPDlDvUjQNa3d25KqW/oAn8ghq5yRQdgPnUe/2lDAO+x0 kx4Kftcf1MA5y6PDWx0RQvPgZkYY+EtCIswLYZzhq5S0hDQBT3roLE4d4dzlVNv8n3z7 7WIAHbXBn/O6NQfY+5aNQiIew2tGAXIpdNBexsKOZfCr9mhWBvvvAJKsRrRbXGO3Eqc4 /6iWNbEzsCSDgt2F5zxU7gGw1G3i5M2PdjXiQV45qfnqtF0Azgz5c4Cxs2JTKmfobGGQ CWkMYEeEw9Xga4YfWt+Rag8vTcMcYJ9zdTqf+s2Iy5J2zf6dFxJyXxs1kza/Y9upFmi7 Yd4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dHio8a3tIrQaWpph9OBwqj4XpRUo5bPq+VspbIj+xTs=; b=vt5NsrK9w+PgpyuZY2ncWGIXvECIMmvxPYUIfxzIvKO8+Ekw9NXh5pC/SHlTyVgKq0 TsCzPvi2c01QP/X9nNouzDz0JU7+0KMorbR3lAZjbXU7HXyRwU4Lg8Bu5wqbWKoH7aXm /qojd6N0a/YFAWsPd3m+zgxLIi79Vwi5LebRHgiSdaQwgqwu33Jrc5oqKRDzyAx88qnT 83iEXGJTC5i+Z3awvSF/izgViUxqVkM2W077YObif+dbZIIxJ746Uet43DUcv4+CvE+N g+SO+QD3mqvAtkK5kW4DxhUItVeWyHPtuG8JfF56KuC7BFHVc2sj3CllzNKEfpMc80zr ZHyQ== X-Gm-Message-State: AFqh2kpzuQCB34ehkzLw+c144XLL/eIzS83I7r8sBvYjqDkbgB6UWBHX NiH7RyBybGjb/kEGPkfkn8M= X-Google-Smtp-Source: AMrXdXvAEjqpa5P3+tgI4gAQbvm7ZLRbw4gaKg/RDH9IyV5sJy1FRpBmOJyUrxw8WilY66p6ZSbk5Q== X-Received: by 2002:a05:6402:cba:b0:49d:25f3:6b4e with SMTP id cn26-20020a0564020cba00b0049d25f36b4emr26145826edb.28.1674491688704; Mon, 23 Jan 2023 08:34:48 -0800 (PST) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id n20-20020a05640205d400b0049e4458c991sm8610242edx.64.2023.01.23.08.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 08:34:47 -0800 (PST) From: Sergey Organov To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: Stefan Wahren , linux-serial , Fabio Estevam , Greg Kroah-Hartman , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , Tomasz =?utf-8?Q?Mo=C5=84?= , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Johan Hovold , Sherry Sun , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH v1 3/7] serial: imx: do not sysrq broken chars References: <87bko4e65y.fsf@osv.gnss.ru> <20230121153639.15402-1-sorganov@gmail.com> <20230121153639.15402-4-sorganov@gmail.com> <6dc81996-6ffc-c1bc-6c3f-ca65055c94a2@i2se.com> <87fsc3wqdl.fsf@osv.gnss.ru> <34438e1a-1978-7c66-26b-311258a86e30@linux.intel.com> Date: Mon, 23 Jan 2023 19:34:46 +0300 In-Reply-To: <34438e1a-1978-7c66-26b-311258a86e30@linux.intel.com> ("Ilpo =?utf-8?Q?J=C3=A4rvinen=22's?= message of "Mon, 23 Jan 2023 14:38:15 +0200 (EET)") Message-ID: <87o7qp43bt.fsf@osv.gnss.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_083451_476936_EA41F760 X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWxwbyBKw6RydmluZW4gPGlscG8uamFydmluZW5AbGludXguaW50ZWwuY29tPiB3cml0ZXM6Cgo+ IE9uIFN1biwgMjIgSmFuIDIwMjMsIFNlcmdleSBPcmdhbm92IHdyb3RlOgo+Cj4+IEhpIFN0ZWZh biwKPj4gCj4+IFN0ZWZhbiBXYWhyZW4gPHN0ZWZhbi53YWhyZW5AaTJzZS5jb20+IHdyaXRlczoK Pj4gCj4+ID4gSGkgU2VyZ2V5LAo+PiA+Cj4+ID4gQW0gMjEuMDEuMjMgdW0gMTY6MzYgc2Nocmll YiBTZXJnZXkgT3JnYW5vdjoKPj4gPj4gRG8gbm90IGNhbGwgdWFydF9oYW5kbGVfc3lzcnFfY2hh cigpIGlmIHdlIGdvdCBhbnkgcmVjZWl2ZSBlcnJvcgo+PiA+PiBhbG9uZyB3aXRoIHRoZSBjaGFy YWN0ZXIsIGFzIHdlIGRvbid0IHdhbnQgcmFuZG9tIGp1bmsgdG8gYmUKPj4gPj4gY29uc2lkZXJl ZCBhIHN5c3JxLgo+PiA+PiBTaWduZWQtb2ZmLWJ5OiBTZXJnZXkgT3JnYW5vdiA8c29yZ2Fub3ZA Z21haWwuY29tPgo+PiA+Cj4+ID4gdGhpcyBsb29rcyBsaWtlIGEgYnVnZml4IHRvIG1lLiBTaW5j ZSB0aGUgcmVsZXZhbnQgY29kZSBpcyBwcmV0dHkgb2xkLAo+PiA+IGknbSBub3Qgc3VyZSBhYm91 dCB0aGUgZml4ZXMgdGFnIGhlcmU6Cj4+ID4KPj4gPiBGaXhlczogMjc5YTlhY2M5YjcyICgiMi42 LjExIGltcG9ydCIpID8KPj4gCj4+IER1bm5vLiBJJ3ZlIGNoZWNrZWQgYSBmZXcgZHJpdmVycywg YW5kIGl0IHNlZW1zIHRoYXQgdGhleSBkb24ndCBjYXJlCj4+IGVpdGhlciwgZS5nLiwgbG9vayBh dCBhdG1lbF9zZXJpYWwuYywgb3IgbXBjNTJ4eF91YXJ0LmMuCj4+IAo+PiBFaXRoZXIgaXQgZG9l c24ndCBtYXR0ZXIsIG9yIGEgZmV3IGRyaXZlcnMgbmVlZCBzaW1pbGFyIGZpeD8gV2hhdCdzCj4+ IGdvaW5nIG9uIGhlcmUsIEkgd29uZGVyPwo+Cj4gVXN1YWxseSB3aGVuIG9uZSBmaW5kcyBhIGJ1 ZyBmcm9tIG9uZSBvZiB0aGUgZHJpdmVycywgdGhlIG90aGVyIGRyaXZlcnMgCj4gaW5kZWVkIHR1 cm4gb3V0IHRvIGhhdmUgdGhlIHNhbWUvc2ltaWxhciBidWcocykuICBJdCdzIG5vdCBzb21ldGhp bmcgCj4gdW5jb21tb24uCgpZZXAsIGl0IGxvb2tzIGxpa2UgZGVyaXZpbmcgZnJvbSB0aGUgc2Ft ZSB0ZW1wbGF0ZSwgd2l0aCB0aGUgc2FtZSBpc3N1ZS4KCj4KPiBTbyBqdXN0IGZpeCB0aGVtIGFs bCwgaXQncyB2ZXJ5IG11Y2ggYXBwcmVjaWF0ZWQuIDotKSBJIHVuZGVyc3RhbmQgaXQgCj4gbWln aHQgbm90IGJlIHBvc3NpYmxlIHRvIHRlc3QgYWxsIHN1Y2ggZml4ZXMgb24gdGhvc2Ugb3RoZXIg SFdzIGJ1dCAKPiB1c3VhbGx5IHN1Y2ggYnVncyBhcmUgc2ltcGxlIGVub3VnaCB0byBmaXggdGhh dCBpdCBpc24ndCBiZSBhIGJpZyBwcm9ibGVtLgoKSSdtIG5vdCBldmVuIHN1cmUgdGhpcyBpcyBy ZWFsbHkgYSBidWcsIGFzIG5vYm9keSBzZWVtcyB0byBjb25maXJtIGl0CndpdGggYXV0aG9yaXR5 IHlldC4KClRoYW5rcywKLS0gU2VyZ2V5IE9yZ2Fub3YKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK