Re: [PATCH] dt-bindings: input: gpio-beeper: Convert to yaml schema

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

On Sat, Nov 19, 2022 at 22:21, Fabio Estevam <festevam@gmail.com> wrote:

> From: Fabio Estevam <festevam@denx.de>
>
> Convert the bindings from plain text to yaml schema.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Small nit below, but I don't think it matters, so:

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  .../devicetree/bindings/input/gpio-beeper.txt | 13 --------
>  .../bindings/input/gpio-beeper.yaml           | 33 +++++++++++++++++++
>  2 files changed, 33 insertions(+), 13 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/gpio-beeper.txt
>  create mode 100644 Documentation/devicetree/bindings/input/gpio-beeper.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/gpio-beeper.txt b/Documentation/devicetree/bindings/input/gpio-beeper.txt
> deleted file mode 100644
> index a5086e37fce6..000000000000
> --- a/Documentation/devicetree/bindings/input/gpio-beeper.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -* GPIO beeper device tree bindings
> -
> -Register a beeper connected to GPIO pin.
> -
> -Required properties:
> -- compatible:	Should be "gpio-beeper".
> -- gpios:	From common gpio binding; gpio connection to beeper enable pin.
> -
> -Example:
> -	beeper: beeper {
> -		compatible = "gpio-beeper";
> -		gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> -	};
> diff --git a/Documentation/devicetree/bindings/input/gpio-beeper.yaml b/Documentation/devicetree/bindings/input/gpio-beeper.yaml
> new file mode 100644
> index 000000000000..5fd57a8940df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/gpio-beeper.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/gpio-beeper.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO controlled beeper
> +
> +maintainers:
> +  - Fabio Estevam <festevam@denx.de>
> +
> +properties:
> +  compatible:
> +    const: gpio-beeper
> +
> +  gpios:
> +    maxItems: 1
> +    description:
> +      GPIO that drives the beeper.

We can join these lines:

description: GPIO that drives the beeper.

> +
> +required:
> +  - compatible
> +  - gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    beeper {
> +        compatible = "gpio-beeper";
> +        gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> +    };
> -- 
> 2.25.1